Re: [PATCH weston 1/2] compositor-x11: use _checked() with xkb_select_events to test for error

2012-10-30 Thread Daniel Stone
Hi, On 31 October 2012 09:13, Ran Benita wrote: > In order to use xcb_request_check(), given a request without a reply, > you need to use the _checked() variant of the request function. > See xcb-requests(3). Both these patches look good to me, thanks. Cheers, Daniel ___

[PATCH weston 2/2] compositor-x11: properly initialize XKB extension

2012-10-30 Thread Ran Benita
In order to use XKB capabilities (as we do), the client must issue an XkbUseExtension request: http://www.x.org/releases/current/doc/kbproto/xkbproto.html#Initializing_the_X_Keyboard_Extension The reason this succeeds currently is that XOpenDisplay from Xlib does this for us. But it is better not

[PATCH weston 1/2] compositor-x11: use _checked() with xkb_select_events to test for error

2012-10-30 Thread Ran Benita
In order to use xcb_request_check(), given a request without a reply, you need to use the _checked() variant of the request function. See xcb-requests(3). Signed-off-by: Ran Benita --- src/compositor-x11.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/c

Re: Starting weston next branch

2012-10-30 Thread Scott Moreau
On Tue, Oct 30, 2012 at 12:51 PM, Kristian Høgsberg wrote: > Hi, > > We've talked a bit about branching 1.0 and starting new development on > master, and there's definitely a number of features already waiting to > be merged: Anders headless backend, Tiagos xwayland work, Scotts > minimize etc wor

Starting weston next branch

2012-10-30 Thread Kristian Høgsberg
Hi, We've talked a bit about branching 1.0 and starting new development on master, and there's definitely a number of features already waiting to be merged: Anders headless backend, Tiagos xwayland work, Scotts minimize etc work, Johns GLES2 patches etc. However, instead of branching of 1.0 devel

Re: [PATCH weston 2/2] compositor-drm: prefer primary GPU over other GPUs

2012-10-30 Thread Kristian Høgsberg
On Tue, Oct 30, 2012 at 11:19:01AM +1000, Dave Airlie wrote: > > > > My comment was rather about the information which GPU can be used > > independently by user-space. Anyway, I wasn't aware that the kernel > > provides a boot_vga sysfs attribute with the same information. So I > > can rewrite this

Re: [PATCH weston 1/2] pci: add PCI helpers to detect primary GPUs

2012-10-30 Thread Sannu K
On Mon, Oct 29, 2012 at 9:13 PM, David Herrmann wrote: > Hi Sannu > > On Sun, Oct 28, 2012 at 10:19 AM, Sannu K wrote: GPU switching under linux has no stable API. The vga_switcheroo module only provides some temporary hacks via debugfs. Therefore, the situations you describe

[PATCH weston] toytoolkit: Don't destroy window cairo surface on shm attach.

2012-10-30 Thread Scott Moreau
--- clients/window.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/clients/window.c b/clients/window.c index 7b5e351..49b8a25 100644 --- a/clients/window.c +++ b/clients/window.c @@ -869,8 +869,6 @@ window_attach_surface(struct window *window) window->alloc

Re: [PATCH weston] compositor: Fix partial repaints

2012-10-30 Thread Kristian Høgsberg
On Tue, Oct 30, 2012 at 05:44:01PM +0200, Ander Conselvan de Oliveira wrote: > Partial repaints have been broken since the introduction of the atomic > surface updates. The problem was that surface_commit would set the > geometry dirty flag unconditionally, causing transform updates on every > fram

[PATCH weston] compositor: Fix partial repaints

2012-10-30 Thread Ander Conselvan de Oliveira
Partial repaints have been broken since the introduction of the atomic surface updates. The problem was that surface_commit would set the geometry dirty flag unconditionally, causing transform updates on every frame which would in turn cause weston_surface_damage_below() to damage the whole surface