Re: [krh/wayland/next 1/5] connection: Don't call memcpy with null pointer.

On Fri, Oct 12, 2012 at 3:05 PM, Rob Bradford wrote: > On 12 October 2012 10:28, John Kåre Alsaker > wrote: > >> - if (length > 0) >> + if (length > 0) { >> + memcpy(p, s, length); >> *sp =

Cogl/Clutter test ported to krh/next

For those that are interested (and involved in porting other bits): http://git.gnome.org/browse/cogl/log/?h=rbradford/cogl-1.12/wayland-0.99 http://git.gnome.org/browse/clutter/log/?h=wayland-0.99 Cheerio, Rob ___ wayland-devel mailing list wayland-dev

documentation effort (was doc: Add auto-generated Wayland Library chapter)

Hi all, On 10/12/2012 03:26 PM, Tiago Vignatti wrote: On 10/12/2012 12:57 AM, David Herrmann wrote: I will be looking into writing the XSL files to generate the man-pages. However, it's a mess installing publican here so I will probably not work on the publican XSL files. great! Seems that n

Re: [PATCH vignatti/wayland/doc 2/2] doc: Add some doxygen documentation to wayland-client entry points

cool, thanks! I applied both on my tree and, if you don't mind, I inserted your signed-off-by there. Tiago On 10/12/2012 05:28 PM, Ander Conselvan de Oliveira wrote: Add some brief documentation for the public libwayland-client entry points. This is by no means complete, some funcions are stil

[PATCH vignatti/wayland/doc 2/2] doc: Add some doxygen documentation to wayland-client entry points

Add some brief documentation for the public libwayland-client entry points. This is by no means complete, some funcions are still undocumented and some might need extra information. --- doc/doxygen/wayland.doxygen.in |3 +- src/wayland-client.c | 169

[PATCH vignatti/wayland/doc 1/2] doc: Split protocol description paragraphs properly

The xsl translation from the protocol xml to publican would create only one paragraph for all the text in a description. Make it generate one paragraph for each block of text separated by two consecutive line breaks instead. --- doc/Wayland/protocol-to-docbook.xsl | 29 +-

Re: [krh/wayland/next 1/5] connection: Don't call memcpy with null pointer.

On 12 October 2012 10:28, John Kåre Alsaker wrote: > - if (length > 0) > + if (length > 0) { > + memcpy(p, s, length); > *sp = (const char *) p; > - else > +

Re: [PATCH wayland 4/4] doc: Add auto-generated Wayland Library chapter

On 10/12/2012 12:57 AM, David Herrmann wrote: Hi Tiago On Thu, Oct 11, 2012 at 4:42 PM, Tiago Vignatti wrote: For now only Wayland Client API is described on that chapter, which is extracted via doxygen on ./src/wayland-client.h. We apply a stylesheet (doxygen-to-publican) on doxygen output so

[RFC krh/wayland/next 2/2] protocol: try to clarify wl_buffer doc

Fix few typos in wl_buffer description. Mention backing storage in wl_buffer.destroy. Try to clarify the wl_buffer.release semantics by not explaining what *might* happen. It is important to not suggest, that if release does not come before frame callback, it will not come before attaching a new

[RFC krh/wayland/next 1/2] protocol: say update instead of repaint

wl_surface.commit itself does not force any repainting unless there is damage, so change the wording to not imply repainting. Reported-by: John Kåre Alsaker Signed-off-by: Pekka Paalanen --- protocol/wayland.xml |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/protoco

Re: [RFC wayland 11/12] wayland-client: duplicate fd on connect

On Thu, Oct 11, 2012 at 11:37 PM, David Herrmann wrote: > We need our own copy of the file-descriptor in each wl_display so we can > close() it on error to wake up the main-thread. > > Signed-off-by: David Herrmann > --- Pekka and I discussed this on IRC and we came to the conclusion that it is

[krh/weston/next 8/8] util: Check result of weston_surface_animation_run.

--- src/util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/util.c b/src/util.c index 4390e2e..f18281c 100644 --- a/src/util.c +++ b/src/util.c @@ -265,6 +265,9 @@ weston_slide_run(struct weston_surface *surface, float start, float stop, animation = weston_surface_animatio

[krh/weston/next 7/8] compositor-x11: Fix a memory leak.

--- src/compositor-x11.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compositor-x11.c b/src/compositor-x11.c index 5f64795..5b2271e 100644 --- a/src/compositor-x11.c +++ b/src/compositor-x11.c @@ -1237,6 +1237,7 @@ output_section_done(void *data) if (output_name)

[krh/weston/next 6/8] compositor-x11: Check if an output is found in x11_compositor_deliver_motion_event.

--- src/compositor-x11.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compositor-x11.c b/src/compositor-x11.c index 97c6698..5f64795 100644 --- a/src/compositor-x11.c +++ b/src/compositor-x11.c @@ -760,6 +760,8 @@ x11_compositor_deliver_motion_event(struct x11_compositor *c,

[krh/weston/next 5/8] compositor: Check if surface creation failed in weston_compositor_fade.

--- src/compositor.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compositor.c b/src/compositor.c index e1411a4..1fb7d9f 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -1099,6 +1099,9 @@ weston_compositor_fade(struct weston_compositor *compositor, float tint) if (

[krh/weston/next 4/8] compositor: Avoid dereferencing null pointer in clip_pointer_motion.

--- src/compositor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor.c b/src/compositor.c index f96d675..e1411a4 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -1474,7 +1474,7 @@ clip_pointer_motion(struct weston_seat *seat, wl_fixed_t *fx, wl_fixed_t *

[krh/weston/next 3/8] compositor-x11: Clean up event handling.

--- src/compositor-x11.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/compositor-x11.c b/src/compositor-x11.c index 7ec56ff..97c6698 100644 --- a/src/compositor-x11.c +++ b/src/compositor-x11.c @@ -25,6 +25,7 @@ #include #endif +#include #include

[krh/weston/next 2/8] Remove some dead code.

--- clients/editor.c | 4 +--- tests/setbacklight.c | 13 +++-- 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index 02ee5da..d185137 100644 --- a/clients/editor.c +++ b/clients/editor.c @@ -232,10 +232,8 @@ text_model_commit_string

[krh/weston/next 1/8] weston-launch: Check result of pam_start.

--- src/weston-launch.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/weston-launch.c b/src/weston-launch.c index 36f9c6b..cb69968 100644 --- a/src/weston-launch.c +++ b/src/weston-launch.c @@ -157,6 +157,12 @@ setup_pam(struct weston_launch *wl) wl->pc.appdata_ptr = wl;

[krh/wayland/next 5/5] connection: Dereference id completely for comparasion.

--- src/connection.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/connection.c b/src/connection.c index ad060b0..6878eba 100644 --- a/src/connection.c +++ b/src/connection.c @@ -710,7 +710,7 @@ wl_connection_demarshal(struct wl_connection *connection,

[krh/wayland/next 4/5] wayland-server: Make sure client object exist before dereferencing.

--- src/wayland-server.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index f076dcb..22e6a4e 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -992,7 +992,9 @@ bind_display(struct wl_client *client, client-

[krh/wayland/next 3/5] connection: Removed crashing code.

--- src/connection.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/connection.c b/src/connection.c index 58b150b..ad060b0 100644 --- a/src/connection.c +++ b/src/connection.c @@ -622,7 +622,6 @@ wl_connection_demarshal(struct wl_connection *connection, unsigned int i, count, ext

[krh/wayland/next 2/5] scanner: Make sure arguments have names.

--- src/scanner.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/scanner.c b/src/scanner.c index d68c952..0a6f233 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -348,6 +348,9 @@ start_element(void *data, const char *element_name, const char **atts) ctx->message =

[krh/wayland/next 1/5] connection: Don't call memcpy with null pointer.

--- src/connection.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/connection.c b/src/connection.c index 8497670..58b150b 100644 --- a/src/connection.c +++ b/src/connection.c @@ -486,12 +486,12 @@ wl_closure_vmarshal(struct wl_object *sender,