Re: Will Wayland also ship with broken keyboard layout switching?

2012-10-01 Thread Daniel Stone
Hi, On 2 October 2012 11:38, wrote: > On 10/02, Фамилия Имя wrote: >> switch between different keyboard layouts (languages) using both alt keys. >> It was > >> https://bugs.freedesktop.org/show_bug.cgi?id=4927 > > This mentions a fix for X would be to switch to xkbcommon. xkbcommon is > what w

Re: Will Wayland also ship with broken keyboard layout switching?

2012-10-01 Thread darxus
On 10/02, Фамилия Имя wrote: > switch between different keyboard layouts (languages) using both alt keys. It > was > https://bugs.freedesktop.org/show_bug.cgi?id=4927 This mentions a fix for X would be to switch to xkbcommon. xkbcommon is what weston uses, so it seems likely to not have this pr

Re: [PATCH libxkbcommon 1/2] makekeys: add all symbols converted to lower-case

2012-10-01 Thread Bill Spitzak
David Herrmann wrote: Hi Bill Could you please avoid top-posting? It's so much easier to read comments if they are _below_ the quoted text. Okay, I see that this is more like a compile-time operation, not run time. In that case I don't see a problem with case independence since it is just m

Re: Comment on global shortcuts security

2012-10-01 Thread Bill Spitzak
Rick Stockton wrote: IIRC, The Qt/KDE design is the opposite: If they "USED" the key within some level of code (class or interface), then they suck it in and nothing comes back to Weston. Not quite. There is an "accepted()" field in events, which are passed by reference to event handlers. Th

Will Wayland also ship with broken keyboard layout switching?

2012-10-01 Thread Фамилия Имя
Hi, sorry if it's not the right place to ask. Afaik Wayland uses a lot of X11 code for keyboard keys mapping/management. In 2008 something broke in the X11 input stack that doesn't allow any longer to switch between different keyboard layouts (languages) using both alt keys. It was very handy btw.

[PATCH] tests: add keyboard test

2012-10-01 Thread U. Artie Eoff
From: "U. Artie Eoff" Signed-off-by: U. Artie Eoff --- tests/Makefile.am | 3 +- tests/keyboard-test.c | 124 ++ tests/test-client.c | 32 - 3 files changed, 157 insertions(+), 2 deletions(-) create mode 100644 tests/keyboard

Re: [PATCH libxkbcommon 1/2] makekeys: add all symbols converted to lower-case

2012-10-01 Thread David Herrmann
Hi Bill Could you please avoid top-posting? It's so much easier to read comments if they are _below_ the quoted text. On Mon, Oct 1, 2012 at 9:11 PM, Bill Spitzak wrote: > I think you are asking for trouble here. > > The biggest problem I see is that you are calling tolower() which changes > dep

Re: Comment on global shortcuts security

2012-10-01 Thread Rick Stockton
On 09/30/2012 09:08 AM, Bill Spitzak wrote: << SNIP >> I hope these comments are useful; if they're just a bunch of obvious "baggage", I apologize. All the normal keystorkes that a client handles are a roundtrip, so I really can't see this being a problem. I certainly agree with Wayland's d

Re: [PATCH libxkbcommon 1/2] makekeys: add all symbols converted to lower-case

2012-10-01 Thread Bill Spitzak
I think you are asking for trouble here. The biggest problem I see is that you are calling tolower() which changes depending on the locale. Though most software fixes this by forcing the locale to C, I'm not sure if that is acceptable for xkb. Please do not rely on anything more complicated th

Re: Gamma correct rendering with Wayland and Weston

2012-10-01 Thread Bill Spitzak
Pekka Paalanen wrote: And you would like to kill all innovative uses like: http://www.youtube.com/watch?v=_FjuPn7MXMs right? And spherical VR displays, too? No, this is not yet the reason to expose transformations to clients. You are only suggesting to make the protocol a huge deal more complex

[PATCH libxkbcommon 2/2] test/keysym: add tests for case-insensitive/lower-case matches

2012-10-01 Thread David Herrmann
This tests whether the exact case-match is always prefered to case-insensitive matches. Signed-off-by: David Herrmann --- test/keysym.c | 8 1 file changed, 8 insertions(+) diff --git a/test/keysym.c b/test/keysym.c index 1bf704b..2c4e1f1 100644 --- a/test/keysym.c +++ b/test/keysym.c

[PATCH libxkbcommon 1/2] makekeys: add all symbols converted to lower-case

2012-10-01 Thread David Herrmann
xkb_keysym_from_name() uses a big lookup table generated by "makekeys" to find keysyms. It does this case-sensitive because we have keys like XKB_KEY_A and XKB_KEY_a. So if a user searches for "a" we must always return the case-sensitive match, which is XKB_KEY_a. However, lets look at XKB_KEY_XF86

[PATCH weston v2] desktop-shell: Implement panel window list.

2012-10-01 Thread Scott Moreau
The compositor sends surface info as necessary to the wl_shell client, using a special interface extension. Surfaces are identified by a specific id value. The value of the id isn't particularly important as long as 1) the value is unique for each surface 2) the client and compositor use the same i

Re: [PATCH v2] Add a new field for compositors to store the gamma encoding of wl_buffers.

2012-10-01 Thread John Kåre Alsaker
busy_count and gamma is only used by compositors. Nothing in the wayland libraries uses these, so they are not defined there. We should probably add a pointer for the compositor to allocate further state too without having to use a map for that. On Mon, Oct 1, 2012 at 9:42 AM, Pekka Paalanen wrot

[PATCH weston] desktop-shell: Implement panel window list.

2012-10-01 Thread Scott Moreau
The compositor sends surface info as necessary to the wl_shell client, using a special interface extension. Surfaces are identified by a specific id value. The value of the id isn't particularly important as long as 1) the value is unique for each surface 2) the client and compositor use the same i

Re: [PATCH weston] toytoolkit: Take into account transform when sending output allocation.

2012-10-01 Thread Scott Moreau
On Mon, Oct 1, 2012 at 1:37 AM, Pekka Paalanen wrote: > On Sat, 29 Sep 2012 02:03:11 -0600 > Scott Moreau wrote: > > > --- > > > > It seems only wscreensaver and tablet-shell use output_get_allocation(). > This > > fixes a problem when screensaver gets the wrong size for transformed > outputs >

Re: [PATCH v2] Add a new field for compositors to store the gamma encoding of wl_buffers.

2012-10-01 Thread Pekka Paalanen
On Sun, 30 Sep 2012 01:39:14 +0200 John Kåre Alsaker wrote: > --- > src/wayland-server.h | 1 + > src/wayland-shm.c| 3 +-- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/wayland-server.h b/src/wayland-server.h > index 45cc61c..9fa754f 100644 > --- a/src/wayland-ser

Re: [PATCH weston] toytoolkit: Take into account transform when sending output allocation.

2012-10-01 Thread Pekka Paalanen
On Sat, 29 Sep 2012 02:03:11 -0600 Scott Moreau wrote: > --- > > It seems only wscreensaver and tablet-shell use output_get_allocation(). This > fixes a problem when screensaver gets the wrong size for transformed outputs > where width and height are swapped. The above message should appear in

Re: Gamma correct rendering with Wayland and Weston

2012-10-01 Thread Pekka Paalanen
On Sun, 30 Sep 2012 16:10:42 +0200 (CEST) Kai-Uwe Behrmann wrote: > In reply to John Kåre Alsaker Fri Sep 28 08:52:17 PDT 2012 > > > - srgb: > > Rendering in linear gamma: > > If the hardware supports sRGB textures: > > EGL: Use sRGB textures and present it as

Re: Gamma correct rendering with Wayland and Weston

2012-10-01 Thread Pekka Paalanen
On Sun, 30 Sep 2012 08:45:55 -0700 Bill Spitzak wrote: > On 09/29/2012 01:28 AM, John Kåre Alsaker wrote: > > >> Wayland also does scaling and rotations but the difference between linear > >> and srgb is much smaller for these. I think the real solution for this is > >> to > >> allow clients to

Re: Comment on global shortcuts security

2012-10-01 Thread Daniel Stone
Hi, On 1 October 2012 02:08, Bill Spitzak wrote: > On 09/30/2012 01:35 AM, Pekka Paalanen wrote: >> You might invent elaborate schemes to overcome the latter cons, [and this did happen] >> but even the roundtrip argument alone is a serious one, and there >> would have to be a serious benefit in