Re: [PATCH weston] toytoolkit: Process deferred tasks on fifo order instead

2012-09-27 Thread Kristian Høgsberg
On Thu, Sep 27, 2012 at 02:46:23PM +0300, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti Yeah, that makes sense. Kristian > --- > clients/window.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/clients/window.c b/clients/window.c > index 93d2282..08828c2 10

RE: [PATCH v2] event-test: more aggressive event testing

2012-09-27 Thread Eoff, Ullysses A
It was pointed out to me that I used C++ style comments... whoops, old habits. Before I resubmit does anyone else see any other coding convention issues that I missed or deviated from? Kristian? Perhaps there's a Wayland coding convention doc somewhere? U. Artie Eoff >-Original Message---

Re: [ANNOUNCE] wlterm: Native Wayland Terminal Emulator

2012-09-27 Thread Bill Spitzak
This sounds like a really good idea! What are you doing about UTF-8? Any modern terminal better handle it and at least display glyphs for every valid UTF-8 encoded character. Also important is that it must not barf and must display a glyph for every byte if the sequence coming in is not valid

[PATCH weston 4/8] shell: Update bindings to conform to pointer axis protocol

2012-09-27 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- src/shell.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/shell.c b/src/shell.c index e2715d6..6193bd2 100644 --- a/src/shell.c +++ b/src/shell.c @@ -2361,7 +2361,7 @@ static void surface_opacity_binding(struct wl_seat *seat, uin

Re: [PATCH weston 4/8] shell: Update bindings to conform to pointer axis protocol

2012-09-27 Thread Jonas Ådahl
On Thu, Sep 27, 2012 at 6:50 PM, Tiago Vignatti wrote: > On 09/27/2012 07:40 PM, Jonas Ådahl wrote: >> >> Signed-off-by: Jonas Ådahl >> --- >> src/shell.c | 10 ++ >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/src/shell.c b/src/shell.c >> index 06d8684..ceea60

Re: [PATCH weston 4/8] shell: Update bindings to conform to pointer axis protocol

2012-09-27 Thread Tiago Vignatti
On 09/27/2012 07:40 PM, Jonas Ådahl wrote: Signed-off-by: Jonas Ådahl --- src/shell.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/shell.c b/src/shell.c index 06d8684..ceea607 100644 --- a/src/shell.c +++ b/src/shell.c @@ -1860,9 +1860,10 @@ shell_map_p

[PATCH weston 8/8] clients: image: Add support for panning and zooming

2012-09-27 Thread Jonas Ådahl
Support for zooming by using ctrl + the vertical axis (scrolling upwards zooms in) and panning by both the horizontal and vertical axis as well as click and drag was added to demonstrate how axis should work. Signed-off-by: Jonas Ådahl --- clients/image.c | 232 +

[PATCH weston 7/8] window: Update modifier state directly after receiving a modifier event

2012-09-27 Thread Jonas Ådahl
If the keyboard modifier event was received after the key event the modifier state would end up incorrect. Signed-off-by: Jonas Ådahl --- clients/window.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/clients/window.c b/clients/window.c index 4d3

[PATCH weston 6/8] window: Fix issue causing pointer to have the wrong sprite

2012-09-27 Thread Jonas Ådahl
There is no event notifying when a move is finished and if a window requests to be moved but no move is performed and no enter/leave events are received, the pointer gets stuck in a grab-state. To avoid this, change the sprite to LEFT_PTR if an button-released event is received. Signed-off-by: Jon

[PATCH weston 5/8] evdev-touchpad: Implement two finger scroll

2012-09-27 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- src/evdev-touchpad.c | 41 + 1 file changed, 29 insertions(+), 12 deletions(-) diff --git a/src/evdev-touchpad.c b/src/evdev-touchpad.c index 3ba8f80..7063a0d 100644 --- a/src/evdev-touchpad.c +++ b/src/evdev-touchpad.c @@

[PATCH weston 4/8] shell: Update bindings to conform to pointer axis protocol

2012-09-27 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- src/shell.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/shell.c b/src/shell.c index 06d8684..ceea607 100644 --- a/src/shell.c +++ b/src/shell.c @@ -1860,9 +1860,10 @@ shell_map_popup(struct shell_surface *shsurf) }

[PATCH weston 3/8] compositor-x11: Update axis notifications to follow protocol

2012-09-27 Thread Jonas Ådahl
Axis events are in the same coordinate space as motion events, thus measured in pixels. To emulate axis events for discrete events move the axis by a number of pixels every step. Signed-off-by: Jonas Ådahl --- src/compositor-x11.c | 28 1 file changed, 16 insertion

[PATCH weston 2/8] evdev-touchpad: Add a finite-state machine

2012-09-27 Thread Jonas Ådahl
The finite-state machine is so far used to implement support for tapping and dragging. Signed-off-by: Jonas Ådahl --- src/evdev-touchpad.c | 188 ++ 1 file changed, 188 insertions(+) diff --git a/src/evdev-touchpad.c b/src/evdev-touchpad.c index

[PATCH weston 1/8] evdev-touchpad: Cleanup and refactoring

2012-09-27 Thread Jonas Ådahl
Signed-off-by: Jonas Ådahl --- src/evdev-touchpad.c | 227 ++ 1 file changed, 117 insertions(+), 110 deletions(-) diff --git a/src/evdev-touchpad.c b/src/evdev-touchpad.c index e453f9d..7a724c8 100644 --- a/src/evdev-touchpad.c +++ b/src/evdev-tou

[PATCH weston 0/8] Touchpad improvements

2012-09-27 Thread Jonas Ådahl
Hi, This patch series improves upon the evdev touchpad code and adds some features to the image viewing demo client demonstrating these improvements. There are also some changes to how the compositor and shell emits and handles axis events. A patch to wayland (protocol: Clarify pointer axis event

[PATCH wayland] protocol: Clarify pointer axis event

2012-09-27 Thread Jonas Ådahl
Pointer axis events are in the same coordinate space as motion events. Signed-off-by: Jonas Ådahl --- protocol/wayland.xml |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 5e56cb8..e31cad4 100644 --- a/protocol/wayland.x

[PATCH weston 3/3] xwm: Plug kill signal for killing X apps

2012-09-27 Thread Tiago Vignatti
Xeyes is the counter-example that fails on that heuristic and won't be caught on kill binding. This and the last two patches should fix: https://bugs.freedesktop.org/show_bug.cgi?id=53679 Signed-off-by: Tiago Vignatti --- src/xwayland/window-manager.c | 31 +++

[PATCH weston 2/3] compositor: Add kill signal

2012-09-27 Thread Tiago Vignatti
For now it's being emitted only on the desktop shell kill binding. Signed-off-by: Tiago Vignatti --- src/compositor.c |1 + src/compositor.h |1 + src/shell.c |4 3 files changed, 6 insertions(+) diff --git a/src/compositor.c b/src/compositor.c index 417c508..95ee258 10064

[PATCH weston 1/3] shell: Skip malicious clients on kill binding

2012-09-27 Thread Tiago Vignatti
Also remove superfluous variables. Signed-off-by: Tiago Vignatti --- src/shell.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/shell.c b/src/shell.c index e043004..789fc36 100644 --- a/src/shell.c +++ b/src/shell.c @@ -3506,15 +3506,17 @@ force_kill_binding(s

Re: [PATCH weston] compositor: Load shell plugin after option modules

2012-09-27 Thread Kristian Høgsberg
On Thu, Sep 27, 2012 at 9:24 AM, Tiago Vignatti wrote: > On 09/26/2012 07:26 PM, Kristian Høgsberg wrote: >> >> >>> Maybe we should special-case the forking clients and get the return >>> value from the fork() call, i.e the pid now? >> >> >> Yeah, I think that's the way to go... I'm just wondering

Re: [PATCH weston] compositor: Load shell plugin after option modules

2012-09-27 Thread Tiago Vignatti
On 09/26/2012 07:26 PM, Kristian Høgsberg wrote: Maybe we should special-case the forking clients and get the return value from the fork() call, i.e the pid now? Yeah, I think that's the way to go... I'm just wondering if we should add a wl_client_set_credentials() or just work around it in w

[PATCH weston] toytoolkit: Process deferred tasks on fifo order instead

2012-09-27 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti --- clients/window.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/window.c b/clients/window.c index 93d2282..08828c2 100644 --- a/clients/window.c +++ b/clients/window.c @@ -3980,7 +3980,7 @@ display_run(struct display *display)

[ANNOUNCE] wlterm: Native Wayland Terminal Emulator

2012-09-27 Thread David Herrmann
Hi Last few days I have been working on "wlterm", a native terminal emulator for wayland. You can find it here: http://github.com/dvdhrm/kmscon Or check it out from: git://github.com/dvdhrm/kmscon.git It shares the repository with "kmscon" currently. However, you can build it independently wi