Re: Comment on global shortcuts security

2012-09-25 Thread Daniel
El dt 25 de 09 de 2012 a les 11:15 -0400, en/na Kristian Høgsberg va escriure: > On Mon, Sep 24, 2012 at 04:53:20PM -0700, Bill Spitzak wrote: > > Keystrokes should be sent to the application first. Only if the > > application refuses them should they be considered global shortcuts. > > No. Could

Re: Comment on global shortcuts security

2012-09-25 Thread Pekka Paalanen
On Tue, 25 Sep 2012 18:07:51 +0200 Piotr Rak wrote: > Hi, > > 2012/9/25 Pekka Paalanen : > > Hi Piotr, > > > > it sounds like you make a fundamental assumption on something, that > > makes global shortcuts insecure, and so you set out to solve these > > problems. > > > > What is it that you assu

[PATCH] tests: test surface to/from global functions

2012-09-25 Thread U. Artie Eoff
From: "U. Artie Eoff" Signed-off-by: U. Artie Eoff --- tests/Makefile.am | 5 +++- tests/surface-global-test.c | 65 + 2 files changed, 69 insertions(+), 1 deletion(-) create mode 100644 tests/surface-global-test.c diff --git a/tests/Make

[PATCH v2] event-test: more aggressive event testing

2012-09-25 Thread U. Artie Eoff
From: "U. Artie Eoff" Test surface pointer enter/leave/motion and surface leave/enter events more aggressively. Signed-off-by: U. Artie Eoff --- tests/event-test.c | 269 tests/test-client.c | 60 ++-- tests/test-runner.c | 8 +-

RE: [PATCH] event-test: more aggressive event testing

2012-09-25 Thread Eoff, Ullysses A
Whoops, found some compiler warnings with this patch... resending w/fix. U. Artie >-Original Message- >From: Eoff, Ullysses A >Sent: Monday, September 24, 2012 1:16 PM >To: wayland-devel@lists.freedesktop.org >Cc: Eoff, Ullysses A >Subject: [PATCH] event-test: more aggressive event test

Re: Comment on global shortcuts security

2012-09-25 Thread Piotr Rak
2012/9/25 Timothée Ravier : > Le 25/09/2012 01:53, Bill Spitzak a écrit : >> Keystrokes should be sent to the application first. Only if the >> application refuses them should they be considered global shortcuts. > > > According to me, the main goal is to _never_ have global shortcuts. > That's why

Re: Comment on global shortcuts security

2012-09-25 Thread Piotr Rak
Hi, 2012/9/25 Pekka Paalanen : > On Tue, 25 Sep 2012 01:46:37 +0200 > Piotr Rak wrote: > >> Hi, >> >> Although I am not security expert, I'd like to share my input into >> this topic, so putting on my black hat... >> >> It is probably not great discovery, but I believe that minimal >> requirement

Re: [PATCH] man: add man-page infrastructure

2012-09-25 Thread Kristian Høgsberg
On Mon, Sep 24, 2012 at 01:18:38PM +0200, David Herrmann wrote: > This adds a man-page infrastructure based on Docbook XML files. This > allows us to integrate the man-pages into the publican books later. An > example page for wl_display_connect() (with an alias > wl_display_connect_to_fd()) is als

Re: [PATCH weston] shell: Start the desktop-shell client in the idle handler

2012-09-25 Thread Kristian Høgsberg
On Tue, Sep 25, 2012 at 05:57:01PM +0300, Tiago Vignatti wrote: > It fix https://bugs.freedesktop.org/show_bug.cgi?id=55259 > > Signed-off-by: Tiago Vignatti Thanks, that looks good, committed. Kristian > --- > src/shell.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletion

Re: [PATCH weston] compositor: Load shell plugin after option modules

2012-09-25 Thread Kristian Høgsberg
On Tue, Sep 25, 2012 at 05:54:40PM +0300, Tiago Vignatti wrote: > On 09/25/2012 05:13 PM, Kristian Høgsberg wrote: > >On Tue, Sep 25, 2012 at 01:52:43PM +0300, Tiago Vignatti wrote: > >>It's a quick fix in opposition of the lack of the two-stage module init. > >>Effectively it fix: > >> > >> ht

Re: Comment on global shortcuts security

2012-09-25 Thread Kristian Høgsberg
On Mon, Sep 24, 2012 at 04:53:20PM -0700, Bill Spitzak wrote: > Keystrokes should be sent to the application first. Only if the > application refuses them should they be considered global shortcuts. No. Kristian > I think this will fix most of the security problems you raise. It > also means th

Re: [PATCH] test-client: initialize input instance.

2012-09-25 Thread Kristian Høgsberg
On Mon, Sep 24, 2012 at 08:07:38PM +, Eoff, Ullysses A wrote: > bump. Thanks for the reminder, committed. Kristian > >-Original Message- > >From: Eoff, Ullysses A > >Sent: Tuesday, September 04, 2012 2:38 PM > >To: wayland-devel@lists.freedesktop.org > >Cc: Eoff, Ullysses A > >Subjec

Re: [PATCH] text: Rename de/activate to enter/leave

2012-09-25 Thread Kristian Høgsberg
On Mon, Sep 24, 2012 at 03:00:07PM +0200, Michael Hasselmann wrote: > On Mon, 2012-09-24 at 14:51 +0200, Jan Arne Petersen wrote: > > + if (surface != window_get_wl_surface(entry->window)) > > + return; > > + > > not what the git message says ("text") -- this is a functional change We

Re: [PATCH v2] shell: Fix crash when an input panel is hiding

2012-09-25 Thread Kristian Høgsberg
On Mon, Sep 24, 2012 at 02:50:39PM +0200, Jan Arne Petersen wrote: > From: Jan Arne Petersen > > Do not unset the output of the input panel surfaces when hiding. > --- > src/shell.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/shell.c b/src/shell.c > index

Re: [PATCH] text: Rename de/activate to enter/leave

2012-09-25 Thread Kristian Høgsberg
On Mon, Sep 24, 2012 at 02:51:14PM +0200, Jan Arne Petersen wrote: > From: Jan Arne Petersen > > Also add a surface argument to the enter event. Looks good, thanks. Kristian > --- > clients/editor.c | 16 ++-- > protocol/text.xml | 9 + > src/text-backend.c | 4 ++-- >

[PATCH weston] shell: Start the desktop-shell client in the idle handler

2012-09-25 Thread Tiago Vignatti
It fix https://bugs.freedesktop.org/show_bug.cgi?id=55259 Signed-off-by: Tiago Vignatti --- src/shell.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/shell.c b/src/shell.c index 2afa1b3..67d1060 100644 --- a/src/shell.c +++ b/src/shell.c @@ -3028,7 +3

Re: [PATCH] shell: Fix crash when an input panel is hiding

2012-09-25 Thread Kristian Høgsberg
On Wed, Sep 19, 2012 at 02:31:57PM +0200, Jan Arne Petersen wrote: > From: Jan Arne Petersen > > Do not call weston_slide_run when the surface's output is NULL. > --- > src/shell.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/shell.c b/src/shell.c > index 2afa1

Re: [PATCH weston] compositor: Load shell plugin after option modules

2012-09-25 Thread Tiago Vignatti
On 09/25/2012 05:13 PM, Kristian Høgsberg wrote: On Tue, Sep 25, 2012 at 01:52:43PM +0300, Tiago Vignatti wrote: It's a quick fix in opposition of the lack of the two-stage module init. Effectively it fix: https://bugs.freedesktop.org/show_bug.cgi?id=55259 No, the command line modules ar

Re: [PATCH] clients: wlterm: A TSM based terminal emulator

2012-09-25 Thread Kristian Høgsberg
On Wed, Sep 19, 2012 at 01:47:25PM +0200, David Herrmann wrote: > TSM (Terminal-emulator State Machine) is a library developed together with > "kmscon" which implements a terminal-emulation layer. It has no external > depedencies and thus does not do any rendering. > It was solely developed to allo

Re: [PATCH 1/4] editor, keyboard: Add support for arrow keys

2012-09-25 Thread Kristian Høgsberg
On Mon, Sep 17, 2012 at 03:28:07PM +0200, Jan Arne Petersen wrote: > From: Jan Arne Petersen > > Add support for arrow keys on the virtual keyboard and make it possible > to move around the cursor in the editor example. All four patches applied, thanks. Kristian > --- > clients/editor.c | 1

Re: [PATCH weston 1/4] Fix PDF viewer not to produce garbage windows for nonexistent files

2012-09-25 Thread Kristian Høgsberg
On Mon, Sep 17, 2012 at 10:15:54PM +0300, Pekka Vuorela wrote: > Was calling window_flush() on redraw handler which already happens on > window redrawing. All four patches look good, thanks for fixing those. Kristian > --- > clients/view.c |1 - > 1 file changed, 1 deletion(-) > > diff --g

Re: [PATCH wayland] protocol: Fix typo

2012-09-25 Thread Kristian Høgsberg
On Tue, Sep 25, 2012 at 12:19:57PM +0300, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti > --- > protocol/wayland.xml |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/protocol/wayland.xml b/protocol/wayland.xml > index ff077a3..6a0e0e1 100644 > --- a/protocol/wa

Re: [PATCH weston] compositor: Load shell plugin after option modules

2012-09-25 Thread Kristian Høgsberg
On Tue, Sep 25, 2012 at 01:52:43PM +0300, Tiago Vignatti wrote: > It's a quick fix in opposition of the lack of the two-stage module init. > Effectively it fix: > > https://bugs.freedesktop.org/show_bug.cgi?id=55259 No, the command line modules are supposed to load after the config file modul

Re: Wayland and Weston 0.95.0 for Fedora 18 (just FYI & TWIMC)

2012-09-25 Thread Kristian Høgsberg
On Sun, Sep 23, 2012 at 12:37 PM, Thorsten Leemhuis wrote: > Hi! > > Just FYI and TWIMC (Darxus on IRC asked me to send this mail): Wayland > and Weston 0.95.0 are now in the "updates-tesing" repo for Fedora 18; > hence if you install the Fedora alpha that was released last week you > can just run

[PATCH weston] compositor: Load shell plugin after option modules

2012-09-25 Thread Tiago Vignatti
It's a quick fix in opposition of the lack of the two-stage module init. Effectively it fix: https://bugs.freedesktop.org/show_bug.cgi?id=55259 Signed-off-by: Tiago Vignatti --- src/compositor.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compositor.c b/sr

Re: Comment on global shortcuts security

2012-09-25 Thread Timothée Ravier
Le 25/09/2012 01:53, Bill Spitzak a écrit : > Keystrokes should be sent to the application first. Only if the > application refuses them should they be considered global shortcuts. According to me, the main goal is to _never_ have global shortcuts. That's why each applications should register the

[PATCH wayland] protocol: Fix typo

2012-09-25 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti --- protocol/wayland.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index ff077a3..6a0e0e1 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -45,7 +45,7 @@ - T

Re: Comment on global shortcuts security

2012-09-25 Thread Pekka Paalanen
On Tue, 25 Sep 2012 01:46:37 +0200 Piotr Rak wrote: > Hi, > > Although I am not security expert, I'd like to share my input into > this topic, so putting on my black hat... > > It is probably not great discovery, but I believe that minimal > requirement for given combination of keys, to be allo