Re: [PATCH] wayland-server: return new ID in wl_client_add_resource()

2012-09-10 Thread Kristian Høgsberg
On Mon, Sep 10, 2012 at 11:23:39AM +0200, David Herrmann wrote: > Sorry, misspelled the ML address. Forwarding it to wayland-devel: > > -- Forwarded message -- > > wl_client_add_resource() used to return no error even though the new > resource wasn't added to the client. This curr

Re: [PATCH] event-loop: add wl_event_loop_has_idle() helper

2012-09-10 Thread Kristian Høgsberg
On Sun, Sep 09, 2012 at 04:02:45PM +0200, David Herrmann wrote: > As event-loop uses epoll() as base object we can stick one event-loop into > another by retrieving the epoll-fd and watching for events on it. However, > the idle objects aren't based on file-descriptors so if one event-callback > ad

Re: [PATCH] event-loop: remove dead code

2012-09-10 Thread Kristian Høgsberg
On Sat, Sep 08, 2012 at 05:47:15PM +0200, David Herrmann wrote: > There is really no need to increment "n" if we never read the value. The > do-while() loop overwrites the value before it is read the first time. > > Signed-off-by: David Herrmann > --- > I am not sure what the intention is here. E

Re: [PATCH weston 1/2] compositor: Adds functions for backends to call around weston_surface_draw.

2012-09-10 Thread Kristian Høgsberg
On Sat, Sep 08, 2012 at 12:42:31AM +0200, Zoxc wrote: I've just committed the renderer abstraction branch that moves all gles2 renderering to its own file and consolidates much of the repaint logic. It should make what you're doing here a lot easier. Kristian > --- > src/compositor-android.c |

Re: [PATCH v2 1/2] cursor: Add a default cursor theme

2012-09-10 Thread Kristian Høgsberg
On Thu, Sep 06, 2012 at 06:54:01PM +0200, Philipp Brüschweiler wrote: > This theme is loaded when the specified cursor theme can not be found. > > These cursors are extracted from the xorg sources and transformed into > raw ARGB data by a small helper program (commited separately). Yup, this and

Re: [PATCH 1/3] simple-egl: Set the opaque region if windowed and -o is passed

2012-09-10 Thread Scott Moreau
On Mon, Sep 10, 2012 at 5:02 AM, Ander Conselvan de Oliveira < conselv...@gmail.com> wrote: > Hi Scott, > > Thanks for reviewing! > > > On 09/07/2012 11:23 PM, Scott Moreau wrote: > >> >> >> On Fri, Sep 7, 2012 at 7:32 AM, Ander Conselvan de Oliveira >> mailto:conselv...@gmail.com>> wrote: >> >>

[PATCH v2] simple-egl: Set the opaque region if windowed and -o is passed

2012-09-10 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Since commit 6a615d262141de7cf094788203d9c044dfb9f08d [1], the opaque region would be set only when running fullscreen. Having it set properly for the windowed case is helpful to test the overlay path in compositor-drm. What this patch does is: - reverts the a

Re: Weston framerate (Re: bare bones opengl weston client sample)

2012-09-10 Thread Pekka Paalanen
On Mon, 10 Sep 2012 07:56:22 -0400 jegde jedge wrote: > Is there a place that describes any threading model there may be in iterate > or flush that could cause a block? Libwayland objects are not thread-safe. wl_display_iterate() can block, if you call it with READABLE and there are no events a

Re: [PATCH 1/3] simple-egl: Set the opaque region if windowed and -o is passed

2012-09-10 Thread Ander Conselvan de Oliveira
Hi Scott, Thanks for reviewing! On 09/07/2012 11:23 PM, Scott Moreau wrote: On Fri, Sep 7, 2012 at 7:32 AM, Ander Conselvan de Oliveira mailto:conselv...@gmail.com>> wrote: Since commit d523a87d2d8c0099d8ac323375b3d083aafccf9a [1], I'm not sure where you got this sha from but it's wron

Re: Weston framerate (Re: bare bones opengl weston client sample)

2012-09-10 Thread jegde jedge
I will post code when I get to the hotel tonight. Basically, I simply ifdef'd in redraw() in simple-egl and branched into my draw routine. I will post both wl_client and glut front ends. Thank you for your help. Is there a place that describes any threading model there may be in iterate or flush th

[PATCH] wayland-server: return new ID in wl_client_add_resource()

2012-09-10 Thread David Herrmann
Sorry, misspelled the ML address. Forwarding it to wayland-devel: -- Forwarded message -- wl_client_add_resource() used to return no error even though the new resource wasn't added to the client. This currently makes it very easy to DOS weston by simply posting thousands of "creat

Re: [PATCH v2 16/17] text: Add support for control keys to the protocol

2012-09-10 Thread Michael Hasselmann
On Sun, 2012-09-09 at 23:08 +0200, Jan Arne Petersen wrote: > From: Jan Arne Petersen > > Add key event to the text_model interface and a key request to the > input_method_context interface. Implement it in the example editor > client and the example keyboard. Could mention why you introduced it