Re: Skew bug with egl

2012-08-14 Thread Scott Moreau
Maybe a screenshot would help ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

In-client echo of input methods?

2012-08-14 Thread Bill Spitzak
Does the proposed input methods support clients being able to show intermediate results? This is certainly useful to make "dead keys" less "dead", and I am under the impression that it is very useful for some Asian entry systems. X11 tried to do this with an input-method-controlled overlay, bu

Re: [PATCH weston 1/2] compositor: a couple debug logs

2012-08-14 Thread Kristian Høgsberg
On Mon, Aug 13, 2012 at 05:39:17PM -0500, Rob Clark wrote: > From: Rob Clark > > Well, they were useful to me in debugging, so probably sooner or later > useful to someone else. Yeah, they look pretty reasonable. Committed. Kristian > Signed-off-by: Rob Clark > --- > src/compositor.c |6

Re: Skew bug with egl

2012-08-14 Thread Scott Moreau
Possibly a nouveau specific bug? It works fine here on radeon gallium and intel dri2. Scott ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: Skew bug with egl

2012-08-14 Thread Bill Spitzak
Oops. I described the shift backwards, it is actually -width mod 16. If the surface is N*16 wide it is correct. If the surface is N*16-1 wide then it is skewed with each scanline 1 pixel to the right of the one above it. The writing code thinks the stride is N*16, while the reading code thinks

Re: widget_set_axis_handler

2012-08-14 Thread Scott Moreau
On Tue, Aug 14, 2012 at 10:09 AM, Bill Spitzak wrote: > In newest wayland/westion I cannot compile eventdemo because of a call to > the non-existent function widget_set_axis_handler. Commenting out the call > makes the compilation work. > > This is with 468262be3e8ed7db4bfbd7fa2bda33**d3ce6aa3f8

[PATCH 3/3] text: Introduce input_method_context interface

2012-08-14 Thread Jan Arne Petersen
From: Jan Arne Petersen Add an input_method_context interface which is the representation of a text_model on input_method side. --- clients/keyboard.c | 38 +++- protocol/text.xml | 15 +++- src/text-backend.c | 100 ++--- 3

[PATCH 2/3] text: Have only one text_model_factory

2012-08-14 Thread Jan Arne Petersen
From: Philipp Brüschweiler Have only one text_model_factory instead of one per seat. This commit also introduces destruction of an input method when the corresponding seat is removed. --- src/compositor.c | 1 + src/compositor.h | 3 +++ src/text-backend.c | 75 +++

[PATCH 1/3] text: Remove surface arg in create_text_model

2012-08-14 Thread Jan Arne Petersen
From: Jan Arne Petersen Remove the wl_surface argument from create_text_model request. The wl_surface is specified as an argument in the activate request instead. --- clients/editor.c | 5 + protocol/text.xml | 1 - src/text-backend.c | 3 +-- 3 files changed, 2 insertions(+), 7 deletions

[PATCH 0/3] Introduce input_method_context interface

2012-08-14 Thread Jan Arne Petersen
From: Jan Arne Petersen Add an input_method_context interface which represents a text_model on input_method side. An input_method can get assigned different text_models during its life-time. The input_method_context makes it possible to interact with a well-defined text_model also when a new text

Re: [PATCH weston] compositor: Schedule repaint after assigning output.

2012-08-14 Thread Scott Moreau
On Tue, Aug 14, 2012 at 8:09 AM, Kristian Høgsberg wrote: > On Tue, Aug 14, 2012 at 03:51:40AM -0600, Scott Moreau wrote: > > This fixes a bug exposed by 982387011ff where tooltips were not drawn > while > > the compositor is idle until the next output repaint. > > --- > > > > Just schedule a repa

Re: [PATCH 2/2 weston] toytoolkit: Don't draw shadows for maximized windows.

2012-08-14 Thread Bill Spitzak
On 08/13/2012 06:22 PM, Scott Moreau wrote: For maximize, it shouldn't draw the shadow border. Every window manager I have seen does not draw the "edges" as well. If you have not noticed this, it may explain why you are not seeing the problem as I am. Snapping will work fine. You do not s

x11-compositor event handling bug

2012-08-14 Thread Bill Spitzak
Weston x11 compositor is working very badly for me, due to some bug that appears to be in xcb. This bug has been true for 3 versions of Ubuntu, and does not depend on what window manager I am using and whether it is compositing or not (there was a previous claim it was a compiz bug). It also do

Re: Skew bug with egl

2012-08-14 Thread Bill Spitzak
Further information: Experimenting with resizing clickdot, it looks like it always skews such that line N is shifted width%16 pixels to the right of line N-1, where 0 is the top of the window. I also see a width%16 line of garbage between the skewed left/right edges of the surface. This impl

Skew bug with egl

2012-08-14 Thread Bill Spitzak
I have updated to new Ubuntu. This seems to have enabled wayland clients to use egl rather than shm. However now every client comes out skewed (sharply enough that the windows are unreadable but you see the colors and can guess what is going on). This previously only happened with simple-egl.

widget_set_axis_handler

2012-08-14 Thread Bill Spitzak
In newest wayland/westion I cannot compile eventdemo because of a call to the non-existent function widget_set_axis_handler. Commenting out the call makes the compilation work. This is with 468262be3e8ed7db4bfbd7fa2bda33d3ce6aa3f8 ___ wayland-devel ma

Re: [PATCH] event-test: fix compilation

2012-08-14 Thread Kristian Høgsberg
On Tue, Aug 14, 2012 at 02:46:38PM +0200, Philipp Brüschweiler wrote: > Also fixes a compiler warning in test-client. The test is still failing, > but that's for another patch. Thanks, applied. Kristian > https://bugs.freedesktop.org/show_bug.cgi?id=53462 > --- > tests/event-test.c | 7 +--

Re: [PATCH] toytoolkit: remove unused actions from titlebar menu

2012-08-14 Thread Kristian Høgsberg
On Tue, Aug 14, 2012 at 12:26:54PM +0200, Philipp Brüschweiler wrote: > They were introduced in b3cca0a41130ff45b70b730cb8f2273dd91531a5 > but never actually implemented. Removing them should at least stop > users from wondering if weston is broken. Looks good. Kristian > https://bugs.freedesktop

Re: [PATCH] socket-test: don't try to be clever, fail if no XDG_RUNTIME_DIR is set

2012-08-14 Thread Kristian Høgsberg
On Tue, Aug 14, 2012 at 11:53:08AM +0200, Philipp Brüschweiler wrote: > Not only setenv(), also putenv() allocates memory on my system > (glibc 2.16.0). Just fail with a clear message if XDG_RUNTIME_DIR is > not set. Yeah, lets just require this. Kristian > https://bugs.freedesktop.org/show_bug.

Re: [PATCH weston] compositor: Schedule repaint after assigning output.

2012-08-14 Thread Kristian Høgsberg
On Tue, Aug 14, 2012 at 03:51:40AM -0600, Scott Moreau wrote: > This fixes a bug exposed by 982387011ff where tooltips were not drawn while > the compositor is idle until the next output repaint. > --- > > Just schedule a repaint instead of preemptively calling > weston_surface_update_transform()

Re: [PATCH 1/4] eventdemo: fix incorrect comments

2012-08-14 Thread Kristian Høgsberg
On Tue, Aug 14, 2012 at 11:02:39AM +0200, Philipp Brüschweiler wrote: That's a nice series, applied. Kristian > --- > clients/eventdemo.c | 8 > 1 Datei geändert, 4 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) > > diff --git a/clients/eventdemo.c b/clients/eventdemo.c > index 22dade3..

[PATCH] event-test: fix compilation

2012-08-14 Thread Philipp Brüschweiler
Also fixes a compiler warning in test-client. The test is still failing, but that's for another patch. https://bugs.freedesktop.org/show_bug.cgi?id=53462 --- tests/event-test.c | 7 +-- tests/test-client.c | 7 --- 2 Dateien geändert, 9 Zeilen hinzugefügt(+), 5 Zeilen entfernt(-) diff -

[PATCH 2/2] DEBUG: Add tool to analyze regions used for output repaint

2012-08-14 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira This makes weston write to stdout the regions used for output repaint such as the primary plane damage, the opaque region, etc and adds a simple wayland client for visualizing them. The regions for each frame are drawn one at a time with different colors, and the

[PATCH 1/2] compositor: Clear only the the damage that was actually repainted

2012-08-14 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Instead of clearing the whole output region after a repaint, clear only the regions that were actually painted. This way, the damage added when a surface moves from the primary plane to another one is kept while this region is obscured by the opaque region. This

[PATCH] toytoolkit: remove unused actions from titlebar menu

2012-08-14 Thread Philipp Brüschweiler
They were introduced in b3cca0a41130ff45b70b730cb8f2273dd91531a5 but never actually implemented. Removing them should at least stop users from wondering if weston is broken. https://bugs.freedesktop.org/show_bug.cgi?id=52455 --- clients/window.c | 8 +++- 1 Datei geändert, 3 Zeilen hinzugefüg

[PATCH] socket-test: don't try to be clever, fail if no XDG_RUNTIME_DIR is set

2012-08-14 Thread Philipp Brüschweiler
Not only setenv(), also putenv() allocates memory on my system (glibc 2.16.0). Just fail with a clear message if XDG_RUNTIME_DIR is not set. https://bugs.freedesktop.org/show_bug.cgi?id=52618 --- tests/socket-test.c | 21 ++--- 1 Datei geändert, 10 Zeilen hinzugefügt(+), 11 Zeilen

[PATCH weston] compositor: Schedule repaint after assigning output.

2012-08-14 Thread Scott Moreau
This fixes a bug exposed by 982387011ff where tooltips were not drawn while the compositor is idle until the next output repaint. --- Just schedule a repaint instead of preemptively calling weston_surface_update_transform(). src/compositor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/s

[PATCH 4/4] eventdemo: add axis logging

2012-08-14 Thread Philipp Brüschweiler
https://bugs.freedesktop.org/show_bug.cgi?id=52453 --- clients/eventdemo.c | 30 ++ 1 Datei geändert, 30 Zeilen hinzugefügt(+) diff --git a/clients/eventdemo.c b/clients/eventdemo.c index 49e4399..569a8c1 100644 --- a/clients/eventdemo.c +++ b/clients/eventdemo.c @@ -7

[PATCH 3/4] toytoolkit: add axis handler

2012-08-14 Thread Philipp Brüschweiler
--- clients/window.c | 19 +++ clients/window.h | 8 2 Dateien geändert, 27 Zeilen hinzugefügt(+) diff --git a/clients/window.c b/clients/window.c index dd65328..c274541 100644 --- a/clients/window.c +++ b/clients/window.c @@ -179,6 +179,7 @@ struct widget { widg

[PATCH 2/4] eventdemo: fix --no-border

2012-08-14 Thread Philipp Brüschweiler
This was broken by commit 29af3ebce676b3cdd516dedc0cbedc47f70ce425 --- clients/eventdemo.c | 18 ++ 1 Datei geändert, 10 Zeilen hinzugefügt(+), 8 Zeilen entfernt(-) diff --git a/clients/eventdemo.c b/clients/eventdemo.c index 5556a75..49e4399 100644 --- a/clients/eventdemo.c +++ b

[PATCH 1/4] eventdemo: fix incorrect comments

2012-08-14 Thread Philipp Brüschweiler
--- clients/eventdemo.c | 8 1 Datei geändert, 4 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/clients/eventdemo.c b/clients/eventdemo.c index 22dade3..5556a75 100644 --- a/clients/eventdemo.c +++ b/clients/eventdemo.c @@ -90,7 +90,7 @@ struct eventdemo { /** * \brief CAL

Re: [Mesa-dev] [PATCH weston 2/2] compositor: add support for OES_EGL_image_external

2012-08-14 Thread Pekka Paalanen
On Mon, 13 Aug 2012 18:59:33 -0500 Rob Clark wrote: > On Mon, Aug 13, 2012 at 5:39 PM, Rob Clark wrote: > > From: Rob Clark > > > > In cases where the GPU can natively handle certain YUV formats, > > eglQueryWaylandBufferWL() can return the value EGL_TEXTURE_EXTERNAL_OES > > and the compositor