Re: [PATCH 2/2 weston] toytoolkit: Don't draw shadows for maximized windows.

2012-08-13 Thread Scott Moreau
On Mon, Aug 13, 2012 at 10:54 AM, Bill Spitzak wrote: > Scott Moreau wrote: > > 1. The "content" region. This is the part of the window that does >> not include the "edges". However it *does* include the titlebar. >> Imagine the "part of the window you see when it is maximized". This

Re: [PATCH weston 2/2] compositor: add support for OES_EGL_image_external

2012-08-13 Thread Rob Clark
On Mon, Aug 13, 2012 at 5:39 PM, Rob Clark wrote: > From: Rob Clark > > In cases where the GPU can natively handle certain YUV formats, > eglQueryWaylandBufferWL() can return the value EGL_TEXTURE_EXTERNAL_OES > and the compositor will treat the buffer as a single egl-image-external. > > See: > h

[PATCH weston 2/2] compositor: add support for OES_EGL_image_external

2012-08-13 Thread Rob Clark
From: Rob Clark In cases where the GPU can natively handle certain YUV formats, eglQueryWaylandBufferWL() can return the value EGL_TEXTURE_EXTERNAL_OES and the compositor will treat the buffer as a single egl-image-external. See: http://www.khronos.org/registry/gles/extensions/OES/OES_EGL_image_

[PATCH weston 1/2] compositor: a couple debug logs

2012-08-13 Thread Rob Clark
From: Rob Clark Well, they were useful to me in debugging, so probably sooner or later useful to someone else. Signed-off-by: Rob Clark --- src/compositor.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index ed887a4..b2a3ae9 1

[PATCH mesa] add EGL_TEXTURE_EXTERNAL_OES to WL_bind_wayland_display

2012-08-13 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- docs/WL_bind_wayland_display.spec |5 + include/EGL/eglmesaext.h |1 + 2 files changed, 6 insertions(+) diff --git a/docs/WL_bind_wayland_display.spec b/docs/WL_bind_wayland_display.spec index 02bd6ea..7b09212 100644 --- a/docs

Re: [PATCH v2 1/3] keyboard: fix to make it work in the presence of multiple seats

2012-08-13 Thread Jan Arne Petersen
On 08/13/2012 02:35 PM, Philipp Brüschweiler wrote: > Multiple seats imply multiple input methods. Each input method is now > held in a keyboard_input_method struct. On a button click, a commit is > sent to each input method. Yes, that looks good. > --- > clients/keyboard.c | 44

Re: [PATCH] shell: don't segfault when pressing super+k when no surface is focused

2012-08-13 Thread Kristian Høgsberg
On Mon, Aug 13, 2012 at 09:27:27PM +0200, Philipp Brüschweiler wrote: Oops, yes, that looks better. Kristian > --- > src/shell.c | 7 ++- > 1 Datei geändert, 6 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) > > diff --git a/src/shell.c b/src/shell.c > index 51480ce..4d6bc4f 100644 > --- a/src/

Re: [PATCH] image: handle multiple images correctly

2012-08-13 Thread Kristian Høgsberg
On Mon, Aug 13, 2012 at 09:16:47PM +0200, Philipp Brüschweiler wrote: > Don't stop the application when only one window is closed. Don't stall > indefinitely if no valid image file is given as input. Looks good, thanks. > --- > clients/image.c | 29 ++--- > 1 Datei geände

[PATCH] shell: don't segfault when pressing super+k when no surface is focused

2012-08-13 Thread Philipp Brüschweiler
--- src/shell.c | 7 ++- 1 Datei geändert, 6 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/src/shell.c b/src/shell.c index 51480ce..4d6bc4f 100644 --- a/src/shell.c +++ b/src/shell.c @@ -3271,12 +3271,17 @@ static void force_kill_binding(struct wl_seat *seat, uint32_t time, uint32_

[PATCH] image: handle multiple images correctly

2012-08-13 Thread Philipp Brüschweiler
Don't stop the application when only one window is closed. Don't stall indefinitely if no valid image file is given as input. --- clients/image.c | 29 ++--- 1 Datei geändert, 26 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) diff --git a/clients/image.c b/clients/image.c ind

Re: [PATCH] shell: Enhance the basic random positioning algorithm

2012-08-13 Thread Bill Spitzak
Kristian Høgsberg wrote: The compositor is not going to discard part of the buffer like that. If the window is fullscreen or maximized or maximized vertically/horizontally, the client has to know that and render a buffer that works for that window state. If I drag a window so that a portion of

Re: [PATCH] dnd: fix segfault on grabbing

2012-08-13 Thread Philipp Brüschweiler
This fixes https://bugs.freedesktop.org/show_bug.cgi?id=50487 Cheers, Philipp On Mon, Aug 13, 2012 at 8:04 PM, Philipp Brüschweiler wrote: > Some cursor themes don't include a "grabbing" icon, causing a segfault. > This patch fixes this by just reverting to the stardard cursor instead. > --- >

[PATCH] dnd: fix segfault on grabbing

2012-08-13 Thread Philipp Brüschweiler
Some cursor themes don't include a "grabbing" icon, causing a segfault. This patch fixes this by just reverting to the stardard cursor instead. --- clients/dnd.c | 7 +++ 1 Datei geändert, 7 Zeilen hinzugefügt(+) diff --git a/clients/dnd.c b/clients/dnd.c index 6f55e95..44c1541 100644 --- a/c

Re: [PATCH] shell: Enhance the basic random positioning algorithm

2012-08-13 Thread Kristian Høgsberg
On Mon, Aug 13, 2012 at 1:20 PM, Bill Spitzak wrote: > > > Kristian Høgsberg wrote: > >> That's a nice improvement indeed. I've committed it since it's >> obviously a step forward, but I think we could use the input region >> extents for placement. There's been talk of a outline region or such,

Re: [PATCH] shell: Enhance the basic random positioning algorithm

2012-08-13 Thread Bill Spitzak
Kristian Høgsberg wrote: That's a nice improvement indeed. I've committed it since it's obviously a step forward, but I think we could use the input region extents for placement. There's been talk of a outline region or such, something to define the "edge" of the window for snapping and plac

Re: [PATCH weston 2/2] shell: Damage on workspace switch if workspace surface list is empty.

2012-08-13 Thread Kristian Høgsberg
On Mon, Aug 13, 2012 at 09:50:16AM -0600, Scott Moreau wrote: > On Mon, Aug 13, 2012 at 9:22 AM, Kristian Høgsberg wrote: > > > On Sat, Aug 11, 2012 at 09:57:34PM -0600, Scott Moreau wrote: > > > Surface damage effectively does nothing if the surface is not on any > > output. > > > Animations need

Re: [PATCH 2/2 weston] toytoolkit: Don't draw shadows for maximized windows.

2012-08-13 Thread Bill Spitzak
Scott Moreau wrote: 1. The "content" region. This is the part of the window that does not include the "edges". However it *does* include the titlebar. Imagine the "part of the window you see when it is maximized". This is different and smaller than the input region No it isn't.

[PATCH weston] shell: Eliminate unneeded function.

2012-08-13 Thread Scott Moreau
Replace all occurrences of workspace_damage_all_surfaces() with weston_compositor_schedule_repaint(). This fixes a bug exposed by 982387011ff where trying to switch workspaces while there are no surfaces on the current workspace fails to start the animation. --- This patch replaces [PATCH weston 2

Re: [PATCH weston 2/2] shell: Damage on workspace switch if workspace surface list is empty.

2012-08-13 Thread Scott Moreau
On Mon, Aug 13, 2012 at 9:22 AM, Kristian Høgsberg wrote: > On Sat, Aug 11, 2012 at 09:57:34PM -0600, Scott Moreau wrote: > > Surface damage effectively does nothing if the surface is not on any > output. > > Animations need a repaint to start and workspace switcher was relying on > > weston_surfa

Re: [PATCH weston 2/2] shell: Damage on workspace switch if workspace surface list is empty.

2012-08-13 Thread Kristian Høgsberg
On Sat, Aug 11, 2012 at 09:57:34PM -0600, Scott Moreau wrote: > Surface damage effectively does nothing if the surface is not on any output. > Animations need a repaint to start and workspace switcher was relying on > weston_surface_damage() to do this. If there are no surfaces on the workspace, >

Re: Cursor themes

2012-08-13 Thread Kristian Høgsberg
On Sat, Aug 11, 2012 at 03:18:58PM +0100, Christopher Michael wrote: > Hi All, > > I have attached a couple of patches for both Wayland and Weston. > > The first patche fixes Wayland to also look in the xorg cursor theme > directories for pointer images. > > The second patch adds the ability in

Re: Documentation grammar

2012-08-13 Thread Kristian Høgsberg
On Sat, Aug 11, 2012 at 03:37:59PM +0100, Christopher Michael wrote: > Hi All, > > A small patch to fix a grammar mistake in the docs. Thanks, applied. Kristian > Cheers, > devilhorns > From 5b8fac0899cc3ca9db953d455594b6cafb8cd2d8 Mon Sep 17 00:00:00 2001 > From: Christopher Michael > Date: S

Re: [PATCH] shell: Avoid modulo by zero error in positioning algorithm

2012-08-13 Thread Kristian Høgsberg
On Mon, Aug 13, 2012 at 03:18:44PM +0100, Rob Bradford wrote: > From: Rob Bradford Oh, yup, committed. Krsitian > As spotted by Philipp Brüschweiler > --- > src/shell.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/shell.c b/src/shell.c > index 9d9

[PATCH] shell: Avoid modulo by zero error in positioning algorithm

2012-08-13 Thread Rob Bradford
From: Rob Bradford As spotted by Philipp Brüschweiler --- src/shell.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/shell.c b/src/shell.c index 9d969ff..4633049 100644 --- a/src/shell.c +++ b/src/shell.c @@ -2636,15 +2636,15 @@ weston_surface_set_initial_p

Re: [PATCH] shell: Enhance the basic random positioning algorithm

2012-08-13 Thread Kristian Høgsberg
On Mon, Aug 13, 2012 at 02:07:52PM +0100, Rob Bradford wrote: > From: Rob Bradford > > Place the window in a random position on the output where the first seat with > a pointer is. When calculating the random position limit the range to the > area that would ensure that the whole surface is visib

[PATCH] shell: Enhance the basic random positioning algorithm

2012-08-13 Thread Rob Bradford
From: Rob Bradford Place the window in a random position on the output where the first seat with a pointer is. When calculating the random position limit the range to the area that would ensure that the whole surface is visible. If the surface is larger than the output then the surface is placed

[PATCH] shell: Enhance the basic random positioning algorithm

2012-08-13 Thread Rob Bradford
From: Rob Bradford Place the window in a random position on the output where the first seat with a pointer is. When calculating the random position limit the range to the area that would ensure that the whole surface is visible. If the surface is larger than the output then the surface is placed

Re: [PATCH] wl-server: add wl_client_get_object_for_interface

2012-08-13 Thread Philipp Brüschweiler
Consider this retracted. Cheers, Philipp On Sat, Aug 11, 2012 at 12:15 PM, Philipp Brüschweiler wrote: > This method makes it possible to get access to an object assigned to a > client that implements a certain interface and has a certain data. > --- > src/wayland-server.c | 34

[PATCH v2 3/3] editor: correctly handle multiple seats

2012-08-13 Thread Philipp Brüschweiler
Text fields are drawn as activated if at least one seat has activated the corresponding text model. --- clients/editor.c | 18 +++--- 1 Datei geändert, 11 Zeilen hinzugefügt(+), 7 Zeilen entfernt(-) diff --git a/clients/editor.c b/clients/editor.c index a5347fe..76bbcb3 100644 --- a/c

[PATCH v2 2/3] shell: make {show,hide}_input_panels idempotent

2012-08-13 Thread Philipp Brüschweiler
This prevents issues that arise when using multiple seats (at least with the current implementation in text-backend.c). --- src/shell.c | 6 ++ 1 Datei geändert, 6 Zeilen hinzugefügt(+) diff --git a/src/shell.c b/src/shell.c index 87e688c..3dd2f6e 100644 --- a/src/shell.c +++ b/src/shell.c @@

[PATCH v2 1/3] keyboard: fix to make it work in the presence of multiple seats

2012-08-13 Thread Philipp Brüschweiler
Multiple seats imply multiple input methods. Each input method is now held in a keyboard_input_method struct. On a button click, a commit is sent to each input method. --- clients/keyboard.c | 44 +++- 1 Datei geändert, 35 Zeilen hinzugefügt(+), 9 Zeilen ent

Re: [PATCH 1/2] text: add assigned_seat event to the input_method interface

2012-08-13 Thread Philipp Brüschweiler
Hi Jan, Thanks for your review. I'll follow up with a new version of some cleanups related to multiple seats. IM Context patches will follow later. Cheers, Philipp On Mon, Aug 13, 2012 at 10:10 AM, Jan Arne Petersen wrote: > Hi Philipp, > > I do not think it is a realistic scenario to have one

Re: [PATCH 1/2] text: add assigned_seat event to the input_method interface

2012-08-13 Thread Jan Arne Petersen
Hi Philipp, I do not think it is a realistic scenario to have one virtual keyboard surface forwarding the input to different entries depending on which seat the touch/mouse-event comes from. We would rather have one virtual keyboard surface per seat (on different outputs). For the demo keyboard it

Re: [RFC PATCH 06/12] tablet-shell: Applications can run on tablet

2012-08-13 Thread Tiago Vignatti
On 08/13/2012 04:53 AM, Juan Zhao wrote: On Fri, 2012-08-10 at 10:30 +0300, Pekka Paalanen wrote: There once were plans to move wl_shell out of the core protocol file, but it didn't happen. I still do not consider wl_shell as part of the core Wayland. It is just a too important extension on the

Re: Cursor themes

2012-08-13 Thread Andreas Ericsson
On 08/11/2012 04:18 PM, Christopher Michael wrote: > Hi All, > > I have attached a couple of patches for both Wayland and Weston. > > The first patche fixes Wayland to also look in the xorg cursor theme > directories for pointer images. > > The second patch adds the ability in Weston for specify