Re: [PATCH weston v2] Properly free drm configured mode variables.

2012-07-31 Thread Kristian Høgsberg
On Tue, Jul 31, 2012 at 10:29:56PM -0600, Scott Moreau wrote: Yup, looks right now, applied. Kristian > --- > > We still have to free output_name and output_mode if the malloc call fails. > > src/compositor-drm.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff

[PATCH weston v2] Properly free drm configured mode variables.

2012-07-31 Thread Scott Moreau
--- We still have to free output_name and output_mode if the malloc call fails. src/compositor-drm.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 2075a99..508c0ec 100644 --- a/src/compositor-drm.c +++ b/src/co

[PATCH] Properly free drm configured mode variables.

2012-07-31 Thread Scott Moreau
--- src/compositor-drm.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 2075a99..508c0ec 100644 --- a/src/compositor-drm.c +++ b/src/compositor-drm.c @@ -1777,6 +1777,14 @@ drm_restore(struct weston_compositor *ec

[PATCH weston] Properly free drm configured mode variables.

2012-07-31 Thread Scott Moreau
--- src/compositor-drm.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 2075a99..e7d444f 100644 --- a/src/compositor-drm.c +++ b/src/compositor-drm.c @@ -1777,6 +1777,14 @@ drm_restore(struct weston_co

Re: [PATCH weston] Add raw modeline support.

2012-07-31 Thread Kristian Høgsberg
On Tue, Jul 31, 2012 at 03:30:41PM -0600, Scott Moreau wrote: > This allows specifying a modeline in the config for the 'mode' key > in the output section, such as one you would get from cvt. > --- > src/compositor-drm.c | 77 > ++-- That looks good

Re: [PATCH] protocol: Remove "repeat" from "key_state"

2012-07-31 Thread Kristian Høgsberg
On Tue, Jul 31, 2012 at 06:59:09PM +0200, Andre Heider wrote: > This is unused and apparently was never implemented. > --- > While this might qualify as api breakage, the occurence of the repeat enum > in public headers might confuse users (read: me). As I understood on irc, > this will never be im

Re: [PATCH weston] configure: link image libs with libshared

2012-07-31 Thread Kristian Høgsberg
On Tue, Jul 31, 2012 at 03:47:48PM +0300, Tiago Vignatti wrote: > This fix xwayland.so that was complaining about jpeg symbols from the > libshared. > > Note that xwayland is not using the jpeg ones, but now that symbols are read > up front we need to link anyway.. or break apart that library. Ri

Re: [PATCH xserver 2/2] xwayland: fix motion coordinates

2012-07-31 Thread Kristian Høgsberg
On Tue, Jul 31, 2012 at 03:46:12PM +0300, Tiago Vignatti wrote: > clients were getting one pixel shifted on each axis. Why is this off-by-one? Kristian > Signed-off-by: Tiago Vignatti > --- > hw/xfree86/xwayland/xwayland-input.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [PATCH weston 8/8] simple-touch: use proper damage in touch_paint()

2012-07-31 Thread Kristian Høgsberg
On Tue, Jul 31, 2012 at 01:21:13PM +0300, Pekka Paalanen wrote: > Should reduce update overhead. Nice. Kristian > Signed-off-by: Pekka Paalanen > --- > clients/simple-touch.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/clients/simple-touch.c b/clients/simple

RE: mode issue about no EDID and first mode when weston start

2012-07-31 Thread Wang, Quanxian
Got it. Thanks Quanxian Wang > -Original Message- > From: Kristian Høgsberg [mailto:hoegsb...@gmail.com] > Sent: Wednesday, August 01, 2012 7:52 AM > To: Wang, Quanxian > Cc: wayland-devel@lists.freedesktop.org > Subject: Re: mode issue about no EDID and first mode when weston start > >

Re: mode issue about no EDID and first mode when weston start

2012-07-31 Thread Kristian Høgsberg
On Tue, Jul 31, 2012 at 01:46:17AM +, Wang, Quanxian wrote: > Ok, if we don't use builtin mode in weston. That is fine. In this > case, I supposed to provide some useful error output to user instead > of core dump weston. Yep, we should handle that better now. > Another case is if we don't g

Re: wayland-devel Digest, Vol 22, Issue 88

2012-07-31 Thread nerdopolis
On Tuesday, July 31, 2012 09:59:34 AM wayland-devel-requ...@lists.freedesktop.org wrote: > 1343738868-27400-1-git-send-email-tiago.vigna...@intel.com Hi. I was the one that was having the issues with libjpeg, and this patch worked for me. Thanks ___ wa

[PATCH weston] Add raw modeline support.

2012-07-31 Thread Scott Moreau
This allows specifying a modeline in the config for the 'mode' key in the output section, such as one you would get from cvt. --- src/compositor-drm.c | 77 ++-- weston.ini | 4 +-- 2 files changed, 77 insertions(+), 4 deletions(-) diff -

Re: wayland-devel Digest, Vol 22, Issue 88

2012-07-31 Thread nerdopolis
On Tuesday, July 31, 2012 09:59:34 AM wayland-devel-requ...@lists.freedesktop.org wrote: > Send wayland-devel mailing list submissions to > wayland-devel@lists.freedesktop.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://lists.freedesktop.org/mailman/listinfo

Re: [PATCH weston] configure: link image libs with libshared

2012-07-31 Thread Andre Heider
On Tue, Jul 31, 2012 at 2:47 PM, Tiago Vignatti wrote: > This fix xwayland.so that was complaining about jpeg symbols from the > libshared. > > Note that xwayland is not using the jpeg ones, but now that symbols are read > up front we need to link anyway.. or break apart that library. What about

[PATCH] protocol: Remove "repeat" from "key_state"

2012-07-31 Thread Andre Heider
This is unused and apparently was never implemented. --- While this might qualify as api breakage, the occurence of the repeat enum in public headers might confuse users (read: me). As I understood on irc, this will never be implemented, so it can be argued that its even nice to point users at non-

Re: [PATCH weston 5/8] simple-touch: respond to ping protocol

2012-07-31 Thread Andre Heider
On Tue, Jul 31, 2012 at 3:00 PM, Pekka Paalanen wrote: > Which (non-existing) code are you referring to? > > The unresponsive busy cursor thing is triggered in the desktop-shell > plugin, and the actual busy cursor is set in the desktop-shell client. > It does not require any setup from the client

Re: [PATCH weston 5/8] simple-touch: respond to ping protocol

2012-07-31 Thread Pekka Paalanen
On Tue, 31 Jul 2012 14:44:46 +0200 Andre Heider wrote: > On Tue, Jul 31, 2012 at 2:32 PM, Pekka Paalanen wrote: > > Hi, > > > > it would be hard to spot in the log. Weston already changes the pointer > > to a busy cursor, when over an unresponsive surface. > > Did that not work for you, or did y

[PATCH weston] configure: link image libs with libshared

2012-07-31 Thread Tiago Vignatti
This fix xwayland.so that was complaining about jpeg symbols from the libshared. Note that xwayland is not using the jpeg ones, but now that symbols are read up front we need to link anyway.. or break apart that library. Signed-off-by: Tiago Vignatti --- configure.ac | 12 ++-- 1 file

[PATCH xserver 2/2] xwayland: fix motion coordinates

2012-07-31 Thread Tiago Vignatti
clients were getting one pixel shifted on each axis. Signed-off-by: Tiago Vignatti --- hw/xfree86/xwayland/xwayland-input.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/xwayland/xwayland-input.c b/hw/xfree86/xwayland/xwayland-input.c index d9f352f..e31fb

[PATCH xserver 1/2] xwayland: remove non-existent private headers

2012-07-31 Thread Tiago Vignatti
(BTW, we gotta use xwl_screen_close somewhere) Signed-off-by: Tiago Vignatti --- hw/xfree86/xwayland/xwayland-private.h |6 -- 1 file changed, 6 deletions(-) diff --git a/hw/xfree86/xwayland/xwayland-private.h b/hw/xfree86/xwayland/xwayland-private.h index f697b60..6322060 100644 --- a

Re: [PATCH weston 5/8] simple-touch: respond to ping protocol

2012-07-31 Thread Andre Heider
On Tue, Jul 31, 2012 at 2:32 PM, Pekka Paalanen wrote: > Hi, > > it would be hard to spot in the log. Weston already changes the pointer > to a busy cursor, when over an unresponsive surface. > Did that not work for you, or did you just miss the connection? There wasn't yet any code to handle poi

Re: [PATCH weston 5/8] simple-touch: respond to ping protocol

2012-07-31 Thread Pekka Paalanen
On Tue, 31 Jul 2012 14:07:01 +0200 Andre Heider wrote: > On Tue, Jul 31, 2012 at 12:21 PM, Pekka Paalanen wrote: > > Without this, it won't get any input anymore. > > I noticed this too while fixing up SDL for 0.95. It wasn't obvious why > input events were not delivered anymore. > Maybe weston

Re: [PATCH weston 5/8] simple-touch: respond to ping protocol

2012-07-31 Thread Andre Heider
On Tue, Jul 31, 2012 at 12:21 PM, Pekka Paalanen wrote: > Without this, it won't get any input anymore. I noticed this too while fixing up SDL for 0.95. It wasn't obvious why input events were not delivered anymore. Maybe weston should log something about non-responsive client? __

[PATCH weston 8/8] simple-touch: use proper damage in touch_paint()

2012-07-31 Thread Pekka Paalanen
Should reduce update overhead. Signed-off-by: Pekka Paalanen --- clients/simple-touch.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/clients/simple-touch.c b/clients/simple-touch.c index f8afbb0..6087fe4 100644 --- a/clients/simple-touch.c +++ b/clients/simple-touch.

[PATCH weston 7/8] simple-touch: fix off-by-one in position checks

2012-07-31 Thread Pekka Paalanen
Fix the off by one error in checking whether we can draw the marker without exceeding buffer dimensions. Fixes a segfault. Signed-off-by: Pekka Paalanen --- clients/simple-touch.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/clients/simple-touch.c b/clients/simple

[PATCH weston 6/8] simple-touch: more colors and thicker marks

2012-07-31 Thread Pekka Paalanen
Signed-off-by: Pekka Paalanen --- clients/simple-touch.c | 18 +++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git a/clients/simple-touch.c b/clients/simple-touch.c index b438ffa..3a1d940 100644 --- a/clients/simple-touch.c +++ b/clients/simple-touch.c @@ -109,6 +10

[PATCH weston 4/8] window: warn on cursor load failure

2012-07-31 Thread Pekka Paalanen
--- clients/window.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/clients/window.c b/clients/window.c index a2f339f..71fd6cc 100644 --- a/clients/window.c +++ b/clients/window.c @@ -652,10 +652,14 @@ create_cursors(struct display *display) display->cursors

[PATCH weston 5/8] simple-touch: respond to ping protocol

2012-07-31 Thread Pekka Paalanen
Without this, it won't get any input anymore. Signed-off-by: Pekka Paalanen --- clients/simple-touch.c | 31 ++- 1 files changed, 30 insertions(+), 1 deletions(-) diff --git a/clients/simple-touch.c b/clients/simple-touch.c index 517a956..b438ffa 100644 --- a/clien

[PATCH weston 3/8] compositor: rework touch focus

2012-07-31 Thread Pekka Paalanen
In the wl_seat conversion, struct wl_touch got fields for the focused surface and the client resource for the input device being focused. However, the conversion was incomplete: the old fields weston_seat::touch_focus* we still used by the event dispatching code, but the new code never set them. Th

[PATCH weston 2/8] evdev: query position ranges for MT, too

2012-07-31 Thread Pekka Paalanen
For a true multi-touch input device, the code ended up using uninitialised fields of evdev_input_device::abs. Fix it by querying the corresponding MT ranges. Signed-off-by: Pekka Paalanen --- src/evdev.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/evdev.c

[PATCH weston 1/8] weston-launcher: use CLOEXEC on fallback path

2012-07-31 Thread Pekka Paalanen
If there is no weston-launcher available, launcher-util.c will fall back to opening the given file itself. It that case it does not set the close-on-exec flag, and will presumably leak the file descriptor to children. Use O_CLOEXEC on the fallback path, too. Signed-off-by: Pekka Paalanen --- sr

Cherry-picks from evdev series

2012-07-31 Thread Pekka Paalanen
Hi Kristian, I'll reply to this email with a series of weston patches, that I have cherry-picked from the previous long evdev series, that needs more work. These are misc patches that don't depend on the evdev work, and can be useful on their own, cutting down the size of the next evdev series.

[PATCH v2] shell: moving drag surface refine

2012-07-31 Thread juan . j . zhao
From: Juan Zhao When applications not directly based on toytoolkit, like simple-egl, efl applications is grabbed and moved, they may be moved to the place under the panel. Then they could not be grabbed again. Don't allow the pointer's bounding box move across the shell's active_regions. One mor