[PATCH] shell: correct the member name of getting panel height

2012-07-09 Thread juan . j . zhao
From: Juan Zhao It does not get the correct panel height for now. The memeber of list to read should be layer_link not link now. Signed-off-by: Juan Zhao --- src/shell.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shell.c b/src/shell.c index 2cc0139..66c9d64 100644

[PATCH 2/2] desktop-shell: Add sliding layout on background

2012-07-09 Thread tecton69
From: Ning Tang This patch is based on Zhi Wen's patch. Dragging the layout have an effect of switching between them. Shortcuts are placed on layouts and can be activated as launcher. They are also draggable and can be deleted. The section name in weston.ini is "layout" and with no keys. I

[PATCH 1/2] desktop-shell: Add shortcut on background and can be activated.

2012-07-09 Thread tecton69
From: Wu, Zhiwen The section name in weston.ini is "shortcut" and keys definition are the same as launcher. The layout of shortcut is hardcoded for implementation convenience. Since the concept of shortcut is almost the same as panel_launcher, reused the panel_launcher code. Signed-off-by: Wu Zh

Re: [PATCH 5/5] shm: Plug leak in shm_create_pool()

2012-07-09 Thread Kristian Høgsberg
On Mon, Jul 09, 2012 at 11:35:57AM +0200, Martin Olsson wrote: > --- > src/wayland-shm.c | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/src/wayland-shm.c b/src/wayland-shm.c > index 62afc3b..7565623 100644 > --- a/src/wayland-shm.c > +++ b/src/wayland-s

Re: Proposed rearrangement of wl_event_loop_dispatch

2012-07-09 Thread Bill Spitzak
David Herrmann wrote: Hi Bill On Mon, Jul 9, 2012 at 8:06 PM, Bill Spitzak wrote: Any comments on this? It is much easier to comment on and follow patches if you include them inline. Also, where is the git headline? I recommend using git-format-patch and optionally git-send-email (even fo

Re: [systemd-devel] [RFC] VTs for multiple seats

2012-07-09 Thread Kristian Høgsberg
On Mon, Jul 09, 2012 at 10:27:35PM +0200, Lennart Poettering wrote: > On Wed, 04.07.12 20:13, David Herrmann (dh.herrm...@googlemail.com) wrote: > > > 3) Wayland as central VT-master. Let's run a central > > wayland-compositor on each seat which acquires the video and input > > devices on that sea

Re: [PATCH] Fixup source comment in wayland-util.h and fix typo in TODO

2012-07-09 Thread Kristian Høgsberg
On Mon, Jul 09, 2012 at 06:22:05PM +0200, Martin Olsson wrote: Thanks, committed. Kristian > TODO |2 +- > src/wayland-util.h |4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/TODO b/TODO > index b0c4fb3..677782d 100644 > --- a/TODO > +++ b/TODO

Re: [PATCH] doc: fix some typos in documentation

2012-07-09 Thread Kristian Høgsberg
On Mon, Jul 09, 2012 at 03:50:39PM +0200, Martin Olsson wrote: Nice, thanks. Kristian > --- > doc/Wayland/en_US/Protocol.xml |4 ++-- > protocol/wayland.xml |4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/doc/Wayland/en_US/Protocol.xml b/doc/Waylan

Re: [PATCH] wcap-snapshot: add return value

2012-07-09 Thread Kristian Høgsberg
On Mon, Jul 09, 2012 at 05:18:10PM +0200, Jan Engelhardt wrote: > Distro build with rpmlint aborts due to missing exit status. > --- > wcap/wcap-snapshot.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Thanks, committed. Kristian > diff --git a/wcap/wcap-snapshot.c b/wcap/wcap-sn

Re: [PATCH wayland 1/2] cursor: use os_create_anonymous_file()

2012-07-09 Thread Kristian Høgsberg
On Mon, Jul 09, 2012 at 01:34:34PM +0300, Pekka Paalanen wrote: > Copy the implementation of os_create_anonymous_file() here from weston, > so we can use it instead of hardcoding a path to /tmp, which does not > exist on Android. > > Without this, cursors cannot be loaded on Android. Thanks, comm

Re: [PATCH weston] toytoolkit: Remove redundant XKB free

2012-07-09 Thread Kristian Høgsberg
On Mon, Jul 09, 2012 at 12:27:28PM +0100, Daniel Stone wrote: > We already unref these in fini_xkb(). Thanks, committed. Kristian > Signed-off-by: Daniel Stone > --- > clients/window.c |5 - > 1 file changed, 5 deletions(-) > > diff --git a/clients/window.c b/clients/window.c > index

Re: [PATCH wayland 2/2] cursor: fix some leaks

2012-07-09 Thread Kristian Høgsberg
On Mon, Jul 09, 2012 at 01:34:35PM +0300, Pekka Paalanen wrote: > - don't leak memory in shm_pool_create() on failure > - don't leak fd in shm_pool_destroy() > - return NULL from wl_cursor_theme_load() if pool fails > > Tha last one fixes a segfault, when shm_pool_create() has failed. I think Mar

Re: [PATCH 0/5] a few cppcheck static analysis fixes

2012-07-09 Thread Kristian Høgsberg
On Mon, Jul 09, 2012 at 11:35:52AM +0200, Martin Olsson wrote: > Martin Olsson (5): > Add cscope.out to .gitignore > wayland-cursor: Add error handling for shm_pool_create() > scanner: Plug memory leak in end_element() > server: Don't crash for wl_seat_set_touch(seat, NULL) > shm: Plug le

Re: [PATCH wayland] protocol: Add missing allow-null to data_device.enter data_offer field

2012-07-09 Thread Kristian Høgsberg
On Mon, Jul 09, 2012 at 01:15:20PM +0300, Ander Conselvan de Oliveira wrote: > Fixes bug 51889. Thanks, committed. Kristian > --- > protocol/wayland.xml |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/protocol/wayland.xml b/protocol/wayland.xml > index 54fb9e0..b

Re: [PATCH 10/10] clients: Silence 2x gcc 4.6.3 "warn_unused_result" compiler warnings

2012-07-09 Thread Kristian Høgsberg
On Sun, Jul 08, 2012 at 10:58:35AM +0300, Pekka Paalanen wrote: > On Sun, 8 Jul 2012 03:03:47 +0200 > Martin Olsson wrote: > > > window.c:1173:6: warning: ignoring return value of ‘read’, declared with > > attribute warn_unused_result [-Wunused-result] > > desktop-shell.c:305:6: warning: ignori

Re: [PATCH 00/10] fix cppcheck and compiler warnings

2012-07-09 Thread Kristian Høgsberg
On Sun, Jul 08, 2012 at 03:03:37AM +0200, Martin Olsson wrote: > These patches silence some issues found by the cppcheck > static analyzer, and it also fixes two compiler warnings. Thanks, that all looks good, applied Kristian > Martin Olsson (10): > clients: Add clients/weston-screensaver to

Re: [PATCH weston] compositor: Always empty the input region of the pointer surface

2012-07-09 Thread Kristian Høgsberg
On Wed, Jul 04, 2012 at 03:48:29PM +0300, Ander Conselvan de Oliveira wrote: > Otherwise a surface.attach request might cause the input region to be > reset to the default value (the entire surface) causing it to receive > focus. Thanks, applied. Kristian > Tiago ran into this problem with xwayla

Re: [PATCH 4/4] xwayland: Fixme: Free windows in hash

2012-07-09 Thread Kristian Høgsberg
On Tue, Jul 03, 2012 at 11:10:11PM +0200, Martin Minarik wrote: > Use custom wrapper iterator function for destroying each window in hash. > --- > src/xwayland/window-manager.c |9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/src/xwayland/window-manager.c b/src/

Re: [PATCH] weston: Clip window title text to the frame

2012-07-09 Thread Kristian Høgsberg
On Mon, Jul 02, 2012 at 11:05:50PM +0200, Martin Minarik wrote: > Fixes an issue with text overflowing the available frame space. Thanks, committed. Kristian > shared/cairo-util.c |4 > 1 file changed, 4 insertions(+) > > diff --git a/shared/cairo-util.c b/shared/cairo-util.c > index

Re: Proposed rearrangement of wl_event_loop_dispatch

2012-07-09 Thread David Herrmann
Hi Bill On Mon, Jul 9, 2012 at 8:06 PM, Bill Spitzak wrote: > Any comments on this? > It is much easier to comment on and follow patches if you include them inline. Also, where is the git headline? I recommend using git-format-patch and optionally git-send-email (even for RFC patches). Regardin

Re: Forsed disabled clienside window decoration

2012-07-09 Thread Bill Spitzak
I am also interested in methods to either tell the client to not draw the "edges" or for the compositor to know the thickness of these so that it can clip them off, so that attach-to-output-edge effects (maximize height, snap-to-edge, maximize, and full-screen) can be done. It looks like the w

Re: Proposed rearrangement of wl_event_loop_dispatch

2012-07-09 Thread Bill Spitzak
Any comments on this? On 06/27/2012 09:47 PM, Bill Spitzak wrote: If dispatch_idle_sources() has a side effect of reading from one of the epoll fd's it can cause the fd to become un-ready yet there are still events in the internal queue. This patch moves the (possibly mis-named) post_dispatch_c

Re: Removing edges in wl_shell_surface::configure

2012-07-09 Thread Bill Spitzak
Any comments on this? Somebody else just posted a question about removing client-side decorations, which this would allow if all the bits are turned on. Basically, what (if anything) is wayland doing about the fact that surfaces attached to the edges of outputs and/or maximized should either

Input Methods

2012-07-09 Thread Philipp
Hi everyone, I have been thinking about trying to implement a simple composing input method (like for example pinyin). I read http://blog.jpetersen.org/2012/06/20/text-input-method-support-in-wayland/ and https://wiki.maliit.org/Wayland_Input_Method_System_Proposal but I didn't manage to understan

[PATCH] Fixup source comment in wayland-util.h and fix typo in TODO

2012-07-09 Thread Martin Olsson
--- TODO |2 +- src/wayland-util.h |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/TODO b/TODO index b0c4fb3..677782d 100644 --- a/TODO +++ b/TODO @@ -19,7 +19,7 @@ Core wayland protocol bigger atomic change. To be researched a bit. - Maybe tr

[PATCH] doc: fix some typos in documentation

2012-07-09 Thread Martin Olsson
--- doc/Wayland/en_US/Protocol.xml |4 ++-- protocol/wayland.xml |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/Wayland/en_US/Protocol.xml b/doc/Wayland/en_US/Protocol.xml index 09ed2ba..9a7db53 100644 --- a/doc/Wayland/en_US/Protocol.xml +++ b/doc/Wa

[PATCH weston] toytoolkit: Remove redundant XKB free

2012-07-09 Thread Daniel Stone
We already unref these in fini_xkb(). Signed-off-by: Daniel Stone --- clients/window.c |5 - 1 file changed, 5 deletions(-) diff --git a/clients/window.c b/clients/window.c index 8f3c942..39a9dd6 100644 --- a/clients/window.c +++ b/clients/window.c @@ -3335,11 +3335,6 @@ input_destroy(s

[PATCH wayland 2/2] cursor: fix some leaks

2012-07-09 Thread Pekka Paalanen
- don't leak memory in shm_pool_create() on failure - don't leak fd in shm_pool_destroy() - return NULL from wl_cursor_theme_load() if pool fails Tha last one fixes a segfault, when shm_pool_create() has failed. Signed-off-by: Pekka Paalanen --- cursor/wayland-cursor.c | 11 ++- 1 fil

[PATCH wayland 1/2] cursor: use os_create_anonymous_file()

2012-07-09 Thread Pekka Paalanen
Copy the implementation of os_create_anonymous_file() here from weston, so we can use it instead of hardcoding a path to /tmp, which does not exist on Android. Without this, cursors cannot be loaded on Android. Signed-off-by: Pekka Paalanen --- configure.ac |2 +- cursor/Makefi

Re: [PATCH 4/5] server: Don't crash for wl_seat_set_touch(seat, NULL)

2012-07-09 Thread Martin Olsson
Pekka already sent a (still unmerged) patch for this on the 5th of July, subject: [PATCH wayland 2/2] server: fix wl_seat_set_{keyboard,touch} So probably just drop my patch. M On 07/09/2012 11:35 AM, Martin Olsson wrote: --- src/wayland-server.c |2 +- 1 file changed, 1 insertion(+),

[PATCH wayland] protocol: Add missing allow-null to data_device.enter data_offer field

2012-07-09 Thread Ander Conselvan de Oliveira
Fixes bug 51889. --- protocol/wayland.xml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 54fb9e0..b6beceb 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -365,7 +365,7 @@ - +

[PATCH 5/5] shm: Plug leak in shm_create_pool()

2012-07-09 Thread Martin Olsson
--- src/wayland-shm.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/wayland-shm.c b/src/wayland-shm.c index 62afc3b..7565623 100644 --- a/src/wayland-shm.c +++ b/src/wayland-shm.c @@ -188,29 +188,27 @@ shm_create_pool(struct wl_client *client, struct wl

[PATCH 3/5] scanner: Plug memory leak in end_element()

2012-07-09 Thread Martin Olsson
--- src/scanner.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/scanner.c b/src/scanner.c index 4d4537c..0076d92 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -462,7 +462,7 @@ end_element(void *data, const XML_Char *name) char *text = strndup(ctx->c

[PATCH 0/5] a few cppcheck static analysis fixes

2012-07-09 Thread Martin Olsson
Martin Olsson (5): Add cscope.out to .gitignore wayland-cursor: Add error handling for shm_pool_create() scanner: Plug memory leak in end_element() server: Don't crash for wl_seat_set_touch(seat, NULL) shm: Plug leak in shm_create_pool() .gitignore |1 + cursor/wayland-

[PATCH 2/5] wayland-cursor: Add error handling for shm_pool_create()

2012-07-09 Thread Martin Olsson
--- cursor/wayland-cursor.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/cursor/wayland-cursor.c b/cursor/wayland-cursor.c index 7621020..36a8b54 100644 --- a/cursor/wayland-cursor.c +++ b/cursor/wayland-cursor.c @@ -49,27 +49,29 @@ shm_pool_create(st

[PATCH 4/5] server: Don't crash for wl_seat_set_touch(seat, NULL)

2012-07-09 Thread Martin Olsson
--- src/wayland-server.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index d141682..9f9d6b3 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -759,7 +759,7 @@ wl_seat_set_touch(struct wl_seat *seat, struct wl_touc

[PATCH 1/5] Add cscope.out to .gitignore

2012-07-09 Thread Martin Olsson
--- .gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 904eb50..a33c7fa 100644 --- a/.gitignore +++ b/.gitignore @@ -27,3 +27,4 @@ /stamp-h1 Makefile Makefile.in +cscope.out -- 1.7.9.5 ___ wayland-devel m

Re: [PATCH] clients: Free resources on exit in eventdemo

2012-07-09 Thread Pekka Paalanen
On Sun, 08 Jul 2012 15:59:44 +0200 Martin Olsson wrote: > On 07/08/2012 03:09 PM, Pekka Paalanen wrote: > > Looks good to me now, I assume you tested this program exits > > properly. Btw. have you tried Valgrind on these? > > Yes I tried it; FWIW with the new call to display_destroy the > event