Missing libpthread dependence in Weston config files?

2012-07-07 Thread Mikalai Kisialiou
Not sure if this list is the proper media for communicating potential issues/bugs. I've just built Weston from the git repo on a brand new Ubuntu 12.02 LTS. During Weston compilation there is an error that some libpthread functions are not found. The problem can be fixed by modifying ./weston/wcap/

[PATCH 03/10] clients: Don't leak "menu" on error path in clients/window.c

2012-07-07 Thread Martin Olsson
--- clients/window.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/clients/window.c b/clients/window.c index 8f3c942..f81d06f 100644 --- a/clients/window.c +++ b/clients/window.c @@ -3133,8 +3133,10 @@ window_show_menu(struct display *display, return;

[PATCH 04/10] shared: Don't leak file descriptor in shared/image-loader.c

2012-07-07 Thread Martin Olsson
--- shared/image-loader.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/shared/image-loader.c b/shared/image-loader.c index a3218df..b47c1a7 100644 --- a/shared/image-loader.c +++ b/shared/image-loader.c @@ -359,8 +359,10 @@ load_image(const char *filename) if (

[PATCH 10/10] clients: Silence 2x gcc 4.6.3 "warn_unused_result" compiler warnings

2012-07-07 Thread Martin Olsson
window.c:1173:6: warning: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Wunused-result] desktop-shell.c:305:6: warning: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Wunused-result] --- clients/desktop-shell.c |3 ++- clients/wi

[PATCH 05/10] compositor-android: Add proper error handling in android_compositor_create()

2012-07-07 Thread Martin Olsson
--- src/compositor-android.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/compositor-android.c b/src/compositor-android.c index 54cfa2e..98956f6 100644 --- a/src/compositor-android.c +++ b/src/compositor-android.c @@ -419,31 +419,39 @@ android_c

[PATCH 00/10] fix cppcheck and compiler warnings

2012-07-07 Thread Martin Olsson
These patches silence some issues found by the cppcheck static analyzer, and it also fixes two compiler warnings. Martin Olsson (10): clients: Add clients/weston-screensaver to clients/.gitignore clients: Free resources on exit in eventdemo clients: Don't leak "menu" on error path in clients

[PATCH 06/10] compositor-wayland: Add error handling in wayland_compositor_create()

2012-07-07 Thread Martin Olsson
--- src/compositor-wayland.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index ea09730..9df7228 100644 --- a/src/compositor-wayland.c +++ b/src/compositor-wayland.c @@ -847,16 +847,16 @@ wayland_c

[PATCH 01/10] clients: Add clients/weston-screensaver to clients/.gitignore

2012-07-07 Thread Martin Olsson
--- clients/.gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/clients/.gitignore b/clients/.gitignore index fe50580..b43992b 100644 --- a/clients/.gitignore +++ b/clients/.gitignore @@ -23,6 +23,7 @@ weston-desktop-shell weston-tablet-shell weston-screenshooter weston-terminal +

[PATCH 09/10] wcap: Plug memory leak in wcap_decoder_create()

2012-07-07 Thread Martin Olsson
--- wcap/wcap-decode.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/wcap/wcap-decode.c b/wcap/wcap-decode.c index 425ccff..3dc7e6d 100644 --- a/wcap/wcap-decode.c +++ b/wcap/wcap-decode.c @@ -120,8 +120,10 @@ wcap_decoder_create(const char *filename) re

[PATCH 07/10] compositor-x11: Add error handling in x11_compositor_create()

2012-07-07 Thread Martin Olsson
--- src/compositor-x11.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/src/compositor-x11.c b/src/compositor-x11.c index 5afaa7a..f2f0cb1 100644 --- a/src/compositor-x11.c +++ b/src/compositor-x11.c @@ -1064,17 +1064,17 @@ x11_compositor_create(str

[PATCH 02/10] clients: Free resources on exit in eventdemo

2012-07-07 Thread Martin Olsson
--- clients/eventdemo.c | 13 + 1 file changed, 13 insertions(+) diff --git a/clients/eventdemo.c b/clients/eventdemo.c index daf3283..bc066be 100644 --- a/clients/eventdemo.c +++ b/clients/eventdemo.c @@ -261,6 +261,7 @@ motion_handler(struct widget *widget, struct input *input, u

[PATCH 08/10] xwayland: Don't leak fd while reading lock file in src/xwayland/launcher.c

2012-07-07 Thread Martin Olsson
--- src/xwayland/launcher.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/xwayland/launcher.c b/src/xwayland/launcher.c index 0184c08..035c8e3 100644 --- a/src/xwayland/launcher.c +++ b/src/xwayland/launcher.c @@ -274,6 +274,7 @@ create_lockfile(int display, char *lockfile, size_t lsi