Re: Input Method Support for Wayland

Hi, sorry for the late response, I was on vacation for some days. On 06/21/2012 11:33 PM, Kristian Høgsberg wrote: The protocol looks good, with the caveat that I don't fully understand all the preedit stuff. Most crucial is the text_model interface, since that's what all apps are going to int

Re: [PATCH weston 0/5] Overlay fixes

On Tue, Jun 26, 2012 at 05:09:10PM +0300, Ander Conselvan de Oliveira wrote: > Hi, > > This series fixes a few crashes when using the overlay code in drm > compositor. I did the first patch for debugging purposes, but it might > be useful anyway. Thanks, all applied and pushed. > Cheers, > Ander

Re: [PATCH weston 1/5] simple-egl: Make window moveable

On Tue, Jun 26, 2012 at 05:09:11PM +0300, Ander Conselvan de Oliveira wrote: Looks good, but you know you can move windows with super+click, right? Kristian > --- > clients/simple-egl.c |7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/clients/simple-egl.c b/clients/simple-egl

Re: [PATCH weston 3/5] compositor-drm: Wait for vblank events before starting next frame

On Tue, Jun 26, 2012 at 05:09:13PM +0300, Ander Conselvan de Oliveira wrote: > Besides the fact of the frame not being done, assigning planes before > the vblank handler is called will make the state inconsistent, leading > to a crash. Right. We could use some kind of pending notification ref-cou

[PATCH weston 5/5] compositor-drm: Don't leak FBs when the buffer of a sprite is detroyed

As a side effect, the overlay is disabled when the buffer is destroyed. --- src/compositor-drm.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 6c182d7..334a421 100644 --- a/src/compositor-drm.c +++ b/src/compositor-drm.c @@ -1188,8 +

[PATCH weston 4/5] compositor-drm: Remove destroy listeners when disabling planes

When an unused plane is disabled, the destroy listener for a previously used buffer needs to be removed. This fixes a crash when an overlay would be reenabled using the same buffer as before, causing the destroy listener to be inserted twice. --- src/compositor-drm.c | 10 -- 1 file chan

[PATCH weston 3/5] compositor-drm: Wait for vblank events before starting next frame

Besides the fact of the frame not being done, assigning planes before the vblank handler is called will make the state inconsistent, leading to a crash. --- src/compositor-drm.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/src/compositor-drm.c

[PATCH weston 2/5] compositor-drm: Check surface's outputs when assigning overlays

Check if the output passed to drm_output_prepare_overlay_surface() does actually contain the surface and fail if it doesn't. Also fail if a surface spans multiple outputs since clearing the damage will cause the portion that is not in an overlay to not be updated at all. --- src/compositor-drm.c |

[PATCH weston 1/5] simple-egl: Make window moveable

--- clients/simple-egl.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/clients/simple-egl.c b/clients/simple-egl.c index 25c7bdf..0091172 100644 --- a/clients/simple-egl.c +++ b/clients/simple-egl.c @@ -28,6 +28,8 @@ #include #include +#include + #include #include @@ -

[PATCH weston 0/5] Overlay fixes

Hi, This series fixes a few crashes when using the overlay code in drm compositor. I did the first patch for debugging purposes, but it might be useful anyway. Cheers, Ander Ander Conselvan de Oliveira (5): simple-egl: Make window moveable compositor-drm: Check surface's outputs when assigni