Re: [PATCH] Add minimum size for terminal

2012-06-18 Thread Stefan Risberg
On Mon, Jun 18, 2012 at 08:59:26PM +0200, Alexander Preisinger wrote: > At the moment the terminal can a negativ size and resizing it can create > some artifacts. > --- > clients/terminal.c |6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/clients/terminal.c b/clients/terminal.c >

[PATCH wayland] Xcursor: Don't ignore unknown file types

2012-06-18 Thread Daniel Stone
XFS doesn't return the file type with opendir(), and instead only returns it when you stat() the file itself. c66f2602 introduced a check to ensure that only files and symlinks were loaded, while not checking for DT_UNKNOWN. Properly handle DT_UNKNOWN by just proceeding anyway. Signed-off-by: Da

[PATCH] Add minimum size for terminal

2012-06-18 Thread Alexander Preisinger
At the moment the terminal can a negativ size and resizing it can create some artifacts. --- clients/terminal.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/clients/terminal.c b/clients/terminal.c index 4308875..7e1c741 100644 --- a/clients/terminal.c +++ b/clients/terminal.c @@ -7

[PATCH weston 2/2] Rename weston_compositor EGLDisplay member to egl_display

2012-06-18 Thread Daniel Stone
EGLDisplay is helpfully typedeffed as void *, which means that you won't get conflicting-pointer-type warnings if you accidentally confuse it with weston_compositor::wl_display. Rename it to make it more clear which display you're dealing with, and also rename compositor-wayland's parent.display m

[PATCH weston 1/2] tablet-shell: Fix compilation warnings

2012-06-18 Thread Daniel Stone
Include unistd.h to get fork and execl prototypes, and remove declarations of two unused variables. Signed-off-by: Daniel Stone --- clients/tablet-shell.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/clients/tablet-shell.c b/clients/tablet-shell.c index 63ddbb2..0f58d

[PATCH weston] Don't segfault clients when cursor isn't found

2012-06-18 Thread Daniel Stone
If we can't find a cursor for whatever reason, don't crash the client in pointer_surface_frame_callback. Signed-off-by: Daniel Stone --- clients/window.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/clients/window.c b/clients/window.c index 436f862..36caeb3 100644

Re: [PATCH wayland 1/2] protocol: replace pointer.attach with pointer.set_cursor

2012-06-18 Thread Bill Spitzak
Pekka Paalanen wrote: I wonder if we could phrase this paragraph even more clearly... "The parameters hotspot_x,hotspot_y define the cursor hotspot in the cursor surface, given in cursor surface-local coordinates. In other words, if x,y is the cursor position on a (window) surface, then the top

[PATCH weston 3/4] compositor-drm: Make drm_destroy safe during init

2012-06-18 Thread Daniel Stone
Make drm_destroy a bit more paranoid, so it's safe to call it during initialisation. Signed-off-by: Daniel Stone --- src/compositor-drm.c | 35 +-- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index

[PATCH weston 2/4] Add safety checks to weston_compositor_shutdown

2012-06-18 Thread Daniel Stone
Make it safe to call weston_compositor_shutdown on a not-fully-initialised weston_compositor. Signed-off-by: Daniel Stone --- src/compositor.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 224d9ff..cdb6d01 100644 --- a/src/

[PATCH weston 0/4] Fail DRM initialisation gracefully

2012-06-18 Thread Daniel Stone
Hi, This patchset lets compositor-drm fail gracefully and safely during initialisation. So, for example, if you have a broken Mesa that doesn't want to compile any shaders, you'll at least be left where you started rather than at a dead VT that not even chvt can break away from. Cheers, Daniel _

[PATCH weston 4/4] compositor-drm: Use drm_destroy to clean up during init

2012-06-18 Thread Daniel Stone
If we fail initialisation for any reason, use drm_destroy to clean up rather than just returning NULL, so we don't leave people stranded at a dead TTY that not even chvt can switch away from. Signed-off-by: Daniel Stone --- src/compositor-drm.c | 12 ++-- 1 file changed, 10 insertions(

[PATCH weston 1/4] Add weston_compositor_pre_init

2012-06-18 Thread Daniel Stone
Split off list initialisation from weston_compositor_init. If we call this from weston_compositor_init, then we can make it safe to call weston_compositor_shutdown during init. Signed-off-by: Daniel Stone --- src/compositor-android.c |2 ++ src/compositor-drm.c |2 ++ src/compositor

Re: [PATCH weston] compositor-wayland: Respond to ping requests on outputs' shell surfaces

2012-06-18 Thread Scott Moreau
On Mon, Jun 18, 2012 at 8:36 AM, Ander Conselvan de Oliveira < ander.conselvan.de.olive...@intel.com> wrote: > Otherwise one can't interact with it because of the busy cursor grab. > --- > > I noticed you can't interact with *any* busy surface because of the pointer grab. e.g. You can't rotate, ch

[PATCH weston] compositor-wayland: Respond to ping requests on outputs' shell surfaces

2012-06-18 Thread Ander Conselvan de Oliveira
Otherwise one can't interact with it because of the busy cursor grab. --- src/compositor-wayland.c | 30 +- 1 files changed, 29 insertions(+), 1 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c index d498e84..fc1917d 100644 --- a/src/comp

Re: [PATCH weston 5/5] window: Implement animated cursors (using pointer surfaces)

2012-06-18 Thread Ander Conselvan de Oliveira
On 06/15/2012 06:05 PM, Kristian Høgsberg wrote: On Fri, Jun 15, 2012 at 05:27:36PM +0300, Ander Conselvan de Oliveira wrote: Since the introduction of pointer.set_cursor(), it is possible for a client to set the surface containing the pointer image and get frame callbacks on it thus allowing a

Re: [PATCH wayland 1/2] protocol: replace pointer.attach with pointer.set_cursor

2012-06-18 Thread Ander Conselvan de Oliveira
On 06/18/2012 12:06 PM, Pekka Paalanen wrote: On Fri, 15 Jun 2012 17:27:32 +0300 Ander Conselvan de Oliveira wrote: --- protocol/wayland.xml | 27 +-- 1 files changed, 21 insertions(+), 6 deletions(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index e

Re: [PATCH wayland 1/2] protocol: replace pointer.attach with pointer.set_cursor

2012-06-18 Thread Pekka Paalanen
On Fri, 15 Jun 2012 17:27:32 +0300 Ander Conselvan de Oliveira wrote: > --- > protocol/wayland.xml | 27 +-- > 1 files changed, 21 insertions(+), 6 deletions(-) > > diff --git a/protocol/wayland.xml b/protocol/wayland.xml > index e9c6787..23b244f 100644 > --- a/protoco

[PATCH] tablet-shell: Add actual actions for launcher.

2012-06-18 Thread zhiwen . wu
From: Alex Wu The launcher before in tablet-shell just draw the icon and will not activate a client. This patch makes the launcher as sub-widget of homescreen, and implements enter/leave/button/redraw hanler to do the actual client launching action. --- clients/tablet-shell.c | 112