[PATCH] add simple-drm test

2012-06-07 Thread Zhao Halley
wayland-drm is a protocol to share buffer between wayland server and client. it is a simple case to demonstrate how it works. when I prepares some patches for mesa to extends buffer format supported by wayland-drm, a test case is asked. then it does. --- clients/Makefile.am |

RE: [PATCH weston 2/3] compositor: print a clear message when XDG_RUNTIME_DIR is not set

2012-06-07 Thread Eoff, Ullysses A
Not sure why we're requiring XDG_RUNTIME_DIR to be set... isn't there another way to handle this more gracefully instead forcing Weston to exit? I don't believe I've ever had problems running Weston when XDG_RUNTIME_DIR was undefined. According to the spec at

Re: [PATCH weston 1/4] Move animation_list to weston_output().

2012-06-07 Thread Scott Moreau
On Thu, Jun 7, 2012 at 4:30 PM, Scott Moreau wrote: > >> >>> Also, you should remove the timestamp = weston_compositor_get_time() >>> initializations (here and other animations) now that we solved that >>> problem. >>> >> >> I'm not really clear what you want to happen here. The timestamp should

[PATCH] Weston: Clock

2012-06-07 Thread Martin Minarik
A panel clock. --- clients/desktop-shell.c | 143 ++- 1 files changed, 141 insertions(+), 2 deletions(-) diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c index b767839..3e014cc 100644 --- a/clients/desktop-shell.c +++ b/clients/desktop-sh

Re: [PATCH weston 1/4] Move animation_list to weston_output().

2012-06-07 Thread Scott Moreau
> > > >> Also, you should remove the timestamp = weston_compositor_get_time() >> initializations (here and other animations) now that we solved that >> problem. >> > > I'm not really clear what you want to happen here. The timestamp should > now be set in weston_output_repaint() when adding the pen

Re: [PATCH weston 2/4 v2] Add animation helper functions for consistency.

2012-06-07 Thread Scott Moreau
> Makes sense, but let's add a typedef for the function pointer. > Kristian > Sounds good. ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston 4/4] zoom: Implement animated transitions for zoom in/out.

2012-06-07 Thread Scott Moreau
> > Looks fine on a quick read-through, but depends on changes in the > previous patches. > > Kristian > > Thanks. I will fix up the previous patches and rebase this one on top. ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lis

Re: [PATCH weston 2/4] Add weston_animation_exists().

2012-06-07 Thread Scott Moreau
On Thu, Jun 7, 2012 at 3:15 PM, Kristian Høgsberg wrote: > On Thu, Jun 07, 2012 at 09:12:30AM -0600, Scott Moreau wrote: > > --- > > src/compositor.c |8 +++- > > src/compositor.h |2 ++ > > 2 files changed, 9 insertions(+), 1 deletions(-) > > > > diff --git a/src/compositor.c b/src/c

Re: [PATCH weston 1/4] Move animation_list to weston_output().

2012-06-07 Thread Scott Moreau
On Thu, Jun 7, 2012 at 3:13 PM, Kristian Høgsberg wrote: > On Thu, Jun 07, 2012 at 09:12:29AM -0600, Scott Moreau wrote: > > Here we introduce a pending animation_list to which animations are > > added by weston_animation_run(). This fixes a timing issue when > > an animation is started from a key

Re: [PATCH weston 2/4 v2] Add animation helper functions for consistency.

2012-06-07 Thread Kristian Høgsberg
On Thu, Jun 07, 2012 at 11:03:31AM -0600, Scott Moreau wrote: > This patch introduces two additional functions: > > weston_animation_init() - Initializes an animation and sets the frame handler. > weston_animation_exists() - Checks if an animation is in any list. > --- > > The animation should be

Re: [PATCH weston 4/4] zoom: Implement animated transitions for zoom in/out.

2012-06-07 Thread Kristian Høgsberg
On Thu, Jun 07, 2012 at 09:12:32AM -0600, Scott Moreau wrote: > --- > src/compositor.c | 82 - > src/compositor.h | 63 +++-- > src/shell.c | 18 +-- > 3 files changed, 112 insertions(+), 51

Re: [PATCH weston 3/4] zoom: Convert wl_fixed_t directly into floats, to avoid truncation.

2012-06-07 Thread Kristian Høgsberg
On Thu, Jun 07, 2012 at 09:12:31AM -0600, Scott Moreau wrote: > This fixes center point inaccuracy for rotated surfaces. Thanks to > Pekka Paalanen for spotting it. Nice, applied. Kristian > --- > src/compositor.c | 14 +++--- > 1 files changed, 7 insertions(+), 7 deletions(-) > > dif

Re: [PATCH weston 2/4] Add weston_animation_exists().

2012-06-07 Thread Kristian Høgsberg
On Thu, Jun 07, 2012 at 09:12:30AM -0600, Scott Moreau wrote: > --- > src/compositor.c |8 +++- > src/compositor.h |2 ++ > 2 files changed, 9 insertions(+), 1 deletions(-) > > diff --git a/src/compositor.c b/src/compositor.c > index 9110d4c..7f51424 100644 > --- a/src/compositor.c >

Re: [PATCH weston 1/4] Move animation_list to weston_output().

2012-06-07 Thread Kristian Høgsberg
On Thu, Jun 07, 2012 at 09:12:29AM -0600, Scott Moreau wrote: > Here we introduce a pending animation_list to which animations are > added by weston_animation_run(). This fixes a timing issue when > an animation is started from a keybinding and makes it so frame > handlers are called only once per

Re: [PATCH weston] compositor: return failure even if SEGV handler works

2012-06-07 Thread Kristian Høgsberg
On Thu, Jun 07, 2012 at 02:32:45PM +0300, Pekka Paalanen wrote: > Weston has a SIGSEGV handler that attempts to shut everything down > cleanly. If it actually succeeds in that, the process exit status will > indicate success, when the process just segfaulted. > > Fix that by setting the return val

Re: [PATCH weston 3/3] shell: Animate workspace changes

2012-06-07 Thread Kristian Høgsberg
On Wed, Jun 06, 2012 at 11:36:10AM +0200, Jonas Ådahl wrote: > Signed-off-by: Jonas Ådahl I would like to see the animation use a spring instead, but I'm not going to press that issue. Kristian > --- > src/shell.c | 252 > --- > 1 file

Re: [PATCH weston 2/3] shell: Virtual workspaces

2012-06-07 Thread Kristian Høgsberg
On Wed, Jun 06, 2012 at 11:36:09AM +0200, Jonas Ådahl wrote: > A workspace is a list of top level surfaces visible at a time. New > toplevel surfaces are added to the current workspace. Default > keybindings (modifier - Up and modifier - Down) are used for navigating > between workspaces. By defaul

Re: [PATCH weston 1/3] compositor: Add visibility state to surfaces

2012-06-07 Thread Kristian Høgsberg
On Wed, Jun 06, 2012 at 11:36:08AM +0200, Jonas Ådahl wrote: > When a surface becomes invisible frame callbacks will be queued until > the surface is shown. > > Signed-off-by: Jonas Ådahl > --- > src/compositor.c | 28 +--- > src/compositor.h |6 ++ > 2 files ch

[PATCH weston 4/4 v2] zoom: Implement animated transitions for zoom in/out.

2012-06-07 Thread Scott Moreau
--- Track changes to 2/4 v2 in this series. src/compositor.c | 81 - src/shell.c | 18 +-- 2 files changed, 75 insertions(+), 24 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 9a39d75..d3a9397 100644 --- a

[PATCH weston 2/4 v2] Add animation helper functions for consistency.

2012-06-07 Thread Scott Moreau
This patch introduces two additional functions: weston_animation_init() - Initializes an animation and sets the frame handler. weston_animation_exists() - Checks if an animation is in any list. --- The animation should be initialized consistently so weston_animation_exists() always works. src/c

[PATCH v5 1/2] Weston: log.c, log.h

2012-06-07 Thread Martin Minarik
This is logging functionality for weston compositor. It handles: messages coming from libwayland-server from wl_log() messages from weston itself, from weston_log() Introduce --log option, to specify log file path on the command line. When the path is incorrect, or on weston_log_file_destroy(), f

[PATCH weston 4/4] zoom: Implement animated transitions for zoom in/out.

2012-06-07 Thread Scott Moreau
--- src/compositor.c | 82 - src/compositor.h | 63 +++-- src/shell.c | 18 +-- 3 files changed, 112 insertions(+), 51 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 7cd

[PATCH weston 3/4] zoom: Convert wl_fixed_t directly into floats, to avoid truncation.

2012-06-07 Thread Scott Moreau
This fixes center point inaccuracy for rotated surfaces. Thanks to Pekka Paalanen for spotting it. --- src/compositor.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 7f51424..7cd1927 100644 --- a/src/compositor.c +++

[PATCH weston 2/4] Add weston_animation_exists().

2012-06-07 Thread Scott Moreau
--- src/compositor.c |8 +++- src/compositor.h |2 ++ 2 files changed, 9 insertions(+), 1 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 9110d4c..7f51424 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -980,6 +980,12 @@ fade_frame(struct weston_animation *

[PATCH weston 1/4] Move animation_list to weston_output().

2012-06-07 Thread Scott Moreau
Here we introduce a pending animation_list to which animations are added by weston_animation_run(). This fixes a timing issue when an animation is started from a keybinding and makes it so frame handlers are called only once per a single output's refresh. --- src/compositor.c | 47 ++

[PATCH weston 3/3] compositor: fix a crash on missing keyboard device

2012-06-07 Thread Pekka Paalanen
Signed-off-by: Pekka Paalanen --- src/compositor.c | 23 +-- 1 files changed, 13 insertions(+), 10 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index c073d79..e8b7854 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -1657,16 +1657,19 @@ weston_surfac

[PATCH weston 2/3] shell: fix crash when no pointer device

2012-06-07 Thread Pekka Paalanen
Signed-off-by: Pekka Paalanen --- src/shell.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/shell.c b/src/shell.c index e25bf71..85395c4 100644 --- a/src/shell.c +++ b/src/shell.c @@ -2781,8 +2781,9 @@ shell_init(struct weston_compositor *ec) ret

[PATCH weston 1/3] compositor-x11: add an option to ignore input

2012-06-07 Thread Pekka Paalanen
For testing the compositor without any input devices. Exposes cases where e.g. keyboard or pointer are NULL-dereferenced. Signed-off-by: Pekka Paalanen --- src/compositor-x11.c | 45 - 1 files changed, 28 insertions(+), 17 deletions(-) diff --git a/

[PATCH weston] compositor: return failure even if SEGV handler works

2012-06-07 Thread Pekka Paalanen
Weston has a SIGSEGV handler that attempts to shut everything down cleanly. If it actually succeeds in that, the process exit status will indicate success, when the process just segfaulted. Fix that by setting the return value to failure in the SEGV handler. Signed-off-by: Pekka Paalanen --- sr

Re: [PATCH 1/4 wayland] add damage2 api

2012-06-07 Thread Pekka Paalanen
On Thu, 7 Jun 2012 09:59:15 + "Zhao, Halley" wrote: > Hi pq: > Thanks for your review, I have updated the patches to use > wl_surface_attach2(). > > I agree to your definition of coordinate: all protocol uses surface local > coordinates, buffer coordinate is only used for (sub-)texture map

RE: [PATCH 1/4 wayland] add damage2 api

2012-06-07 Thread Zhao, Halley
Hi pq: Thanks for your review, I have updated the patches to use wl_surface_attach2(). I agree to your definition of coordinate: all protocol uses surface local coordinates, buffer coordinate is only used for (sub-)texture mapping inside Weston. Since opengl and overlay supports scaling in natu

[PATCH 4/4 v2 mesa] update test case to support resize by wl_surface_attach2

2012-06-07 Thread Zhao Halley
--- tests/wayland-drm/wayland-drm-test.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/wayland-drm/wayland-drm-test.c b/tests/wayland-drm/wayland-drm-test.c index aa6f001..5317145 100755 --- a/tests/wayland-drm/wayland-drm-test.c +++ b/tests/wayland-drm/way

[PATCH 3/4 v2 weston] add surface_attach2 to support resize

2012-06-07 Thread Zhao Halley
--- src/compositor-drm.c | 34 +- src/compositor.c | 91 + src/compositor.h |9 - src/shell.c | 51 +++- src/util.c |8 ++-- 5 files changed, 124 insertions(+), 69 d

[PATCH 2/4 v2 weston] test purpose: filter out background/cursor/shell surface disable geometry transform for overlay

2012-06-07 Thread Zhao Halley
From: Zhao halley --- src/compositor-drm.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) mode change 100644 => 100755 src/compositor-drm.c diff --git a/src/compositor-drm.c b/src/compositor-drm.c old mode 100644 new mode 100755 index d588dbf..cb55753 --- a/s

[PATCH 1/4 v2 wayland] add wl_surface attach2 to support scaling

2012-06-07 Thread Zhao Halley
--- protocol/wayland.xml | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 67ece1b..a15b5d0 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -617,6 +617,21 @@ + + +C

[PATCH 0/4 v2] add resize support for wl_surface

2012-06-07 Thread Zhao Halley
overlay plane supports rendering with resize, while wayland protocol doesn't have interface for it yet. so I go ahead to add it and ask for your comments. this interface also has potential benefit for memory footprint: for example: when surface size is bigger than original content (an image may

Re: Patch that "fixes" compositor-x11

2012-06-07 Thread Ander Conselvan de Oliveira
On 06/06/2012 04:10 AM, Bill Spitzak wrote: On 06/05/2012 02:09 PM, Kristian Høgsberg wrote: Argh, you're right, thanks. But you said that just adding the count and returning that alone didn't fix it, right? I wonder if we need a xcb_flush(compositor->conn); in x11_output_repaint() after the