Re: Patch that "fixes" compositor-x11

Any comments or insight on this problem? I'm wondering if the slowness of compositor-x11 is a problem that only I am encountering? If everybody else is using much faster machines perhaps they won't see it, though I think if you run enough clients it should be obvious on any machine. Is there s

Re: [PATCH weston 3/5] compositor: fix weston_output_update_zoom() types

On Mon, Jun 4, 2012 at 8:49 AM, Pekka Paalanen wrote: > The function declaration had different parameter types than the function > definition. The compiler did not warn about that, because wl_fixed_t > used to be typedef'd to int32_t, so with that substitution they were > equal. > > Fix the decla

[PATCH weston 6/6] xwm: use last focused valid window for guessing transient parent

On X the global absolute coordinates are sent in ConfigureNotify and the window is mapped exactly on that position. On Wayland we don't have that, and that's a problem for transient windows without transient_for hint set. So this solution is a workaround. It guess a parent based on the last focuse

[PATCH weston 5/6] xwm: fix transient positioning

commit eaee7841 took out the configure positioning of windows. This patch brings it back and addresses also logic for resizing and sub-menus, that was not covered on that commit. I've tested on the following: firefox, google-chrome, gtk3-demo's Menus widget. Signed-off-by: Tiago Vignatti --- src

[PATCH weston 4/6] xwm: initialize window decoration always as !override

and read later whether some property like MOTIF_WM_HINTS wants to change it to a different value. Signed-off-by: Tiago Vignatti --- src/xwayland/window-manager.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xwayland/window-manager.c b/src/xwayland/window-manager.c i

[PATCH weston 3/6] xwm: use override_redirect for determining or not top-level windows

"top-level window is a window whose override-redirect attribute is False", ICCCM 4.1.1 Signed-off-by: Tiago Vignatti --- src/xwayland/window-manager.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/xwayland/window-manager.c b/src/xwayland/window-manager.

[PATCH weston 2/6] xwayland: fix typo on configure libs

Signed-off-by: Tiago Vignatti --- src/xwayland/Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xwayland/Makefile.am b/src/xwayland/Makefile.am index 32f0058..cae8591 100644 --- a/src/xwayland/Makefile.am +++ b/src/xwayland/Makefile.am @@ -10,7 +10,7 @@ modul

[PATCH weston 1/6] xwm: don't try to remove nonexistent frame

on the first time, the transient surface is mapped and viewable, then if it gets unmapped on the second time it doesn't show up anymore. This happens with any X window that Weston maps as transient surface. Signed-off-by: Tiago Vignatti --- src/xwayland/window-manager.c |3 +++ 1 file chan

Re: [PATCH weston 1/2] Convert text cursor position protocol to use fixed types.

On Fri, Jun 01, 2012 at 12:46:09PM -0600, Scott Moreau wrote: Thanks, all applied. Kristian > --- > clients/window.c |4 +++- > protocol/text-cursor-position.xml |4 ++-- > src/compositor.c | 18 +- > src/compositor.h |

Re: [PATCH weston 0/3] Input fixups

On Mon, Jun 04, 2012 at 11:40:45AM +0100, Daniel Stone wrote: > Hi, > These three patches fix a couple of issues from previous patchsets, > including a crash in the nested Wayland compositor. Thanks, all committed. Kristian > Cheers, > Daniel > > ___ >

[PATCH weston 5/5] compositor: fix weston_seat_update_drag_surface() call sites

The function expects dx,dy arguments as ints. Fix the passed values, so that they really match the types used. Signed-off-by: Pekka Paalanen --- src/compositor.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index b548cf7.

[PATCH weston 4/5] compositor: fix weston_compositor_run_axis_binding() declaration

The parameter type of definition and declaration were different. The compiler never noticed before, because wl_fixed_t was defined to be int32_t. Also adapt the calling site to the type-safe wl_fixed_t. Signed-off-by: Pekka Paalanen --- src/compositor.c |2 +- src/compositor.h |2 +- 2

[PATCH weston 3/5] compositor: fix weston_output_update_zoom() types

The function declaration had different parameter types than the function definition. The compiler did not warn about that, because wl_fixed_t used to be typedef'd to int32_t, so with that substitution they were equal. Fix the declaration and definition to match. Also, convert wl_fixed_t directly

[PATCH weston 2/5] shell: simplify hit test in do_zoom()

pixman_region32_contains_point() takes ints, so do not convert to double. Signed-off-by: Pekka Paalanen --- src/shell.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/shell.c b/src/shell.c index 1ba0cfc..bfa1b29 100644 --- a/src/shell.c +++ b/src/shell.c @@ -

[PATCH weston 1/5] compositor: trivial wl_fixed_t type fixes

This commit requires the libwayland commit "make wl_fixed_t a safe type". Track the type changes, making sure the types match. Only the trivial cases are fixed, where the existing code already did the right thing. Signed-off-by: Pekka Paalanen --- src/compositor-wayland.c |7 +++-- src/comp

[PATCH wayland] make wl_fixed_t a safe type

Turn wl_fixed_t into a struct type, so that it will no longer implicitly cast into any other type. Silent implicit casts between wl_fixed_t and all integer types have hidden many bugs, that the compiler could have easily cought. Signed-off-by: Pekka Paalanen --- src/connection.c|7 +

[PATCH weston 1/3] compositor-wayland: Delay seat creation

We'll get a rash of seats added when we run our first wl_display_iterate across the parent display, but won't actually be ready to create them. Create a new global listener on our parent display for wl_seats only, and run that from wayland_input_create. Signed-off-by: Daniel Stone --- src/compos

[PATCH weston 2/3] Fix sessions with no active input devices

Fix a few unconditional dereferences of seat->keyboard and seat->pointer in paths that could be hit outside of input event processing. Reported-by: Pekka Paalanen Signed-off-by: Daniel Stone --- src/compositor.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src

[PATCH weston 3/3] Fix inverted LEDs

Turns out it's probably better to post the new state rather than the old. Signed-off-by: Daniel Stone --- src/compositor.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor.c b/src/compositor.c index 1383966..b904861 100644 --- a/src/compositor.c +++ b/src/com

[PATCH weston 0/3] Input fixups

Hi, These three patches fix a couple of issues from previous patchsets, including a crash in the nested Wayland compositor. Cheers, Daniel ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/