Re: [PATCH weston 08/10] xserver: treat tooltips differently from the others

2012-05-18 Thread Kristian Høgsberg
On Fri, May 18, 2012 at 06:47:15PM +0300, Tiago Vignatti wrote: > tooltips follows the pointer, whereas most of the other transient is surface > relative. > > Signed-off-by: Tiago Vignatti > --- > src/xserver-launcher.c | 31 --- > 1 file changed, 20 insertions(+),

Re: [PATCH weston 05/10] xserver: don't activate window always when mapping

2012-05-18 Thread Kristian Høgsberg
On Fri, May 18, 2012 at 06:47:12PM +0300, Tiago Vignatti wrote: > set_window_id is the one responsible for mapping the window and the shell will > decide whether a surface needs to be activated or not. But not always at > MapNotify. That was causing ugly behavior on non-toplevel windows. You're ri

Re: [PATCH weston 06/10] xserver: remove unused code for the activate listener

2012-05-18 Thread Kristian Høgsberg
On Fri, May 18, 2012 at 06:47:13PM +0300, Tiago Vignatti wrote: > activate will always come with a valid surface, so this path never runs. Yes, but not all surfaces correspond to X windows. If the surface getting activated is a native wayland client, window is NULL and we (the X wm) need to take

Re: Western runs on Ubuntu 10.10 but displays a window with no content and error on console

2012-05-18 Thread Scott Moreau
> As suggested by you guys, I have upgraded my system to Ubuntu 11.10 and > now I am able to run weston and other clients (using wayland-build-0.85.sh). > (although I am not able to run Gtk3 clients as they are throwing errors) > Thanks a lot for your suggestion. So the root cause of the problem s

RE: Western runs on Ubuntu 10.10 but displays a window with no content and error on console

2012-05-18 Thread souvik.datta
Hello Scott, Hello Darxus, As suggested by you guys, I have upgraded my system to Ubuntu 11.10 and now I am able to run weston and other clients (using wayland-build-0.85.sh). (although I am not able to run Gtk3 clients as they are throwing errors) Thanks a lot for your suggestion. So the root c

[PATCH 4/4] compositor: handle YUV buffers.

2012-05-18 Thread Gwenole Beauchesne
Signed-off-by: Gwenole Beauchesne --- src/compositor-wayland.c |2 +- src/compositor.c | 78 - src/compositor.h |2 +- 3 files changed, 64 insertions(+), 18 deletions(-) diff --git a/src/compositor-wayland.c b/src/compositor-w

[PATCH 3/4] compositor: add YUV shaders.

2012-05-18 Thread Gwenole Beauchesne
Add shaders for NV12 (2 planes) and YUV (3 planes). Signed-off-by: Gwenole Beauchesne --- src/compositor.c | 43 +++ src/compositor.h |2 ++ 2 files changed, 45 insertions(+), 0 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 27d

[PATCH 2/4] compositor: factor out RGB shader.

2012-05-18 Thread Gwenole Beauchesne
Simplify RGB shader code and split off common code that could be reused. This is preparatory work for YUV shaders. Signed-off-by: Gwenole Beauchesne --- src/compositor-wayland.c |2 +- src/compositor.c | 54 - src/compositor.h |

[PATCH 1/4] compositor: prepare for multi-planar surfaces.

2012-05-18 Thread Gwenole Beauchesne
Make weston_surface::texture and ::surface an array, while keeping [0] for RGB surfaces. Signed-off-by: Gwenole Beauchesne --- src/compositor-drm.c |8 ++-- src/compositor.c | 87 +++--- src/compositor.h |6 ++- 3 files changed, 69 in

[PATCH 3/3] shm: fill in base buffer layout.

2012-05-18 Thread Gwenole Beauchesne
Signed-off-by: Gwenole Beauchesne --- src/wayland-shm.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/wayland-shm.c b/src/wayland-shm.c index 7900ba1..020d09b 100644 --- a/src/wayland-shm.c +++ b/src/wayland-shm.c @@ -88,10 +88,14 @@ shm_pool_create_buffer(struc

[PATCH 2/3] buffer: add layout information.

2012-05-18 Thread Gwenole Beauchesne
Define useful information to pixel buffers so that to determine their format and how they are organized: line stride in bytes for each plane, and offset from base buffer to the corresponding plane. Signed-off-by: Gwenole Beauchesne --- src/wayland-util.c | 67 ++

[PATCH 1/3] buffer: add generic buffer formats.

2012-05-18 Thread Gwenole Beauchesne
Add packed RGB (ARGB32, XRGB32), and planar YUV formats with interleaved U/V components (NV12), or three Y U V planes with various subsampling (YUV 4:1:0, 4:1:1, 4:2:0, 4:2:2, 4:4:4). Signed-off-by: Gwenole Beauchesne --- protocol/wayland.xml | 24 src/wayland-server.h

[PATCH weston 10/10] xserver: send input focus only for top-level windows

2012-05-18 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti --- src/xserver-launcher.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/src/xserver-launcher.c b/src/xserver-launcher.c index e557b8f..b0fe54e 100644 --- a/src/xserver-launcher.c +++ b/src/xserver-launcher.c @@ -667,6 +667,12 @@ static void weston_wm

[PATCH weston 09/10] xserver: add support for popup windows

2012-05-18 Thread Tiago Vignatti
Quite nice, we don't need our internal logic to grab the pointer cause the X server does already it for us. Signed-off-by: Tiago Vignatti --- src/xserver-launcher.c |8 1 file changed, 8 insertions(+) diff --git a/src/xserver-launcher.c b/src/xserver-launcher.c index 2cf5d1f..e557b

[PATCH weston 08/10] xserver: treat tooltips differently from the others

2012-05-18 Thread Tiago Vignatti
tooltips follows the pointer, whereas most of the other transient is surface relative. Signed-off-by: Tiago Vignatti --- src/xserver-launcher.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/src/xserver-launcher.c b/src/xserver-launcher.c

[PATCH weston 07/10] compositor: hook xserver transient windows with shell_interface

2012-05-18 Thread Tiago Vignatti
I cared about tooltip type of windows on this commit. I also marked by default all non-toplevel windows as inactive, which in general gives a better experience. Signed-off-by: Tiago Vignatti --- src/compositor.h |3 +++ src/shell.c| 21 +++-- src/xserver-l

[PATCH weston 06/10] xserver: remove unused code for the activate listener

2012-05-18 Thread Tiago Vignatti
activate will always come with a valid surface, so this path never runs. Signed-off-by: Tiago Vignatti --- src/xserver-launcher.c |5 - 1 file changed, 5 deletions(-) diff --git a/src/xserver-launcher.c b/src/xserver-launcher.c index 838530d..f785508 100644 --- a/src/xserver-launcher.c

[PATCH weston 05/10] xserver: don't activate window always when mapping

2012-05-18 Thread Tiago Vignatti
set_window_id is the one responsible for mapping the window and the shell will decide whether a surface needs to be activated or not. But not always at MapNotify. That was causing ugly behavior on non-toplevel windows. Signed-off-by: Tiago Vignatti --- src/xserver-launcher.c |4 1 file

[PATCH weston 04/10] clients: desktop-shell: show tooltip for panel items

2012-05-18 Thread Tiago Vignatti
A timer is set whenever there's pointer motion inside a panel launcher item; if the pointer stills inside the item after stopped for 500ms, then tooltip shows up. Signed-off-by: Tiago Vignatti --- clients/desktop-shell.c | 81 +++ 1 file changed, 81

[PATCH weston 03/10] window: add simple text tooltip handlers

2012-05-18 Thread Tiago Vignatti
Using set_transient. Signed-off-by: Tiago Vignatti --- clients/window.c | 86 ++ clients/window.h |6 2 files changed, 92 insertions(+) diff --git a/clients/window.c b/clients/window.c index 5c4d28b..fe7abe7 100644 --- a/clients/win

[PATCH weston 02/10] window: send transient flags over the wire

2012-05-18 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti --- clients/window.c |4 ++-- clients/window.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/clients/window.c b/clients/window.c index d7b2e5c..5c4d28b 100644 --- a/clients/window.c +++ b/clients/window.c @@ -2695,7 +2695,7 @@ window_c

[PATCH weston 01/10] shell: use transient flags for activate or not new surfaces

2012-05-18 Thread Tiago Vignatti
Inactive surfaces doesn't set keyboard focus, so it can be used for tooltips, toolbars and some other type of windows. This requires protocol side changes. Signed-off-by: Tiago Vignatti --- src/shell.c |5 + 1 file changed, 5 insertions(+) diff --git a/src/shell.c b/src/shell.c index f

[PATCH wayland] protocol: use transient flags for activate or not surfaces

2012-05-18 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti --- TODO |3 --- protocol/wayland.xml | 13 +++-- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/TODO b/TODO index c8dcbac..4e8002d 100644 --- a/TODO +++ b/TODO @@ -63,9 +63,6 @@ ICCCM recommended types for text or i

transient surfaces for xwayland and tooltip love (v2)

2012-05-18 Thread Tiago Vignatti
I updated the patches now, rebased with the upstream tip and solved a bunch of the issues for surface mapping, in a way that most type of windows are working nicely. My main testing bed was Firefox, xterm, gtk3-demo and gtk3-demo-application. Firefox looks very cool now and for instance all the bas

Re: [PATCH] compositor: Silence compiler warning by declaring resource inside loop

2012-05-18 Thread Kristian Høgsberg
On Fri, May 18, 2012 at 02:13:03PM +0100, Rob Bradford wrote: > From: Rob Bradford > > Although resource will be valid when it is used since the entered and left > masks are subsets of the different mask it would be nice not to have a > spurious compiler warning. That's odd, I stopped getting th

[PATCH] compositor: Silence compiler warning by declaring resource inside loop

2012-05-18 Thread Rob Bradford
From: Rob Bradford Although resource will be valid when it is used since the entered and left masks are subsets of the different mask it would be nice not to have a spurious compiler warning. --- src/compositor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/compo

RE: Western runs on Ubuntu 10.10 but displays a window with no content and error on console

2012-05-18 Thread souvik.datta
Thanks Scott. I have started my upgrade process to 11.10. I will repeat these steps on the upgraded setup. Will soon post my results. Best Regards, Souvik From: Scott Moreau [ore...@gmail.com] Sent: Friday, May 18, 2012 1:22 PM To: Souvik Datta (WT01 - PE

Re: Western runs on Ubuntu 10.10 but displays a window with no content and error on console

2012-05-18 Thread Scott Moreau
Hi Souvik, I've been trying to think what could possibly be wrong with your setup. The gpu you're using should work, the userspace code from master is known to work. The only thing I can figure is that your kernel may be too old. You might consider trying an updated version of ubuntu which will hav