Re: [PATCH] use magic wl_fixed_t to/from double only on x86-64

2012-05-16 Thread Thiago Macieira
On quarta-feira, 16 de maio de 2012 11.20.03, Bill Spitzak wrote: > Thiago Macieira wrote: > > However, the div and mul are much more interesting. Those ought to be the > > same, so I am actually wondering how it is possible that the div and mul > > on > > x86-64 can be so slow. > > Divide by x and

Re: [PATCH 1/2] Convert wl_input_device to wl_seat et al

2012-05-16 Thread Kristian Høgsberg
On Wed, May 16, 2012 at 1:44 PM, Daniel Stone wrote: > Hi, > The following two patches (one each for Wayland and Weston) convert > wl_input_device to a mix of a parent wl_seat interface, as well as > subinterfaces for each of the pointer, keyboard and touch classes. > > Each wl_seat may have zero

Re: [PATCH] use magic wl_fixed_t to/from double only on x86-64

2012-05-16 Thread Bill Spitzak
Thiago Macieira wrote: However, the div and mul are much more interesting. Those ought to be the same, so I am actually wondering how it is possible that the div and mul on x86-64 can be so slow. Divide by x and multiply by 1/x are not exactly the same because 1/x may not be exactly represen

[PATCH wayland] Convert wl_input_device to wl_seat (and friends)

2012-05-16 Thread Daniel Stone
wl_input_device has been both renamed and split. wl_seat is now a virtual object representing a group of logically related input devices with related focus. It now only generates one event: to let clients know that it has new capabilities. It takes requests which hand back objects for the wl_poi

[PATCH 1/2] Convert wl_input_device to wl_seat et al

2012-05-16 Thread Daniel Stone
Hi, The following two patches (one each for Wayland and Weston) convert wl_input_device to a mix of a parent wl_seat interface, as well as subinterfaces for each of the pointer, keyboard and touch classes. Each wl_seat may have zero or one wl_{pointer,keyboard,touch} classes, which are announced d

Re: [PATCH weston v3] Convert wl_fixed_t to int in weston_output_update_zoom().

2012-05-16 Thread Kristian Høgsberg
On Wed, May 16, 2012 at 08:36:42AM -0600, Scott Moreau wrote: > This way, we don't have to use wl_fixed_to_int() for each > call to weston_output_update_zoom(). It accepts wl_fixed_t > types and converts internally. > --- > > Changed arg names and declare x/y as int32_t types since we > treat wl_f

[PATCH weston v3] Convert wl_fixed_t to int in weston_output_update_zoom().

2012-05-16 Thread Scott Moreau
This way, we don't have to use wl_fixed_to_int() for each call to weston_output_update_zoom(). It accepts wl_fixed_t types and converts internally. --- Changed arg names and declare x/y as int32_t types since we treat wl_fixed_t as it's own type. src/compositor.c |6 +- src/shell.c

[PATCH weston v2] Convert wl_fixed_t to int in weston_output_update_zoom().

2012-05-16 Thread Scott Moreau
This way, we don't have to use wl_fixed_to_int() for each call to weston_output_update_zoom(). It accepts wl_fixed_t types and converts internally. --- I see what you're saying now, thanks Ander. Changed weston_output_update_zoom() to accept wl_fixed_t types so it's clear how it's meant to be use

Re: [PATCH weston] Use wl_fixed_to_int() in weston_output_update_zoom().

2012-05-16 Thread Ander Conselvan de Oliveira
On 05/16/2012 04:37 PM, Scott Moreau wrote: On 05/16/2012 02:18 AM, Scott Moreau wrote: This way, we don't have to use wl_fixed_to_int() for each call to weston_output_update_zoom(). The instance in notify_motion() was missed, which broke zoom. ---

Re: [PATCH weston] Use wl_fixed_to_int() in weston_output_update_zoom().

2012-05-16 Thread Scott Moreau
> On 05/16/2012 02:18 AM, Scott Moreau wrote: > >> This way, we don't have to use wl_fixed_to_int() for >> each call to weston_output_update_zoom(). The instance >> in notify_motion() was missed, which broke zoom. >> --- >> src/compositor.c |3 +++ >> src/shell.c |4 +--- >> 2 files c

Re: [PATCH] use magic wl_fixed_t to/from double only on x86-64

2012-05-16 Thread Pavel Vasin
> on x86: > benchmarked magic: 14.048889885s > benchmarked div:5.426952392s > benchmarked mul:4.034106976s > > on x86-64: > benchmarked magic: 2.467789582s > benchmarked div:9.748067755s > benchmarked mul:8.665307997s > Did you compile your 32-bit code wit

Re: [PATCH] use magic wl_fixed_t to/from double only on x86-64

2012-05-16 Thread Thiago Macieira
On quarta-feira, 16 de maio de 2012 13.34.42, Pavel Vasin wrote: > on x86: > benchmarked magic: 14.048889885s > benchmarked div:5.426952392s > benchmarked mul:4.034106976s > > on x86-64: > benchmarked magic: 2.467789582s > benchmarked div:9.748067755s > benchmarked

[PATCH] use magic wl_fixed_t to/from double only on x86-64

2012-05-16 Thread Pavel Vasin
My results on Intel(R) Core(TM)2 Duo CPU T5800 @ 2.00GHz on x86: benchmarked magic: 14.048889885s benchmarked div:5.426952392s benchmarked mul:4.034106976s on x86-64: benchmarked magic: 2.467789582s benchmarked div:9.748067755s benchmarked mul:8.6653

Re: [PATCH weston] window: allow changing cursor theme and size

2012-05-16 Thread Pekka Paalanen
On Wed, 16 May 2012 10:03:55 +0100 Daniel Stone wrote: > Hi, > > On 16 May 2012 08:21, Pekka Paalanen wrote: > > On Tue, 15 May 2012 11:09:36 -0400 > > Kristian Høgsberg wrote: > >> Right, we only parse that in the desktop-shell client.  I don't know > >> then, maybe we should go back to shipp

Re: [PATCH weston] window: allow changing cursor theme and size

2012-05-16 Thread Daniel Stone
Hi, On 16 May 2012 08:21, Pekka Paalanen wrote: > On Tue, 15 May 2012 11:09:36 -0400 > Kristian Høgsberg wrote: >> Right, we only parse that in the desktop-shell client.  I don't know >> then, maybe we should go back to shipping a cursor theme with weston >> that we can fall back on if loading f

Re: [PATCH weston] Use wl_fixed_to_int() in weston_output_update_zoom().

2012-05-16 Thread Ander Conselvan de Oliveira
On 05/16/2012 02:18 AM, Scott Moreau wrote: This way, we don't have to use wl_fixed_to_int() for each call to weston_output_update_zoom(). The instance in notify_motion() was missed, which broke zoom. --- src/compositor.c |3 +++ src/shell.c |4 +--- 2 files changed, 4 insertions

Re: Comment on Wayland anti-FUD

2012-05-16 Thread Peter Hutterer
On Wed, May 16, 2012 at 10:10:37AM +0300, Pekka Paalanen wrote: > On Wed, 16 May 2012 11:39:06 +1000 > Peter Hutterer wrote: > > > On Sat, May 12, 2012 at 01:16:38PM +0300, Pekka Paalanen wrote: > > > > [snip] > > > ... > > > You are right about input plugins, but there are couple things > > >

Re: [PATCH weston] window: allow changing cursor theme and size

2012-05-16 Thread Pekka Paalanen
On Tue, 15 May 2012 11:09:36 -0400 Kristian Høgsberg wrote: > On Tue, May 15, 2012 at 09:21:37AM +0300, Pekka Paalanen wrote: > > On Mon, 14 May 2012 14:39:39 -0400 > > Kristian Høgsberg wrote: > > > > > On Mon, May 14, 2012 at 9:59 AM, Kristian Høgsberg > > > wrote: > > > > On Mon, May 14, 2

Re: Comment on Wayland anti-FUD

2012-05-16 Thread Pekka Paalanen
On Wed, 16 May 2012 11:39:06 +1000 Peter Hutterer wrote: > On Sat, May 12, 2012 at 01:16:38PM +0300, Pekka Paalanen wrote: > > [snip] > ... > > You are right about input plugins, but there are couple things > > that should make it not so bad: > > - a majority of input devices are evdev, so we m