Re: [PATCH] wayland: fix crash when /usr/share/wayland/left_ptr.png is not available

2012-05-07 Thread Scott Moreau
On Mon, May 7, 2012 at 2:46 PM, Kristian Høgsberg wrote: > On Sat, May 05, 2012 at 06:37:18PM -0700, Shawn Landden wrote: > > What we really need here is to make GTK+ use libXcursor as well, as it > is it relies on the cursors weston used to install. Any takers? > > Kristian Basically, this co

Re: libXcursor and its dependencies

2012-05-07 Thread Kristian Høgsberg
On Mon, May 7, 2012 at 5:57 PM, Andrew Guertin wrote: > There's been a bunch of talk recently about libXcursor and its > (potentially unneeded) dependencies. There was some talk about splitting > it up, and/or creating a libwlcursor. I looked into this a bit, and > found the following: > > Every f

Re: [PATCH 1/4] Port Wayland clients to new xkbcommon API

2012-05-07 Thread Bill Spitzak
Kristian Høgsberg wrote: The original code tests that shift and control are pressed, but it really should test modifers == SHIFT | CONTROL, that is, that those and *only* those modifiers are down. Watch out that this is only testing what the user thinks of as modifiers. I did this and was bur

Re: transient surfaces for xwayland and tooltip love

2012-05-07 Thread Bill Spitzak
Tiago Vignatti wrote: Hi, I stumbled on the problem of transient surfaces for xwayland. So I first checked tooltip type of windows and decided to create these for toytoolkit as well, so now we have a way to test the transient's on it as well. Probably the most important on this set is how we'

libXcursor and its dependencies

2012-05-07 Thread Andrew Guertin
There's been a bunch of talk recently about libXcursor and its (potentially unneeded) dependencies. There was some talk about splitting it up, and/or creating a libwlcursor. I looked into this a bit, and found the following: Every function in the api (in Xcursor.h) falls into one of two categories

Re: [PATCH weston 2/8] shell: use own struct for transient surfaces

2012-05-07 Thread Kristian Høgsberg
On Mon, May 07, 2012 at 03:23:08PM +0300, Tiago Vignatti wrote: > No functional changes; it's only opening space for modifications coming along > on the next commits. Looks fine. Kristian > Signed-off-by: Tiago Vignatti > --- > src/shell.c | 12 > 1 file changed, 8 insertions(+),

Re: [PATCH weston 1/8] shell: fix uninitialized variable warning

2012-05-07 Thread Kristian Høgsberg
On Mon, May 07, 2012 at 03:23:07PM +0300, Tiago Vignatti wrote: > and shut-up valgrind: > Conditional jump or move depends on uninitialised value(s) > at 0xB5AFB05: shell_surface_configure (shell.c:2162) > by 0x407B0C: surface_attach (compositor.c:1225) > by 0x621FA13: ffi_call_unix64

Re: [PATCH xwayland 1/3] configure: fallback to wlshm in case of xwayland

2012-05-07 Thread Kristian Høgsberg
On Mon, May 07, 2012 at 03:04:57PM +0300, Tiago Vignatti wrote: > If it doesn't find the proper driver for a chipset then it fallback to the shm > solution. > > But say we have intel and wlshm drivers then it will load both, short-circuit > somewhere and fail to bring xwayland properly. Therefore,

Re: [PATCH] wayland: fix crash when /usr/share/wayland/left_ptr.png is not available

2012-05-07 Thread Kristian Høgsberg
On Sat, May 05, 2012 at 06:37:18PM -0700, Shawn Landden wrote: What we really need here is to make GTK+ use libXcursor as well, as it is it relies on the cursors weston used to install. Any takers? Kristian > Signed-off-by: Shawn Landden > --- > gdk/wayland/gdkdevice-wayland.c |3 +++ > 1

Re: [PATCH] Weston: window.c: Frame buttons

2012-05-07 Thread Kristian Høgsberg
On Fri, May 04, 2012 at 02:34:24PM +0200, Martin Minarik wrote: > Thanks for all the feedback. > We are adding frame buttons to wl_list, as suggested by vignatti. I'm still getting this through squirrelmail which breaks the newlines. Can you resend with git send-email? The patch looks good, but c

Re: [PATCH 3/4] Link compositors to xkbcommon as well

2012-05-07 Thread Kristian Høgsberg
On Tue, May 01, 2012 at 08:37:11PM +0100, Daniel Stone wrote: > Signed-off-by: Daniel Stone I edited this one to just add xkbcommon to the COMPOSITOR pkg-config check. It's good practice to bundle as many pkgs into the pkg-config call so we can inform the user of as many missing pgs upfront as p

Re: [PATCH 2/4] Add xkb_names member plus config + X11 support

2012-05-07 Thread Kristian Høgsberg
On Mon, May 07, 2012 at 04:05:27PM -0400, Kristian Høgsberg wrote: > On Tue, May 01, 2012 at 08:37:10PM +0100, Daniel Stone wrote: > > Add an xkb_names member to the base compositor info which contains the > > RMLVO to use when building an XKB keymap. Add support for filling this > > from the conf

Re: [PATCH 2/4] Add xkb_names member plus config + X11 support

2012-05-07 Thread Kristian Høgsberg
On Tue, May 01, 2012 at 08:37:10PM +0100, Daniel Stone wrote: > Add an xkb_names member to the base compositor info which contains the > RMLVO to use when building an XKB keymap. Add support for filling this > from the config file or from the underlying X11 server, with the usual > defaults. I th

Re: [PATCH 1/4] Port Wayland clients to new xkbcommon API

2012-05-07 Thread Kristian Høgsberg
On Tue, May 01, 2012 at 08:37:09PM +0100, Daniel Stone wrote: > Signed-off-by: Daniel Stone > --- > clients/eventdemo.c |5 ++- > clients/terminal.c | 33 ++ > clients/window.c| 96 > +++ > clients/window.h|9 ++

Re: [PATCH] window: use only one shm pool for all the cursor images

2012-05-07 Thread Kristian Høgsberg
On Mon, May 7, 2012 at 2:34 PM, Ander Conselvan de Oliveira wrote: > Cursor images are fairly small and having one pool for each image adds > a lot of unnecessary overhead. Instead, create one large pool and > allocated all cursor images from that. > > In order to do that, however, the code that c

[PATCH] window: use only one shm pool for all the cursor images

2012-05-07 Thread Ander Conselvan de Oliveira
Cursor images are fairly small and having one pool for each image adds a lot of unnecessary overhead. Instead, create one large pool and allocated all cursor images from that. In order to do that, however, the code that creates shm surface needed some refactoring. This patch adds a new struct shm_

Re: Various clients crashing when hovered

2012-05-07 Thread darxus
On 05/07, Ander Conselvan de Oliveira wrote: > On 05/06/2012 08:01 PM, nerdopolis wrote: > >I noticed that [...] the default Weston clients are recently crashing due to > >a new patch > > [...] > > >switching weston to the patch before this patch > >http://cgit.freedesktop.org/wayland/wayland- >

Re: Various clients crashing when hovered

2012-05-07 Thread Ander Conselvan de Oliveira
On 05/06/2012 08:01 PM, nerdopolis wrote: I noticed that [...] the default Weston clients are recently crashing due to a new patch [...] switching weston to the patch before this patch http://cgit.freedesktop.org/wayland/wayland- demos/commit/?id=1493d2ae1cc8187684bb8f8939d0ec0335ed60f8 fixes

Re: [PATCH weston v3 5/8] Rename 'state' in axis (or ambiguous) bindings to 'value'

2012-05-07 Thread Kristian Høgsberg
On Fri, May 04, 2012 at 11:21:57AM +0100, Daniel Stone wrote: > Since it's usually an axis value rather than a boolean, be slightly more > explicit about it. Oh, yeah, that was bad. Applied. Kristian > Signed-off-by: Daniel Stone > --- > src/compositor.h |8 +--- > src/shell.c |

Re: [PATCH weston v3 4/8] Rename 'state' for key/button to 'is_down'

2012-05-07 Thread Kristian Høgsberg
On Fri, May 04, 2012 at 11:21:56AM +0100, Daniel Stone wrote: > Since it's just a boolean indicating whether or not the key is down, and > state is such a hopelessly overloaded word. And, er, XKB uses it quite > pervasively for modifier/group information. Skipping this one. We'll do the state en

Re: [PATCH weston v3 3/8] Change button from int to uint32_t

2012-05-07 Thread Kristian Høgsberg
On Fri, May 04, 2012 at 11:21:55AM +0100, Daniel Stone wrote: > Since you can't really have a negative button number. Applied, thanks. Kristian > Signed-off-by: Daniel Stone > --- > clients/clickdot.c |2 +- > clients/desktop-shell.c |6 +++--- > clients/dnd.c |2 +- >

Re: [PATCH weston v3 2/8] Change key/button grab bindings to take unsigned state

2012-05-07 Thread Kristian Høgsberg
On Fri, May 04, 2012 at 11:21:54AM +0100, Daniel Stone wrote: > 'state' here meaning 'is it up or down?', obviously. Applied. As we discussed in IRC, we'll use an pressed/released/repeating enum here instead, and as such the uint32_t will match what the protocol does. Kristian > Signed-off-by:

Re: [PATCH wayland v3 2/5] Use unsigned for key/button up/down state in grabs

2012-05-07 Thread Kristian Høgsberg
On Fri, May 04, 2012 at 11:21:20AM +0100, Daniel Stone wrote: > Since we just use it as a simple boolean flag, might as well convert it > to unsigned. Yup, committed. Kristian > Signed-off-by: Daniel Stone > --- > src/data-device.c|2 +- > src/wayland-server.c |4 ++-- > src/wayland

Re: [PATCH wayland v3 4/5] Add support for signed 24.8 decimal numbers

2012-05-07 Thread Kristian Høgsberg
On Fri, May 04, 2012 at 11:21:22AM +0100, Daniel Stone wrote: > signed_24_8 is a signed decimal type which offers a sign bit, 23 bits of > integer precision, and 8 bits of decimal precision. This is converted > to double on the C API side, as passing through varargs involves an > implicit type pro

Re: Migration guide?

2012-05-07 Thread Gregory Merchan
On Mon, May 7, 2012 at 9:51 AM, Kristian Høgsberg wrote: > On Sun, May 6, 2012 at 4:30 PM, Gregory Merchan Thanks for the answers! To answer your questions: >> 3. X11 famously abided by the rule of determining "mechanism, not >> policy". Is there a similar rule for Wayland? > > To some extent. T

Re: [PATCH weston v3 1/8] test-client: Include poll.h to silence warning

2012-05-07 Thread Kristian Høgsberg
On Fri, May 04, 2012 at 11:21:53AM +0100, Daniel Stone wrote: > Signed-off-by: Daniel Stone > --- > tests/test-client.c |1 + > 1 file changed, 1 insertion(+) Right, thanks. The poll is obviously a hack, but at least now it wont spam the compile log. Kristian > v3: New. > > diff --git a/

Re: Migration guide?

2012-05-07 Thread Kristian Høgsberg
On Sun, May 6, 2012 at 4:30 PM, Gregory Merchan wrote: > Hi, > > I looking for a migration guide from X11 to Wayland. Most of my Google > search results are real estate listings for properties with windows in > Wayland, MA. > > I have just a few things I hope someone will help me with: > > 1. The

Re: [PATCH xwayland 2/3] xwayland: give axis basic support

2012-05-07 Thread Daniel Stone
Hi, On 7 May 2012 14:49, Tiago Vignatti wrote: > On 05/07/2012 04:00 PM, Daniel Stone wrote: >> On 7 May 2012 13:04, Tiago Vignatti  wrote: >>> A remark about the "funny" X server's interface, that has to be called >>> twice >>> for queuing up events. Anyways, now I got Firefox with scrolling<3 >

Re: [PATCH xwayland 3/3] xwayland: fix pointer enter/leave

2012-05-07 Thread Kristian Høgsberg
On Mon, May 07, 2012 at 03:04:59PM +0300, Tiago Vignatti wrote: Thanks, that looks better. Kristian > Signed-off-by: Tiago Vignatti > --- > hw/xfree86/xwayland/xwayland-input.c | 16 ++-- > 1 file changed, 6 insertions(+), 10 deletions(-) > > diff --git a/hw/xfree86/xwayland/xwa

Re: [PATCH xwayland 2/3] xwayland: give axis basic support

2012-05-07 Thread Kristian Høgsberg
On Mon, May 07, 2012 at 03:04:58PM +0300, Tiago Vignatti wrote: > A remark about the "funny" X server's interface, that has to be called twice > for queuing up events. Anyways, now I got Firefox with scrolling <3 Looks good. The axis approach that Daniel describes sounds better, but I've pulled t

Re: [PATCH xwayland 2/3] xwayland: give axis basic support

2012-05-07 Thread Tiago Vignatti
On 05/07/2012 04:00 PM, Daniel Stone wrote: Hi, On 7 May 2012 13:04, Tiago Vignatti wrote: A remark about the "funny" X server's interface, that has to be called twice for queuing up events. Anyways, now I got Firefox with scrolling<3 Actually, if you set yourself up with a scroll axis, you

Re: Migration guide?

2012-05-07 Thread Gregory Merchan
Thank you! ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH xwayland 2/3] xwayland: give axis basic support

2012-05-07 Thread Daniel Stone
Hi, On 7 May 2012 13:04, Tiago Vignatti wrote: > A remark about the "funny" X server's interface, that has to be called twice > for queuing up events. Anyways, now I got Firefox with scrolling <3 Actually, if you set yourself up with a scroll axis, you only have to call it once rather than treat

[PATCH weston 7/8] shell: export shell_surface internal field via shell_interface

2012-05-07 Thread Tiago Vignatti
xserver submodule lacks visibility on shell_surface internals. In order to get shell_surface->weston_surface->geometries for the commit coming next, this is being introduced. It's a hack really. Another solution could be xserver access directly shell, but both are loaded modules without symbols be

[PATCH weston 6/8] clients: desktop-shell: show tooltip for panel items

2012-05-07 Thread Tiago Vignatti
A timer is set whenever there's pointer motion inside a panel launcher item; if the pointer stills inside the item after stopped for 500ms, then tooltip shows up. Signed-off-by: Tiago Vignatti --- clients/desktop-shell.c | 79 +++ 1 file changed, 79

[PATCH weston 1/8] shell: fix uninitialized variable warning

2012-05-07 Thread Tiago Vignatti
and shut-up valgrind: Conditional jump or move depends on uninitialised value(s) at 0xB5AFB05: shell_surface_configure (shell.c:2162) by 0x407B0C: surface_attach (compositor.c:1225) by 0x621FA13: ffi_call_unix64 by 0x621F434: ffi_call by 0x4E3D3F5: wl_closure_invoke (connection

[PATCH weston 8/8] compositor: hook xserver transient windows with shell_interface

2012-05-07 Thread Tiago Vignatti
In special, I cared about tooltip type of windows. Transient surfaces are, by the protocol, positioned surface relative to the upper left corner of the parent surface. So for tooltips, I needed to subtract the parent surface geometry in order to get the device's position, via a hacked interface. I

[PATCH wayland] protocol: use transient flags for activate or not surfaces

2012-05-07 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti --- TODO |3 --- protocol/wayland.xml | 13 +++-- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/TODO b/TODO index c64b39a..5d99b5d 100644 --- a/TODO +++ b/TODO @@ -80,9 +80,6 @@ ICCCM recommended types for text or i

transient surfaces for xwayland and tooltip love

2012-05-07 Thread Tiago Vignatti
Hi, I stumbled on the problem of transient surfaces for xwayland. So I first checked tooltip type of windows and decided to create these for toytoolkit as well, so now we have a way to test the transient's on it as well. Probably the most important on this set is how we'll decide the keyboard foc

[PATCH weston 5/8] window: add simple text tooltip handlers

2012-05-07 Thread Tiago Vignatti
Using set_transient. Signed-off-by: Tiago Vignatti --- clients/window.c | 84 ++ clients/window.h |6 2 files changed, 90 insertions(+) diff --git a/clients/window.c b/clients/window.c index 61713ca..b7d9a45 100644 --- a/clients/win

[PATCH weston 4/8] window: send transient flags over the wire

2012-05-07 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti --- clients/window.c |4 ++-- clients/window.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/clients/window.c b/clients/window.c index 2dcf421..61713ca 100644 --- a/clients/window.c +++ b/clients/window.c @@ -2294,7 +2294,7 @@ window_c

[PATCH weston 3/8] shell: use transient flags for activate or not new surfaces

2012-05-07 Thread Tiago Vignatti
Creating a surface inactive impacts in two different behaviors: not setting keyboard focus on the new surface and not re-stacking it below panel layer. Tooltips, dialogs and other kind of windows can benefit from this. This requires protocol side changes. Signed-off-by: Tiago Vignatti --- src/s

[PATCH weston 2/8] shell: use own struct for transient surfaces

2012-05-07 Thread Tiago Vignatti
No functional changes; it's only opening space for modifications coming along on the next commits. Signed-off-by: Tiago Vignatti --- src/shell.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/shell.c b/src/shell.c index 6f1ba81..e377120 100644 --- a/src/sh

[PATCH xwayland 2/3] xwayland: give axis basic support

2012-05-07 Thread Tiago Vignatti
A remark about the "funny" X server's interface, that has to be called twice for queuing up events. Anyways, now I got Firefox with scrolling <3 Signed-off-by: Tiago Vignatti --- hw/xfree86/xwayland/xwayland-input.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/xfree86/xwa

[PATCH xwayland 3/3] xwayland: fix pointer enter/leave

2012-05-07 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti --- hw/xfree86/xwayland/xwayland-input.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/hw/xfree86/xwayland/xwayland-input.c b/hw/xfree86/xwayland/xwayland-input.c index 79def3b..7cc7a1f 100644 --- a/hw/xfree86/xwayland/xwayl

[PATCH xwayland 1/3] configure: fallback to wlshm in case of xwayland

2012-05-07 Thread Tiago Vignatti
If it doesn't find the proper driver for a chipset then it fallback to the shm solution. But say we have intel and wlshm drivers then it will load both, short-circuit somewhere and fail to bring xwayland properly. Therefore, I believe this is not the ideal solution either. Signed-off-by: Tiago Vi

Re: Migration guide?

2012-05-07 Thread Pekka Paalanen
On Sun, 6 May 2012 15:30:19 -0500 Gregory Merchan wrote: > Hi, > > I looking for a migration guide from X11 to Wayland. Most of my Google > search results are real estate listings for properties with windows in > Wayland, MA. > > I have just a few things I hope someone will help me with: > > 1