Re: [PATCH 3/6] desktop-shell: split protocol part from shell_surface specific functions

On 04/16/2012 10:31 PM, Tiago Vignatti wrote: DE operations like toplevel, transiant, fullscreen, maximized, popup and the shell_surface constructor are the ones expected to be used in the global scope for Weston submodules like xserver-launcher and other shells. This commit split such procedur

Re: [PATCH 1/3] Install structuring for ping-pong protocol

> --- > clients/window.c |8 > src/compositor.c | 17 > src/compositor.h |2 + > src/shell.c | 114 > ++ > 4 files changed, 141 insertions(+), 0 deletions(-) > > diff --git a/clients/window.c b/clients/window.c > ind

Re: [PATCH 4/6] xserver: log locally

On Mon, Apr 16, 2012 at 05:31:43PM +0300, Tiago Vignatti wrote: > useful for weston on non-suid environments. I'm not sure about this one. We're just launching the X server, it needs to know how to start up and log in the right place. Kristian > Signed-off-by: Tiago Vignatti > --- > src/Makef

Re: [PATCH 5/6] compositor: init shell after xserver

On Mon, Apr 16, 2012 at 05:31:44PM +0300, Tiago Vignatti wrote: > This reverts a snip from commit d012e9df. On that commit, it was lost the > ability of calling X applications from desktop panel; xserver module > was setting DISPLAY only later, after panel was already launched. Ah, yes, makes sens

[PATCH 3/3] Dim unresponsive windows

If a client is not responding, lower the brightness and saturation to indicate it's stalled. The surface is restored to it's original color values if the client later becomes responsive. --- src/compositor.c |3 ++ src/compositor.h | 10 +++ src/shell.c | 71 ++

[PATCH 2/3] Install brightness and saturation variables for surface shader

--- src/compositor.c | 12 src/compositor.h |4 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 6ee9879..3667f39 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -217,6 +217,8 @@ weston_surface_create(struct w

[PATCH 1/3] Install structuring for ping-pong protocol

--- clients/window.c |8 src/compositor.c | 17 src/compositor.h |2 + src/shell.c | 114 ++ 4 files changed, 141 insertions(+), 0 deletions(-) diff --git a/clients/window.c b/clients/window.c index a033130..e79747b

[PATCH] protocol: Add ping event and corresponding pong request

--- TODO |4 protocol/wayland.xml | 16 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/TODO b/TODO index a7bdfd2..6fc8c87 100644 --- a/TODO +++ b/TODO @@ -103,10 +103,6 @@ EWMH just another wl_surface? Do we need this if we have the

Introduce ping event

This series introduces a ping event to check if clients are alive. It also introduces brightness and saturation for the surface shader. If a client has not responded to a ping when the timeout is reached, it is deemed unresponsive and fades the surface's brightness and saturation. The dimming is un

Re: [PATCH 2/6] desktop-shell: use more consistent name for the main structure

On Mon, Apr 16, 2012 at 05:31:41PM +0300, Tiago Vignatti wrote: > wl_shell is more likely to be used for core protocol specific. Now it follows > pretty much the same style of what tablet-shell is using. > > No functional changes. Yup, that looks better. Kristian > Signed-off-by: Tiago Vignatti

Re: [PATCH 1/6] desktop-shell: use description tags and improve protocol doc a bit

On Mon, Apr 16, 2012 at 05:31:40PM +0300, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti Ah, nice, thanks. Kristian > --- > protocol/desktop-shell.xml | 33 +++-- > 1 files changed, 23 insertions(+), 10 deletions(-) > > diff --git a/protocol/desktop-shell.x

Re: [PATCH 5/6] xwayland: follow wayland change to serial numbers

On Mon, Apr 16, 2012 at 05:31:50PM +0300, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti The input device attach request expects the enter event serial number for the window that currently has pointer focus. I made the change here and comitted. Kristian > --- > hw/xfree86/xwayland/xway

Re: [PATCH 4/6] xwayland: track shm pool protocol changes

On Mon, Apr 16, 2012 at 05:31:49PM +0300, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti Thanks, applied. What happened to 3/6? Kristian > --- > hw/xfree86/xwayland/xwayland-cursor.c |7 +-- > hw/xfree86/xwayland/xwayland.c|9 ++--- > 2 files changed, 11 inserti

Re: [PATCH 1/6] xwayland: use stub for wl_input_device_listener track the protocol

On Mon, Apr 16, 2012 at 05:31:46PM +0300, Tiago Vignatti wrote: > otherwise it segfaults. Thanks, applied. > Signed-off-by: Tiago Vignatti > --- > hw/xfree86/xwayland/xwayland-input.c | 72 > -- > 1 files changed, 68 insertions(+), 4 deletions(-) > > diff --g

Re: [PATCH 2/6] xwayland: remove rootless flag

Rootless tells the X server to show each toplevel window as a wayland surface. The default behavior is rooted, which just makes the root window a wayland surface. Both modes are useful. Kristian On Mon, Apr 16, 2012 at 10:31 AM, Tiago Vignatti wrote: > I can start a stand-alone xserver for deb

[PATCH 3/6] xwayland: insert a few comments about running path

Signed-off-by: Tiago Vignatti --- hw/xfree86/xwayland/xwayland-window.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/xwayland/xwayland-window.c b/hw/xfree86/xwayland/xwayland-window.c index 0f2a26f..6d1d7bf 100644 --- a/hw/xfree86/xwayland/xwayland-window.c

[PATCH 1/6] desktop-shell: use description tags and improve protocol doc a bit

Signed-off-by: Tiago Vignatti --- protocol/desktop-shell.xml | 33 +++-- 1 files changed, 23 insertions(+), 10 deletions(-) diff --git a/protocol/desktop-shell.xml b/protocol/desktop-shell.xml index 836b127..d2bb3eb 100644 --- a/protocol/desktop-shell.xml +++ b/prot

[PATCH 6/6] xwayland: don't race with weston

Signed-off-by: Tiago Vignatti --- hw/xfree86/xwayland/xwayland-window.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/xwayland/xwayland-window.c b/hw/xfree86/xwayland/xwayland-window.c index 6d1d7bf..f26e0a0 100644 --- a/hw/xfree86/xwayland/xwayland-wind

[PATCH 5/6] xwayland: follow wayland change to serial numbers

Signed-off-by: Tiago Vignatti --- hw/xfree86/xwayland/xwayland-cursor.c |2 +- hw/xfree86/xwayland/xwayland-input.c | 42 ++- hw/xfree86/xwayland/xwayland-private.h |3 +- 3 files changed, 27 insertions(+), 20 deletions(-) diff --git a/hw/xfree86/xwayland

[PATCH 4/6] xwayland: track shm pool protocol changes

Signed-off-by: Tiago Vignatti --- hw/xfree86/xwayland/xwayland-cursor.c |7 +-- hw/xfree86/xwayland/xwayland.c|9 ++--- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/xfree86/xwayland/xwayland-cursor.c b/hw/xfree86/xwayland/xwayland-cursor.c index e7ef

[PATCH 4/6] xserver: log locally

useful for weston on non-suid environments. Signed-off-by: Tiago Vignatti --- src/Makefile.am|2 +- src/xserver-launcher.c |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index f0150e8..4be869b 100644 --- a/src/Makefile.am ++

[PATCH 2/6] xwayland: remove rootless flag

I can start a stand-alone xserver for debugging and also spawn it directly via weston. I don't see an usage for this flags; is there any? Signed-off-by: Tiago Vignatti --- hw/xfree86/xwayland/xwayland-window.c | 12 +++- hw/xfree86/xwayland/xwayland.c|3 --- hw/xfree86/xway

[PATCH 1/6] xwayland: use stub for wl_input_device_listener track the protocol

otherwise it segfaults. Signed-off-by: Tiago Vignatti --- hw/xfree86/xwayland/xwayland-input.c | 72 -- 1 files changed, 68 insertions(+), 4 deletions(-) diff --git a/hw/xfree86/xwayland/xwayland-input.c b/hw/xfree86/xwayland/xwayland-input.c index 6ccc097..ea

[PATCH 6/6] compositor: introduce internal shell_surface helpers

We're able now to create shell_surfaces inside Weston. This makes possible the glue needed between shell and xserver-launcher. Signed-off-by: Tiago Vignatti --- src/compositor.h | 24 +++- src/shell.c|8 +--- src/xserver-launcher.c | 13 +

[PATCH 5/6] compositor: init shell after xserver

This reverts a snip from commit d012e9df. On that commit, it was lost the ability of calling X applications from desktop panel; xserver module was setting DISPLAY only later, after panel was already launched. Signed-off-by: Tiago Vignatti --- src/compositor.c |6 +++--- 1 files changed, 3 in

[PATCH 3/6] desktop-shell: split protocol part from shell_surface specific functions

DE operations like toplevel, transiant, fullscreen, maximized, popup and the shell_surface constructor are the ones expected to be used in the global scope for Weston submodules like xserver-launcher and other shells. This commit split such procedures into a part that handles the protocol request

[PATCH 2/6] desktop-shell: use more consistent name for the main structure

wl_shell is more likely to be used for core protocol specific. Now it follows pretty much the same style of what tablet-shell is using. No functional changes. Signed-off-by: Tiago Vignatti --- src/shell.c| 93 ++- src/tablet-shell.c |

[WIP] xwayland and shell refactoring

Hi, Please take a look now. I can map the X11 window (set top level), move it around (with key binding) and resources are created/destroyed properly. Pointer enter/leave are pretty bad still and that's what I plan to tackle next. Regarding the shell refactoring, I don't want to proceed much now c