Re: [WIP] xwayland fix

2012-04-03 Thread darxus
Thanks for working on this. I tried it, with all 6 of your patches applied, with xf86-video-wlshm and got /home/darxus/install/bin/Xorg: symbol lookup error: /home/darxus/install/lib/xorg/modules/extensions/libxwayland.so: undefined symbol: wl_shm_create_buffer That was with wayland commit aa7

GTK glitching

2012-04-03 Thread darxus
This is what gtk applications look like to me, in wayland/weston 0.85: http://www.chaosreigns.com/wayland/demos/2012-04-03-wayland-gtk-glitches.ogv That's with the radeon driver. I got at least the same effect with vte with the nouveau driver, I suspect the rest is the same also. I tried bisecti

Re: [PATCH 1/2] client: tablet-shell: fallback in the lack of lockscreen icon

2012-04-03 Thread Kristian Hoegsberg
On Wed, Mar 28, 2012 at 08:56:48PM +0300, Tiago Vignatti wrote: > lockscreen, homescreen and shell launchers are falling back okay already and > only lockscreen icon was missing some way to keep the shell client running in > the absence of images. This patch fix it. Thanks, comitted. Kristian > S

Re: [PATCH] Fix `unused-result' warnings.

2012-04-03 Thread Kristian Hoegsberg
On Fri, Mar 30, 2012 at 11:10:27PM +0200, Jonas Ådahl wrote: > Signed-off-by: Jonas Ådahl > --- > > This fixes all warnings using gcc 4.6.1. Thanks, applied. Kristian > clients/dnd.c |4 +++- > clients/window.c |4 +++- > shared/image-loader.c | 17 + > 3

Re: [PATCH 1/3] wayland-utils: add wl_list_for_each_reverse_safe macro.

2012-04-03 Thread Kristian Høgsberg
On Sun, Apr 1, 2012 at 8:13 AM, wrote: > From: Alex Wu These three look good, all merged. Kristian > Add the safe version for wl_list_for_each_reverse > --- >  src/wayland-util.h |    8 >  1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/src/wayland-util.h b/src/wayl

Re: [PATCH 5/6 xserver] xwayland: make more explicit root window creation path

2012-04-03 Thread Tiago Vignatti
On 04/03/2012 05:18 PM, Daniel Stone wrote: On 3 April 2012 14:58, Tiago Vignatti wrote: Just moving code around. No functional changes. Sorry, I'm not sure I really like this one, unless you're planning to add an else branch; even then, that might well be fodder for helper functions. The e

Re: about weston

2012-04-03 Thread Alberich de megres
Thanks for the clarifying :) On Mon, Apr 2, 2012 at 12:57 PM, Pekka Paalanen wrote: > On Sun, 1 Apr 2012 21:37:10 +0200 > Alberich de megres wrote: > >> Hi Guys, >> >> I was trying to understand how weston rpc works, and more specifically >> how it asks for painting. >> Checking the source i sa

Re: [PATCH 5/6 xserver] xwayland: make more explicit root window creation path

2012-04-03 Thread Daniel Stone
Hi, On 3 April 2012 14:58, Tiago Vignatti wrote: > Just moving code around. No functional changes. Sorry, I'm not sure I really like this one, unless you're planning to add an else branch; even then, that might well be fodder for helper functions. The early-return style is good not only at redu

Re: [PATCH] debug: print from where protocol message originated

2012-04-03 Thread Tiago Vignatti
On 03/28/2012 12:16 AM, Tiago Vignatti wrote: In times where Weston and client shells are started at the same time, this makes debugging much more effective. It's [S] for server and [C] for clients, so now you will see something like this: [4231274.870][C] -> wl_disp...@1.sync(new id 10) [4231

[WIP] xwayland fix

2012-04-03 Thread Tiago Vignatti
Hi, This is what I'm working to make the shell_surface glue with xserver WM in Weston. Basically the WM has to read the X window properties and communicate them that to wl_shell, which will map it correctly on Weston. Patches #2 and #6 are the ones interested, which care some review. For xwayland

[PATCH 6/6 xserver] xwayland: don't race with weston

2012-04-03 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti --- hw/xfree86/xwayland/xwayland-window.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/xwayland/xwayland-window.c b/hw/xfree86/xwayland/xwayland-window.c index 101ef01..019f452 100644 --- a/hw/xfree86/xwayland/xwayland-wind

[PATCH 5/6 xserver] xwayland: make more explicit root window creation path

2012-04-03 Thread Tiago Vignatti
Just moving code around. No functional changes. Signed-off-by: Tiago Vignatti --- hw/xfree86/xwayland/xwayland-window.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/hw/xfree86/xwayland/xwayland-window.c b/hw/xfree86/xwayland/xwayland-wi

[PATCH 4/6 xserver] xwayland: remove rootless flag

2012-04-03 Thread Tiago Vignatti
I can starting a stand-alone xserver for debugging and also spawning it normally via weston. Signed-off-by: Tiago Vignatti --- hw/xfree86/xwayland/xwayland-window.c | 12 +++- hw/xfree86/xwayland/xwayland.c|3 --- hw/xfree86/xwayland/xwayland.h|2 -- 3 files cha

[PATCH 3/6 xserver] xwayland: use stub for wl_input_device_listener

2012-04-03 Thread Tiago Vignatti
otherwise it segfaults Signed-off-by: Tiago Vignatti --- hw/xfree86/xwayland/xwayland-input.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/xwayland/xwayland-input.c b/hw/xfree86/xwayland/xwayland-input.c index 6ccc097..769e83f 10064

[PATCH 2/6 weston] xserver: glue it with shell_surface

2012-04-03 Thread Tiago Vignatti
Signed-off-by: Tiago Vignatti --- src/Makefile.am|4 +++- src/shell.c| 17 +++-- src/shell.h| 34 ++ src/xserver-launcher.c | 14 ++ 4 files changed, 66 insertions(+), 3 deletions(-) create mode 100

[PATCH 1/6 weston] xserver: log locally

2012-04-03 Thread Tiago Vignatti
useful for weston on non-suid environments. Signed-off-by: Tiago Vignatti --- src/xserver-launcher.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/xserver-launcher.c b/src/xserver-launcher.c index 502b9d4..4fda42f 100644 --- a/src/xserver-launcher.c +++ b/src/xserv

[PATCH 4/4] compositor: implement new pointer surfaces protocol

2012-04-03 Thread Ander Conselvan de Oliveira
--- clients/window.c | 10 ++- src/compositor-wayland.c |7 +- src/compositor.c | 267 ++ src/compositor.h |7 +- 4 files changed, 245 insertions(+), 46 deletions(-) diff --git a/clients/window.c b/clients/window.c ind

[PATCH 3/4] compositor: only update drag surfaces during output repaint

2012-04-03 Thread Ander Conselvan de Oliveira
Drag surfaces were being updated in notify_* so that the relative distance between the drag surface and the cursor hotspot was kept. Instead, store the offset on the input device and update on drag_surface_configure(), that way we can update its position only once per frame. --- src/compositor.c |

[PATCH 2/4] compositor: only update cursor sprite position on output repaint

2012-04-03 Thread Ander Conselvan de Oliveira
--- src/compositor.c | 29 +++-- src/compositor.h |2 ++ 2 files changed, 25 insertions(+), 6 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 1fce69a..3d70853 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -934,6 +934,7 @@ weston_output_r

[PATCH wayland] protocol: make pointer images regular surfaces

2012-04-03 Thread Ander Conselvan de Oliveira
Replace the input_device.attach request with a request for setting a pointer surface. Also add a new interface, wl_pointer_surface, that provides a request for setting the hotspot of a pointer surface. With this change, clients should be able to request frame callbacks for pointer surfaces in order

[PATCH v2 0/4] Cursor surfaces

2012-04-03 Thread Ander Conselvan de Oliveira
Hi, This is an updated version of the cursor surface patches I sent earlier. I changed the protocol a bit so that the set_hotspot request is not on the input_device but on a new interface, wl_pointer_surface. Also, some of the messy details of the previous patch were resolved using the new surface