[PATCH] compositor: Fix pick an incorrect surface due to dirty surface_list

2012-03-08 Thread zhiwen . wu
From: Alex Wu When a new toplevel window is activated and positioned under the cursor, the pointer focus still on the previous window. The botton event can not deliver to the new window. The root cause is that weston_surface_restack() change the surface stack but not update the weston_compositor:

Re: [RFC] compositor: Simple key repeat implementation

2012-03-08 Thread Bill Spitzak
Joakim Sindholt wrote: Any particular reason that this is in the server and not the toolkits? I'm of the persuasion that wayland should just function as a relay here. I think this is acceptable in the server. It is very important however that clients can always recover the "real" events, so i

Re: Patch for compositor-drm.c

2012-03-08 Thread Christopher Michael
On 03/08/2012 01:22 PM, Kristian Hoegsberg wrote: On Wed, Mar 07, 2012 at 03:00:04PM -0500, Christopher Michael wrote: Hi All, Attached is a patch which fixes some cleanup issues for the drm-based compositor. Basically, if we fail to allocate space for the crtcs in the compositor, then we need

Re: Patch for compositor-drm.c

2012-03-08 Thread Kristian Hoegsberg
On Wed, Mar 07, 2012 at 03:00:04PM -0500, Christopher Michael wrote: > Hi All, > > Attached is a patch which fixes some cleanup issues for the > drm-based compositor. Basically, if we fail to allocate space for > the crtcs in the compositor, then we need to free the drm mode > resources before exi

Re: [RFC] compositor: Simple key repeat implementation.

2012-03-08 Thread Joakim Sindholt
On Thu, 2012-03-08 at 16:10 +0100, Michael Hasselmann wrote: > On Thu, 2012-03-08 at 14:52 +0100, Joakim Sindholt wrote: > > On Wed, 2012-03-07 at 15:21 -0700, Scott Moreau wrote: > > > There's nothing fancy about this, we just set a timer and simulate > > > events using states 2 and 3 for repeat-u

Re: [PATCH] shell: don't assign output for surface of type none

2012-03-08 Thread Kristian Hoegsberg
On Mon, Mar 05, 2012 at 03:39:23PM +0200, Ander Conselvan de Oliveira wrote: > If map is called with a surface of type none it will call > weston_surface_assign_output, even though the surface will > not be mapped. > > This change was lost with the changes for using wl_layers. Oops, sorry. Appli

Re: [PATCH] shell: Fix segment fault when clicking to activate a NULL pointer_focus

2012-03-08 Thread Kristian Hoegsberg
On Mon, Mar 05, 2012 at 02:13:13PM +0800, zhiwen...@linux.intel.com wrote: > From: Alex Wu > > This can happen for instance running a toytoolkit application, launching > the popup menu and then clicking on a surface that does not belong to > the client that create the popup surface. Thanks. I a

Re: [RFC] compositor: Simple key repeat implementation.

2012-03-08 Thread Scott Moreau
On Thu, Mar 8, 2012 at 6:52 AM, Joakim Sindholt wrote: > On Wed, 2012-03-07 at 15:21 -0700, Scott Moreau wrote: > > There's nothing fancy about this, we just set a timer and simulate > > events using states 2 and 3 for repeat-up and repeat-down events. > > Any particular reason that this is in the

Re: Thread affinity

2012-03-08 Thread Andreas Ericsson
On 03/05/2012 01:14 PM, Jørgen Lind wrote: > Hi, > > I had some time today update the patch to add thread affinity to > wayland-clients wl_display. > Not that anyone else seem to have picked up this patch, but I've got some small issues with it even so. Code is copy-pasted back in (why attach?)

Re: [RFC] compositor: Simple key repeat implementation.

2012-03-08 Thread Michael Hasselmann
On Thu, 2012-03-08 at 14:52 +0100, Joakim Sindholt wrote: > On Wed, 2012-03-07 at 15:21 -0700, Scott Moreau wrote: > > There's nothing fancy about this, we just set a timer and simulate > > events using states 2 and 3 for repeat-up and repeat-down events. > > Any particular reason that this is in

Re: [RFC] compositor: Simple key repeat implementation.

2012-03-08 Thread Joakim Sindholt
On Wed, 2012-03-07 at 15:21 -0700, Scott Moreau wrote: > There's nothing fancy about this, we just set a timer and simulate > events using states 2 and 3 for repeat-up and repeat-down events. Any particular reason that this is in the server and not the toolkits? I'm of the persuasion that wayland

Re: [RFC] compositor: Simple key repeat implementation.

2012-03-08 Thread Michael Hasselmann
On Wed, 2012-03-07 at 15:35 -0700, Scott Moreau wrote: > > > On Wed, Mar 7, 2012 at 3:27 PM, Daniel Stone > wrote: > Hi, > > On 7 March 2012 22:21, Scott Moreau wrote: > > There's nothing fancy about this, we just set a timer and > simulate > > e

Re: [PATCH 3/3] shell: Implement "driver" method of fullsceen.

2012-03-08 Thread Pekka Paalanen
On Thu, 8 Mar 2012 16:45:22 +0800 "wuzhiwen" wrote: > Hi, > Thanks for your review, comments inlined. > >Does your implementation allow the compositor/shell to switch between > >mode-set and fallback fullscreen presentation at will? > >That's for the use cases we already discussed somewhere, lik

RE: [PATCH 3/3] shell: Implement "driver" method of fullsceen.

2012-03-08 Thread wuzhiwen
Hi, Thanks for your review, comments inlined. >-Original Message- >From: >wayland-devel-bounces+zhiwen.wu=linux.intel@lists.freedesktop.org >[mailto:wayland-devel-bounces+zhiwen.wu=linux.intel.com@lists.freedesktop.o >rg] On Behalf Of Pekka Paalanen >Sent: Wednesday, March 07, 2012 9:1