Re: [PATCH 1/2] shell: Add implementation of fullscreen.

2012-03-01 Thread Scott Moreau
> I will fix it in next version. > > > This version has already been pushed, so you probably just want to submit a patch to fix the issue on top of master. ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mai

RE: [PATCH 1/2] shell: Add implementation of fullscreen.

2012-03-01 Thread wuzhiwen
Hi, Thanks for your comments. You are right, this is a bug. The following code is meant to restore the initial position of a toplevel surface when it switch from a non-toplevel to toplevel. The problem is that (prev_surface_type != SHELL_SURFACE_TOPLEVEL) can not drop the buffer size changing c

Re: [PATCH 1/2] shell: Add implementation of fullscreen.

2012-03-01 Thread Scott Moreau
Specifically, this questionable call + } else if (!shsurf->saved_position_valid) { >> + weston_surface_set_position(surface, 10 + >> random() % 400, >> + 10 + random() >> % 400); >> +

Re: [PATCH 1/2] shell: Add implementation of fullscreen.

2012-03-01 Thread Scott Moreau
Hi. This patch introduces a bug where the window jumps all over the place when resizing it. I've tracked down the problem to the following code though I'm not sure I understand what it's meant to do yet exactly, so I figured I'd post a comment here. + case SHELL_SURFACE_TOPLEVEL: > +

Re: [PATCH 0/3] Resubmit - Unit test framework for Wayland

2012-03-01 Thread Kristian Høgsberg
Hi Artie, Thanks for starting this. Looks good and certainly when we start adding tests for some of the more complex objects and data structures in the library (wl_map would be a good next step), it will be a good way to avoid regressing functionality. I'm not convinced that we really need an ex

Re: [PATCH 6/6] Hack up distcheck for publican

2012-03-01 Thread Peter Hutterer
On Thu, Mar 01, 2012 at 10:32:28AM -0500, Gaetan Nadon wrote: > On 12-02-29 07:40 PM, Peter Hutterer wrote: > >> +# Copy the en_US source files into en-US destination > >> > +# This is required for out-of-source-tree build as publican does not > >> > allow us > >> > +# to specify the location of t

Re: [PATCH 6/6] Hack up distcheck for publican

2012-03-01 Thread Gaetan Nadon
On 12-02-29 07:40 PM, Peter Hutterer wrote: > I failed to figure out a sensible way to convince automake to install "every > file in this directory". Every instance I found on various forums yesterday > came down to the developer knowing the file list. I think having to maintain > the file list man

Re: [PATCH 0/6] Publican documentation integration

2012-03-01 Thread Peter Hutterer
On Thu, Mar 01, 2012 at 04:17:16PM -0500, Kristian Høgsberg wrote: > On Wed, Feb 29, 2012 at 1:46 PM, Kristian Hoegsberg > wrote: > > On Wed, Feb 29, 2012 at 12:57:28PM +1000, Peter Hutterer wrote: > >> > >> Branch available from > >> git://people.freedesktop.org/~whot/wayland.git :publican > >>

Re: [PATCH weston 5/5] compositor: split drag surface update into smaller functions

2012-03-01 Thread Kristian Hoegsberg
On Thu, Mar 01, 2012 at 02:09:45PM +0200, Ander Conselvan de Oliveira wrote: Thanks, applied. Kristian > --- > src/compositor.c | 58 +++-- > 1 files changed, 42 insertions(+), 16 deletions(-) > > diff --git a/src/compositor.c b/src/compositor.c

Re: [PATCH weston 4/5] compositor: fix crash when a drag surface is destroyed during the drag

2012-03-01 Thread Kristian Hoegsberg
On Thu, Mar 01, 2012 at 02:09:44PM +0200, Ander Conselvan de Oliveira wrote: > This can happen for instance if the client that started the drag > crashes. Weston would crash because of the invalid surface pointed by > device->drag_surface. Looks good, applied. Kristian > Fix this by reseting the

Re: [PATCH 0/6] Publican documentation integration

2012-03-01 Thread Kristian Høgsberg
On Wed, Feb 29, 2012 at 1:46 PM, Kristian Hoegsberg wrote: > On Wed, Feb 29, 2012 at 12:57:28PM +1000, Peter Hutterer wrote: >> >> Branch available from >> git://people.freedesktop.org/~whot/wayland.git :publican >> >> This adds a docbook tree hooked up to build with publican. Default make will >>

Re: [PATCH 2/3] Fix server crash when a client dies during a drag with an icon

2012-03-01 Thread Kristian Hoegsberg
On Thu, Mar 01, 2012 at 02:09:42PM +0200, Ander Conselvan de Oliveira wrote: > If a client dies during a drag that it started using an icon surface, > the server could crash because the icon surface is not valid anymore. > > Fix this by using a destroy listener to reset device->drag_surface to > n

Re: [PATCH 3/3] Terminate a drag if the origin surface is destroyed

2012-03-01 Thread Kristian Hoegsberg
On Thu, Mar 01, 2012 at 02:09:43PM +0200, Ander Conselvan de Oliveira wrote: This one I'm not sure about. Obviously if the source client goes away, we need to end the grab, but we only need the origin surface to verify that the client has an implicit grab. Once the drag is started I think it sho

Re: [PATCH 1/3] Fix wl_data_offer source destroy listener

2012-03-01 Thread Kristian Hoegsberg
On Thu, Mar 01, 2012 at 02:09:41PM +0200, Ander Conselvan de Oliveira wrote: > The listener function implementation was getting a wrong pointer to the > wl_data_offer object because the resource parameter is actually the > data source and not the data offer. Yeah, oops, good catch. Kristian > --

Re: [PATCH 6/6] Hack up distcheck for publican

2012-03-01 Thread Gaetan Nadon
On 12-02-29 07:40 PM, Peter Hutterer wrote: >> +# Copy the en_US source files into en-US destination >> > +# This is required for out-of-source-tree build as publican does not >> > allow us >> > +# to specify the location of the source code. >> > +$(builddir)/en-US/%: $(srcdir)/en_US/% $(builddir)

[PATCH 3/3] Terminate a drag if the origin surface is destroyed

2012-03-01 Thread Ander Conselvan de Oliveira
--- src/data-device.c| 57 -- src/wayland-server.h |1 + 2 files changed, 42 insertions(+), 16 deletions(-) diff --git a/src/data-device.c b/src/data-device.c index f0f6baa..184f2aa 100644 --- a/src/data-device.c +++ b/src/data-device.c @@

[PATCH weston 5/5] compositor: split drag surface update into smaller functions

2012-03-01 Thread Ander Conselvan de Oliveira
--- src/compositor.c | 58 +++-- 1 files changed, 42 insertions(+), 16 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 4b607d0..1281066 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -1915,6 +1915,42 @@ weston_input_de

[PATCH weston 4/5] compositor: fix crash when a drag surface is destroyed during the drag

2012-03-01 Thread Ander Conselvan de Oliveira
This can happen for instance if the client that started the drag crashes. Weston would crash because of the invalid surface pointed by device->drag_surface. Fix this by reseting the drag surface to nil on a destroy listener. --- src/compositor.c | 17 + src/compositor.h |1 +

[PATCH 2/3] Fix server crash when a client dies during a drag with an icon

2012-03-01 Thread Ander Conselvan de Oliveira
If a client dies during a drag that it started using an icon surface, the server could crash because the icon surface is not valid anymore. Fix this by using a destroy listener to reset device->drag_surface to nil when the surface is destroyed. --- src/data-device.c| 19 ++-

[PATCH 1/3] Fix wl_data_offer source destroy listener

2012-03-01 Thread Ander Conselvan de Oliveira
The listener function implementation was getting a wrong pointer to the wl_data_offer object because the resource parameter is actually the data source and not the data offer. --- src/data-device.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/data-device.c b/src

[PATCH 0/3] Several fixes for drag 'n' drop corner cases

2012-03-01 Thread Ander Conselvan de Oliveira
Hi, This series includes several bug fixes for drag and drop corner cases. A lot can go wrong if the client dies or one of the surfaces used is destroyed during the grab and we were not checking those cases properly. The first three patches are for libwayland-server and the others for weston. --