Sorry for jumping in...
On Mon, 27 Feb 2012 14:25:23 +0800
"wuzhiwen" wrote:
> >> shell_surface_set_fullscreen(struct wl_client *client, {
> >>struct shell_surface *shsurf = resource->data;
> >>struct weston_surface *es = shsurf->surface;
> >> - struct weston_output *output;
> >> + st
Hi khr,
Comments inlined.
>-Original Message-
>From:
>wayland-devel-bounces+zhiwen.wu=linux.intel@lists.freedesktop.org
>[mailto:wayland-devel-bounces+zhiwen.wu=linux.intel.com@lists.freedesktop.o
>rg] On Behalf Of Kristian Hoegsberg
>Sent: Monday, February 27, 2012 4:03 AM
>To: zhiwe
>-Original Message-
>From:
>wayland-devel-bounces+zhiwen.wu=linux.intel@lists.freedesktop.org
>[mailto:wayland-devel-bounces+zhiwen.wu=linux.intel.com@lists.freedesktop.o
>rg] On Behalf Of Kristian Hoegsberg
>Sent: Monday, February 27, 2012 3:36 AM
>To: zhiwen...@linux.intel.com
>Cc:
Thanks a lot for review!
Still have one question:
On 02/27/2012 04:02 AM, Kristian Hoegsberg wrote:
+ if (es->output) {
This is never true since reset_shell_surface_type() unmaps it. But
even when that is fixed, we can't change the surface position, size or
stacking until we receive the
On Sun, Feb 26, 2012 at 03:21:37PM +0800, zhiwen...@linux.intel.com wrote:
> From: Alex Wu
Nice. There are a few issues below and one thing I didn't figure out
right now was that when you raise a window over the fullscreen window
and then re-raise the fullscreen window, the black surface renders
On Sun, Feb 26, 2012 at 03:21:36PM +0800, zhiwen...@linux.intel.com wrote:
> From: Alex Wu
Looks ok, just one comment below.
Kristian
> This will facilitate the implementation of fullscreen.
> ---
> src/compositor.c |6 +++---
> src/compositor.h | 10 ++
> 2 files changed, 13 in
On Sat, Feb 25, 2012 at 12:56:32PM +0200, Ustun Ergenoglu wrote:
> From: Üstün Ergenoğlu
Yeah, that's better. Thanks.
Kristian
> Signed-off-by: Üstün Ergenoğlu
> ---
> src/wayland-util.h | 16
> 1 files changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/src/wayland
On Thu, Feb 23, 2012 at 10:28:37PM -0700, Scott Moreau wrote:
> This effectively eats the keybinding events, as we don't want them sent to
> clients.
Thanks, as discussed in irc, this is the right fix.
PS: Keep commit message lines under 78 characters.
Kristian
> ---
> src/shell.c | 60
