Re: [PATCH 5/7] shell: update position of surfaces with type none on map()

On Wed, 15 Feb 2012 17:02:56 +0200 Ander Conselvan de Oliveira wrote: > Needed for implementing drag'n'drop icons. When a drag starts, the > compositor will position the top-left corner of the client supplied > icon surface at the cursor hotspot. On the first attach to that > surface, the client

Re: [PATCH] [RFC]Shell: Hide panels when compositor has a top fullscreen surface.

On 02/16/2012 10:20 AM, Bill Spitzak wrote: Juan Zhao wrote: This prevents the fullscreen window from putting any useful clickable areas, such as the menubar, where the panels may obscure it, since the user cannot choose them without first raising the fullscreen window. This is just one cond

Re: [PATCH] [RFC]Shell: Hide panels when compositor has a top fullscreen surface.

wuzhiwen wrote: In addition if the panels obscure all the control areas and leave only an area where clicks will do something (such as the canvas in a painting program) then it will be impossible for the user to re-raise the fullscreen window with a click without changing the document as wel

Re: [PATCH] [RFC]Shell: Hide panels when compositor has a top fullscreen surface.

Juan Zhao wrote: This prevents the fullscreen window from putting any useful clickable areas, such as the menubar, where the panels may obscure it, since the user cannot choose them without first raising the fullscreen window. This is just one condition about the behaviour for fullscreen surfac

RE: [PATCH] [RFC]Shell: Hide panels when compositor has a top fullscreen surface.

>-Original Message- >From: Bill Spitzak [mailto:spit...@gmail.com] >Sent: Thursday, February 16, 2012 2:03 AM >To: Juan Zhao >Cc: Wu, Zhiwen; wayland-devel@lists.freedesktop.org >Subject: Re: [PATCH] [RFC]Shell: Hide panels when compositor has a top >fullscreen surface. > >Juan Zhao wrote

Re: [PATCH] [RFC]Shell: Hide panels when compositor has a top fullscreen surface.

On 02/16/2012 02:02 AM, Bill Spitzak wrote: Juan Zhao wrote: Only when un-fullscreen window over fullscreen window, the panels will be shown https://gitorious.org/dataforuse/dataforuse/blobs/master/nFoverF.png Does anybo

Re: [PATCH] [RFC]Shell: Hide panels when compositor has a top fullscreen surface.

Juan Zhao wrote: Only when un-fullscreen window over fullscreen window, the panels will be shown https://gitorious.org/dataforuse/dataforuse/blobs/master/nFoverF.png Does anybody have any actual documentation or tests t

[PATCH] window: Use new xkbcommon include path

xkbcommon in current git has moved its include files. Signed-off-by: Daniel Stone --- clients/window.c |2 +- clients/window.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/clients/window.c b/clients/window.c index ae5a791..c0cd5d3 100644 --- a/clients/window.c ++

[PATCH 7/7] clients/dnd: adapt to new data_device icon protocol

Signed-off-by: Ander Conselvan de Oliveira --- clients/dnd.c | 21 ++--- 1 files changed, 18 insertions(+), 3 deletions(-) diff --git a/clients/dnd.c b/clients/dnd.c index b4a9c10..5e1696b 100644 --- a/clients/dnd.c +++ b/clients/dnd.c @@ -55,6 +55,7 @@ struct dnd_drag {

[PATCH 6/7] compositor: implement drag'n'drop icons

Signed-off-by: Ander Conselvan de Oliveira --- src/compositor.c | 68 ++ src/compositor.h |4 +++ src/shell.c |2 + 3 files changed, 74 insertions(+), 0 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 13ee927

[PATCH 5/7] shell: update position of surfaces with type none on map()

Needed for implementing drag'n'drop icons. When a drag starts, the compositor will position the top-left corner of the client supplied icon surface at the cursor hotspot. On the first attach to that surface, the client may want to reposition it but shell->map did not take sx and sy parameters. Thi

[PATCH 4/7] compositor: add a way to disable picking of client surfaces

Surfaces like drag'n'drop icons shouldn't receive events as a normal surface but are still created by the client so add a way for the compositor to enable or disable the picking of a client surface. Signed-off-by: Ander Conselvan de Oliveira --- src/compositor.c |4 +++- src/compositor.h |

[PATCH 3/7] shell: don't map surfaces with type NONE

Signed-off-by: Ander Conselvan de Oliveira --- src/shell.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/shell.c b/src/shell.c index 66c4f01..d48633e 100644 --- a/src/shell.c +++ b/src/shell.c @@ -1342,6 +1342,8 @@ map(struct weston_shell *base, }

[PATCH 2/7] compositor: fix two crashs on surface_attach() with null buffer

The condition to return from surface_attach with a null buffer involves es->output being non-null. However if a surface was just created this field would be null and an attach of a null buffer would cause the compositor to crash. The other crash happened if surface_attach was called twice with a n

[PATCH wayland] data_device: get rid of attach request

In the effort to make everything a regular surface, remove data_device.attach request. To maintan the functionality, add an icon surface parameter to data_device.start_drag. Signed-off-by: Kristian Høgsberg Signed-off-by: Ander Conselvan de Oliveira --- protocol/wayland.xml | 22

[PATCH 0/7] Drag and drop icons

Here's a second attempt to getting drag and drop icons implemented. This uses the protocol change Kristian suggested on the previous thread. On libwayland-server, we just set wl_input_device::drag_surface and check it on Weston in different places. However, since there is no way to trigger a repai

[PATCH weston 2/2] protocol: remove absolute coordinates from pointer

This change depens on the Wayland core commit: "protocol: remove absolute coordinates from pointer". Remove the absolute coordinates from pointer motion and pointer_focus events. Signed-off-by: Pekka Paalanen --- clients/simple-touch.c |5 ++--- clients/window.c |5 ++--- src/

[PATCH weston 1/2] window: do not store absolute coordinates

These were not used for anything, anyway. Signed-off-by: Pekka Paalanen --- clients/window.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/clients/window.c b/clients/window.c index ae5a791..a38c99e 100644 --- a/clients/window.c +++ b/clients/window.c @@ -159,7 +15

[PATCH wayland] protocol: remove absolute coordinates from pointer

Remove the absolute coordinate fields from the pointer motion and pointer_focus events. Clients are not supposed to see any global coordinates. Fix wayland-server code accordingly. wayland-client code is unaffected. Signed-off-by: Pekka Paalanen --- protocol/wayland.xml |9 ++--- src/wa

Re: [PATCH v2 0/2] Logging functions

On 02/14/2012 12:30 AM, Ustun Ergenoglu wrote: From: Üstün Ergenoğlu Here's another attempt to add some logging functionality, this time on Weston instead of Wayland as Thiago suggested. In addittion, I added the WL_LOG_* macros that include the file and line info in the printed log lines. Th

Bug: configure does not check for gl

Hi all, Anisse reported, that Debian splits Mesa into packages in such a way, that we may miss gl.pc and GL/gl.h, even when the egl.pc and GLESv2 checks pass. We would need to check for gl.pc, too. We cannot simply add 'gl' to the PKG_CHECK_MODULES(CLIENT, ... line, as that might cause us to link

Re: [PATCH] compositor: fix dangling pointer

On Wednesday 15 February 2012 09:35:40 Pekka Paalanen wrote: > Looks ok as a stop-gap measure to me, FWIW. I somehow managed to skip a line from the first commit, and then forgot it in the patch... there must be a line like: struct weston_input_device *device; before wl_list_for_each, or the co