Re: [weston PATCH v6 1/2] add implementation for set_maximised

2012-02-06 Thread Pekka Paalanen
On Mon, 06 Feb 2012 13:08:38 -0800 Bill Spitzak wrote: > Pekka Paalanen wrote: > > > As long as clients know nothing about the global coordinate system, > > nothing about "remember position" can be completely implemented client > > side. I expect at some point we would add shell protocol to achi

Re: [weston PATCH v6 1/2] add implementation for set_maximised

2012-02-06 Thread Pekka Paalanen
On Tue, 07 Feb 2012 09:06:39 +0800 Juan Zhao wrote: > The unmaximized location is determined by "set_toplevel" now. Maybe we > can adds some parameter in "set_toplevel" to define the top-left coordinate? No, we cannot protocol-wise, as that would expose the global coordinate system to the clien

[weston PATCH v7 2/2] add the test case for set_maximised

2012-02-06 Thread juan . j . zhao
From: Juan Zhao F9: set maximised F8: set toplevel to back --- clients/Makefile.am |6 +- clients/simple-rect.c | 648 + 2 files changed, 653 insertions(+), 1 deletions(-) create mode 100644 clients/simple-rect.c diff --git a/clients/Makef

[weston PATCH v7 1/2] add the set_maximised implementation

2012-02-06 Thread juan . j . zhao
From: Juan Zhao --- src/shell.c | 73 +++ 1 files changed, 73 insertions(+), 0 deletions(-) diff --git a/src/shell.c b/src/shell.c index d15c8e2..e6aeeae 100644 --- a/src/shell.c +++ b/src/shell.c @@ -81,6 +81,7 @@ enum shell_surface_typ

[protocol PATCH v7] add set_maximised protocol

2012-02-06 Thread juan . j . zhao
From: Juan Zhao A request from the client to notify the compositor the maximised operation. The compositor will reply with a configure event telling the expected new surface size. The operation is completed on the next buffer attach to this surface. A maximised client will fill the fullscreen

[PATCH v7 0/3] set_maximised implemetation protocol + weston

2012-02-06 Thread juan . j . zhao
From: Juan Zhao v6:I rebase the set_maximised work at first. Because it is independed with fullscreen protocol. v7:update the comments remove some unnecessary printf add output parameter, only the bound output can be set maximised to move the geometry calculation to map and configure y

Re: [protocol v6 PATCH] add maximised protocol

2012-02-06 Thread Juan Zhao
On 02/06/2012 11:11 PM, Rob Bradford wrote: On 3 February 2012 08:45, Pekka Paalanen wrote: On Fri, 3 Feb 2012 16:16:16 +0800 juan.j.z...@linux.intel.com wrote: From: Juan Zhao add a request from the client to notify the compositor the maximised operation. The compositor will send a config

Re: [weston PATCH v6 1/2] add implementation for set_maximised

2012-02-06 Thread Juan Zhao
On 02/07/2012 05:08 AM, Bill Spitzak wrote: The output choosing code in the server would likely take the surface bounding box, and find the output where most of the surface is. This is how it already works, when we choose which output to synchronise the surface to. Yes this is exactly what I

Re: [weston PATCH v6 1/2] add implementation for set_maximised

2012-02-06 Thread Bill Spitzak
Pekka Paalanen wrote: As long as clients know nothing about the global coordinate system, nothing about "remember position" can be completely implemented client side. I expect at some point we would add shell protocol to achieve "remember layout" somehow, but I very much doubt it will deliberatl

Re: [protocol v6 PATCH] add maximised protocol

2012-02-06 Thread Rob Bradford
On 3 February 2012 08:45, Pekka Paalanen wrote: > On Fri,  3 Feb 2012 16:16:16 +0800 > juan.j.z...@linux.intel.com wrote: > >> From: Juan Zhao >> >> add a request from the client to notify the compositor the maximised >> operation. The compositor will send a configure event back to the >> client

[PATCH] compositor: q&d solution for surface drift

2012-02-06 Thread Pekka Paalanen
When a transformed (rotated) surface is continuously resized from its top-left corner, its location will drift. This is due to accumulating rounding errors in transforming an offset from surface-local to global coordinates in surface_attach(). Diminish the drift down to unobservable level by chang