Re: [PATCH v2 1/2] shell & compositor: add parameters for set_fullsceen

2012-01-11 Thread Bill Spitzak
Pekka Paalanen wrote: +#define WESTON_SURFACE_FULLSCREEN_NONE 0 +#define WESTON_SURFACE_FULLSCREEN_SCALE 1 +#define WESTON_SURFACE_FULLSCREEN_FORCE 2 +#define WESTON_SURFACE_FULLSCREEN_FILL 3 +#define WESTON_SURFACE_TYPE_CURSOR 0 +#define WESTON_SURFACE_TYPE_PANEL 1 +#define WESTON_SURFACE_TYPE_

Re: [RFC] Weston sprite support

2012-01-11 Thread Juan Zhao
(Sorry for forgetting the list.) Forwarded Message From: Juan Zhao To: Jesse Barnes Cc: k...@bitplanet.net Subject: Re: [RFC] Weston sprite support Date: Thu, 12 Jan 2012 00:09:17 +0800 On Fri, 2012-01-06 at 11:36 -0800, Jesse Barnes wrote: > I just wanted to get a direction

Re: [PATCH] egl_dri2/wayland: handle creating xrgb8888 images

2012-01-11 Thread Kristian Høgsberg
On Tue, Jan 10, 2012 at 5:16 PM, Robert Bragg wrote: > From: Robert Bragg > > When creating an EGLImage from a struct wl_buffer * this ensures > that we create an XRGB image if the wayland buffer doesn't have an > alpha channel. To determine if a wl_buffer has a valid alpha channel > this pat

Re: [protocol PATCH v2 1/2] add parameters for set_fullscreen

2012-01-11 Thread Juan Zhao
On Wed, 2012-01-11 at 10:10 +0200, Pekka Paalanen wrote: > "None" means no need for the compositor to do any work here, it is > useful > > in case that client want to re-layout his UI components to > fullscreen. > > Re-layout means rearrange the contents of that client other than > scaling. >

Re: [PATCH v2 2/2] shell: Add set_maximised for wl_shell_surface interface.

2012-01-11 Thread Juan Zhao
On Tue, 2012-01-10 at 14:11 +0200, Pekka Paalanen wrote: > On Mon, 9 Jan 2012 22:54:20 +0800 > juan.j.z...@linux.intel.com wrote: > > > From: Alex Wu > > > > mainly send a configure event to the client > > > > Signed-off-by: Juan Zhao > > Signed-off-by: Alex Wu > > > > --- > > src/shell.

Re: [PATCH v2 1/2] shell & compositor: add parameters for set_fullsceen

2012-01-11 Thread Juan Zhao
On Wed, 2012-01-11 at 11:50 +0200, Pekka Paalanen wrote: > > > What is this supposed to do? > > add the surface type for cursor/panel/general is to clarify the surface > > stack: > > -|--cursor > > -|--panel > > -|--general > > -|--general > > > > so that, we can figure out the window surfaces

Re: [protocol PATCH v2 1/2] add parameters for set_fullscreen

2012-01-11 Thread Juan Zhao
On Wed, 2012-01-11 at 10:10 +0200, Pekka Paalanen wrote: > > > > > The position of the surface on an output is not defined here, > > > possibly allowing the video driver to scan out a surface smaller than > > > the video mode. > > I'm not sure I catch your idea here. I would like to make it on

Re: [PATCH v2 1/2] shell & compositor: add parameters for set_fullsceen

2012-01-11 Thread Pekka Paalanen
On Wed, 11 Jan 2012 15:01:37 +0800 Juan Zhao wrote: > Thanks very much for your review. > > On Tue, 2012-01-10 at 13:41 +0200, Pekka Paalanen wrote: > > > + struct wl_list *tlist=(struct wl_list *)ec->surface_list.next; > > > + int count=0; > > > + > > > + while((es->type != WESTON_S

Re: [protocol PATCH v2 1/2] add parameters for set_fullscreen

2012-01-11 Thread Pekka Paalanen
On Tue, 10 Jan 2012 13:26:13 -0800 Bill Spitzak wrote: > Pekka Paalanen wrote: > > > "none" means the application does not care what method a compositor > > uses, so the compositor would probably choose either the cheapest > > (fill? no-fill?) or the best desktop-integrated user experience (scal

Re: [protocol PATCH v2 1/2] add parameters for set_fullscreen

2012-01-11 Thread Pekka Paalanen
On Wed, 11 Jan 2012 15:07:05 +0800 Juan Zhao wrote: > Thank you very much for your review. :) > > On Tue, 2012-01-10 at 13:42 +0200, Pekka Paalanen wrote: > > > These could also use commentary on what they mean. My suggestion of them > > is the following. > > > > "none" means the application d