Re: [protocol PATCH v2 1/2] add parameters for set_fullscreen

2012-01-10 Thread Juan Zhao
Thank you very much for your input. On Tue, 2012-01-10 at 13:26 -0800, Bill Spitzak wrote: > > "scale" is for preferring scaling in the compositor, the application > > really would like to fill the whole screen, even if it renders a buffer > > that is too small. The compositor might (be configure

Re: [protocol PATCH v2 1/2] add parameters for set_fullscreen

2012-01-10 Thread Juan Zhao
Thank you very much for your review. :) On Tue, 2012-01-10 at 13:42 +0200, Pekka Paalanen wrote: > These could also use commentary on what they mean. My suggestion of them > is the following. > > "none" means the application does not care what method a compositor > uses, so the compositor would

Re: [PATCH v2 1/2] shell & compositor: add parameters for set_fullsceen

2012-01-10 Thread Juan Zhao
Thanks very much for your review. On Tue, 2012-01-10 at 13:41 +0200, Pekka Paalanen wrote: > > + struct wl_list *tlist=(struct wl_list *)ec->surface_list.next; > > + int count=0; > > + > > + while((es->type != WESTON_SURFACE_TYPE_GENERAL) && count > <1024){ > > + tlist=tlis

[PATCH] egl_dri2/wayland: handle creating xrgb8888 images

2012-01-10 Thread Robert Bragg
From: Robert Bragg When creating an EGLImage from a struct wl_buffer * this ensures that we create an XRGB image if the wayland buffer doesn't have an alpha channel. To determine if a wl_buffer has a valid alpha channel this patch adds an internal wayland_drm_buffer_has_alpha() function. It'

Re: [PATCH v2 2/2] shell: Add set_maximised for wl_shell_surface interface.

2012-01-10 Thread Bill Spitzak
Is there an indicator sent to the client so that it knows it should not draw the "edges" of the window border? (ie look at Windows95. When you maximize a window, there are 2 pixels removed from the graphics all around the edge of the window compared to the non-maximized window). Removing these

Re: [protocol PATCH v2 1/2] add parameters for set_fullscreen

2012-01-10 Thread Bill Spitzak
Pekka Paalanen wrote: "none" means the application does not care what method a compositor uses, so the compositor would probably choose either the cheapest (fill? no-fill?) or the best desktop-integrated user experience (scale?) method. I think the default will have to be "fill". My guess is t

Re: [PATCH v2 2/2] shell: Add set_maximised for wl_shell_surface interface.

2012-01-10 Thread Pekka Paalanen
On Mon, 9 Jan 2012 22:54:20 +0800 juan.j.z...@linux.intel.com wrote: > From: Alex Wu > > mainly send a configure event to the client > > Signed-off-by: Juan Zhao > Signed-off-by: Alex Wu > > --- > src/shell.c | 48 > 1 files changed, 48 in

Re: [protocol PATCH v2 1/2] add parameters for set_fullscreen

2012-01-10 Thread Pekka Paalanen
On Mon, 9 Jan 2012 22:50:20 +0800 juan.j.z...@linux.intel.com wrote: > From: Alex Wu > > framerate: the expected framerate which will be used as refresh value to > choose display mode. > flags: indicate how to deal with resolution dismatch. > support three methods: > "SCALE" means the

Re: [protocol PATCH v2 2/2] add set_maximised method for wl_shell_surface interface

2012-01-10 Thread Pekka Paalanen
On Mon, 9 Jan 2012 22:50:21 +0800 juan.j.z...@linux.intel.com wrote: > From: Alex Wu > > add one interface to let the client notify the compositor the maximised > operation, > and then the compositor will send a configure event back to the client > > Signed-off-by: Juan Zhao > Signed-off-by

Re: [PATCH v2 1/2] shell & compositor: add parameters for set_fullsceen

2012-01-10 Thread Pekka Paalanen
Hi, here a just some bits that caught my eye on a quick look, inline. We might prefer to have compositor and client changes in separate patches, after a minimal patch that fixes breakage from protocol changes. Should be easy to fix just the protocol bits and retain current behaviour, and then imp