Re: [PATCH] shell: fix set_transient

2011-12-08 Thread Pekka Paalanen
On Thu, 8 Dec 2011 13:05:42 -0500 Kristian Høgsberg wrote: > On Thu, Dec 8, 2011 at 10:08 AM, Pekka Paalanen > wrote: > > On Thu, 08 Dec 2011 17:04:47 +0200 > > Tiago Vignatti wrote: ... > >> but I thought you'd implement the explicit cast scheme.. meh. > > > > Sorry, not today :-D > > > > I'll

Re: pull wayland-demos: cleanups, shared config lib, signal mask fix

2011-12-08 Thread Pekka Paalanen
On Thu, 8 Dec 2011 12:49:50 -0500 Kristian Høgsberg wrote: > On Thu, Dec 8, 2011 at 4:40 AM, Pekka Paalanen > wrote: > > Hi Kristian, > > > > I gathered a set of miscellaneous commits that I have produced while > > working on the idle animation. > > > > Please, could you pull > > > >        git:

Re: Possible bug with input handling

2011-12-08 Thread Tiago Vignatti
On 12/08/2011 09:34 PM, Christopher Michael wrote: On 12/08/11 10:14, Tiago Vignatti wrote: Hi, sorry for late reply. On 11/29/2011 08:30 PM, Christopher Michael wrote: I found an issue while working on some local code, that may be a bug in the input handling of Wayland. In my function to pr

Re: Possible bug with input handling

2011-12-08 Thread Christopher Michael
On 12/08/11 10:14, Tiago Vignatti wrote: Hi, sorry for late reply. On 11/29/2011 08:30 PM, Christopher Michael wrote: I found an issue while working on some local code, that may be a bug in the input handling of Wayland. In my function to process button events (from mouse), the 'btn' paramete

Re: wl_shell_surface_resize semantics

2011-12-08 Thread Kristian Høgsberg
2011/12/8 Kristian Høgsberg : > On Wed, Dec 7, 2011 at 5:56 AM, Daniel Stone wrote: >> Hi, >> >> On 7 December 2011 08:15, Pekka Paalanen wrote: >>> I see the problem from a completely different point of view, similar to >>> Rob. >>> >>> If we (the compositor) send a button press event to a clien

Re: wl_shell_surface_resize semantics

2011-12-08 Thread Kristian Høgsberg
On Wed, Dec 7, 2011 at 5:56 AM, Daniel Stone wrote: > Hi, > > On 7 December 2011 08:15, Pekka Paalanen wrote: >> I see the problem from a completely different point of view, similar to >> Rob. >> >> If we (the compositor) send a button press event to a client, we better >> be sending a button rel

Re: [PATCH 1/4] compositor-drm: Fix memory leak in update_outputs

2011-12-08 Thread Kristian Høgsberg
On Thu, Dec 8, 2011 at 11:05 AM, David Herrmann wrote: > We need to correctly free every connector we retrieve. We currently loose them > if they are not connected. Thanks, all of these look good and have been committed. Kristian > Signed-off-by: David Herrmann > --- >  compositor/compositor-dr

Re: [PATCH] compositor-x11: convert (some) of X11 buttons to linux input

2011-12-08 Thread Kristian Høgsberg
On Thu, Dec 8, 2011 at 10:16 AM, Pekka Paalanen wrote: > On Thu,  8 Dec 2011 17:03:17 +0200 > Tiago Vignatti wrote: > >> From: Tiago Vignatti >> >> Signed-off-by: Tiago Vignatti > > Reviewed-by: Pekka Paalanen > > For the record, this patch: > - emits booboo instead of some arbitrary button ev

Re: [PATCH] shell: fix set_transient

2011-12-08 Thread Kristian Høgsberg
On Thu, Dec 8, 2011 at 10:08 AM, Pekka Paalanen wrote: > On Thu, 08 Dec 2011 17:04:47 +0200 > Tiago Vignatti wrote: > >> On 12/08/2011 04:42 PM, Pekka Paalanen wrote: >> > In the wl_shell_surface migration, I forgot to correct one cast in >> > shell_surface_set_transient(). 'parent_resource' is n

Re: [PATCH] shell: fix set_transient

2011-12-08 Thread Kristian Høgsberg
On Thu, Dec 8, 2011 at 9:42 AM, Pekka Paalanen wrote: > In the wl_shell_surface migration, I forgot to correct one cast in > shell_surface_set_transient(). 'parent_resource' is not a (struct > wlsc_surface *) but (struct shell_surface *). > > This bug corrupts a wlsc_surface::output field, which l

Re: [PATCH] compositor: fix release button notification

2011-12-08 Thread Kristian Høgsberg
On Thu, Dec 8, 2011 at 4:58 AM, Pekka Paalanen wrote: > On Wed, 7 Dec 2011 15:56:23 + > Rob Bradford wrote: > >> On 7 December 2011 14:32, Tiago Vignatti >> wrote: >> > From: Tiago Vignatti >> > >> > Previously the client could set another grab via >> > wl_input_device_update_grab, which wo

Re: pull wayland-demos: cleanups, shared config lib, signal mask fix

2011-12-08 Thread Kristian Høgsberg
On Thu, Dec 8, 2011 at 4:40 AM, Pekka Paalanen wrote: > Hi Kristian, > > I gathered a set of miscellaneous commits that I have produced while > working on the idle animation. > > Please, could you pull > >        git://git.collabora.co.uk/git/user/pq/wayland.git for-krh-1 > > http://cgit.collabora

[PATCH 4/4] compositor-drm: Catch errors in create_output_for_connector

2011-12-08 Thread David Herrmann
We do not handle errors of gbm-buffer-creation and drm-mode-setting in create_output_for_connectors. Correctly catch these now and free memory on error to avoid memory leaks. Signed-off-by: David Herrmann --- compositor/compositor-drm.c | 29 ++--- 1 files changed, 26 i

[PATCH 3/4] compositor-drm: Free output on error in create_output_for_connector

2011-12-08 Thread David Herrmann
We currently simply return -1 on error in create_output_for_connector. This correctly frees the output and all modes when we fail to avoid memory leaks. Signed-off-by: David Herrmann --- compositor/compositor-drm.c | 34 +++--- 1 files changed, 27 insertions(+), 7 d

[PATCH 2/4] compositor-drm: Fix memory leak in create_output_for_connector

2011-12-08 Thread David Herrmann
We do not free the encoder structure on failure. Fix that. Signed-off-by: David Herrmann --- compositor/compositor-drm.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/compositor/compositor-drm.c b/compositor/compositor-drm.c index 9f76187..1f5e028 100644 --- a/comp

[PATCH 1/4] compositor-drm: Fix memory leak in update_outputs

2011-12-08 Thread David Herrmann
We need to correctly free every connector we retrieve. We currently loose them if they are not connected. Signed-off-by: David Herrmann --- compositor/compositor-drm.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/compositor/compositor-drm.c b/compositor/composi

Re: [PATCH] compositor-x11: convert (some) of X11 buttons to linux input

2011-12-08 Thread Pekka Paalanen
On Thu, 8 Dec 2011 17:03:17 +0200 Tiago Vignatti wrote: > From: Tiago Vignatti > > Signed-off-by: Tiago Vignatti Reviewed-by: Pekka Paalanen For the record, this patch: - emits booboo instead of some arbitrary button events for wheel rotation, so wheel on x11 backend will need more fixin

Re: Possible bug with input handling

2011-12-08 Thread Tiago Vignatti
Hi, sorry for late reply. On 11/29/2011 08:30 PM, Christopher Michael wrote: I found an issue while working on some local code, that may be a bug in the input handling of Wayland. In my function to process button events (from mouse), the 'btn' parameter that gets returned to my handler seems i

Re: [PATCH] shell: fix set_transient

2011-12-08 Thread Pekka Paalanen
On Thu, 08 Dec 2011 17:04:47 +0200 Tiago Vignatti wrote: > On 12/08/2011 04:42 PM, Pekka Paalanen wrote: > > In the wl_shell_surface migration, I forgot to correct one cast in > > shell_surface_set_transient(). 'parent_resource' is not a (struct > > wlsc_surface *) but (struct shell_surface *). >

Re: [PATCH] shell: fix set_transient

2011-12-08 Thread Tiago Vignatti
On 12/08/2011 04:42 PM, Pekka Paalanen wrote: In the wl_shell_surface migration, I forgot to correct one cast in shell_surface_set_transient(). 'parent_resource' is not a (struct wlsc_surface *) but (struct shell_surface *). This bug corrupts a wlsc_surface::output field, which later (in my expe

[PATCH] compositor-x11: convert (some) of X11 buttons to linux input

2011-12-08 Thread Tiago Vignatti
From: Tiago Vignatti Signed-off-by: Tiago Vignatti --- compositor/compositor-x11.c | 31 +-- 1 files changed, 29 insertions(+), 2 deletions(-) diff --git a/compositor/compositor-x11.c b/compositor/compositor-x11.c index 544d7e2..870d57a 100644 --- a/compositor/com

[PATCH] shell: fix set_transient

2011-12-08 Thread Pekka Paalanen
In the wl_shell_surface migration, I forgot to correct one cast in shell_surface_set_transient(). 'parent_resource' is not a (struct wlsc_surface *) but (struct shell_surface *). This bug corrupts a wlsc_surface::output field, which later (in my experiments) leads to a segmentation fault in surfac

[RFC] idle animation interface and implementation

2011-12-08 Thread Pekka Paalanen
Hi, here is the patch set that integrates wscreensaver into the demo compositor: - interface implementation and surface type handling: screensaver surface only mapped during idle or lock screen - automatic launch and kill - automatic launch is opt-in, you need to enable it in your wayland-desk

Re: [PATCH] compositor: fix release button notification

2011-12-08 Thread Pekka Paalanen
On Wed, 7 Dec 2011 15:56:23 + Rob Bradford wrote: > On 7 December 2011 14:32, Tiago Vignatti > wrote: > > From: Tiago Vignatti > > > > Previously the client could set another grab via > > wl_input_device_update_grab, which would lead the compositor not > > delivering some button events. Now

pull wayland-demos: cleanups, shared config lib, signal mask fix

2011-12-08 Thread Pekka Paalanen
Hi Kristian, I gathered a set of miscellaneous commits that I have produced while working on the idle animation. Please, could you pull git://git.collabora.co.uk/git/user/pq/wayland.git for-krh-1 http://cgit.collabora.com/git/user/pq/wayland-demos.git/log/?h=for-krh-1 to get the follow