Re: Patch 8.1.2389

2019-12-06 Fir de Conversatie Bram Moolenaar
Christian wrote: > On Do, 05 Dez 2019, Bram Moolenaar wrote: > > > For xdiff I don't see a reason why they can't change to use //. > > Perhaps someone can send them a patch. > > I believe the git source uses /* */ as Comment in their source. > and I don't believe they will appreciate such a pa

Re: Patch 8.1.2389

2019-12-06 Fir de Conversatie Christian Brabandt
On Do, 05 Dez 2019, Bram Moolenaar wrote: > For xdiff I don't see a reason why they can't change to use //. > Perhaps someone can send them a patch. I believe the git source uses /* */ as Comment in their source. and I don't believe they will appreciate such a patch. BTW: I have been thinking

Re: Patch 8.1.2389

2019-12-05 Fir de Conversatie Bram Moolenaar
Ken Takata wrote: > 2019/12/5 Thu 21:42:51 UTC+9 Bram Moolenaar wrote: > > Ken Takata wrote: > > > > > 2019/12/5 Thu 6:17:35 UTC+9 Bram Moolenaar wrote: > > > > > > > > > > > > Patch 8.1.2389 > > > > Problem:

Re: Patch 8.1.2389

2019-12-05 Fir de Conversatie Ken Takata
Hi Bram, 2019/12/5 Thu 21:42:51 UTC+9 Bram Moolenaar wrote: > > > Ken Takata wrote: > > > 2019/12/5 Thu 6:17:35 UTC+9 Bram Moolenaar wrote: > > > > > > > > > Patch 8.1.2389 > > > Problem:Using old C style comments. > > &

Re: Patch 8.1.2389

2019-12-05 Fir de Conversatie Bram Moolenaar
Ken Takata wrote: > 2019/12/5 Thu 6:17:35 UTC+9 Bram Moolenaar wrote: > > > > > > Patch 8.1.2389 > > Problem:Using old C style comments. > > Solution: Use // comments where appropriate. > > Files:src/libvterm/src/screen.c, src/libvt

Re: Patch 8.1.2389

2019-12-04 Fir de Conversatie Ken Takata
Hi Bram, 2019/12/5 Thu 6:17:35 UTC+9 Bram Moolenaar wrote: > > > Patch 8.1.2389 > Problem:Using old C style comments. > Solution: Use // comments where appropriate. > Files:src/libvterm/src/screen.c, src/libvterm/src/unicode.c, > src/libv

Patch 8.1.2389

2019-12-04 Fir de Conversatie Bram Moolenaar
Patch 8.1.2389 Problem:Using old C style comments. Solution: Use // comments where appropriate. Files: src/libvterm/src/screen.c, src/libvterm/src/unicode.c, src/libvterm/src/vterm.c, src/libvterm/t/harness.c, src/libvterm/include/vterm.h, src/xdiff/xdiffi.c