Re: Patch 8.1.1146

2019-05-14 Fir de Conversatie Jason Franklin
> I cannot reproduce this in xterm. I see no reason why you see a > difference. When I run xterm on Ubuntu 18.04, I get an 8 color terminal. So, I'm unable to reproduce the problem with xterm as well. It's only in GNOME Terminal that I see the difference in color. On Tue, May 14, 2019 at 11:57

Re: Patch 8.1.1146

2019-05-14 Fir de Conversatie Bram Moolenaar
Jason Franklin wrote: > Thank you so much for taking the time to work with me on this. > > Unfortunately, I still can't get the colors to match on the latest build > (patch 8.1.1330). I should note that the color scheme is much closer than > it was before, but it looks like some of the colors

Re: Patch 8.1.1146

2019-05-14 Fir de Conversatie Bram Moolenaar
Ken Takata wrote: > I also noticed that the colors on Cygwin + mintty with 256-color mode are > wrong since 8.1.1146. Especially, yellow becomes brown. > The following patch seems to fix the problem: > > --- a/src/terminal.c > +++ b/src/terminal.c > @@ -2432,6 +2432,8 @@ color2index(VTermColor

Re: Patch 8.1.1146

2019-05-14 Fir de Conversatie Jason Franklin
Thanks, Ken. > The following patch seems to fix the problem: It does fix the problem for me. With the patch applied, I can't tell the difference in the output of "colors" in a Vim terminal window and in GNOME Terminal directly. However, it seems like this is a band-aid and not a real fix. Why

Re: Patch 8.1.1146

2019-05-13 Fir de Conversatie Ken Takata
Hi, 2019/5/14 Tue 5:58:30 UTC+9 Jason Franklin wrote: > Bram, > > Thank you so much for taking the time to work with me on this. > > Unfortunately, I still can't get the colors to match on the latest build > (patch 8.1.1330). I should note that the color scheme is much closer than it > was be

Re: Patch 8.1.1146

2019-05-13 Fir de Conversatie Bram Moolenaar
Jason Franklin wrote: > I rewrote my script to be much simpler. It shows both the escape codes > being printed and > the word "example" in each color. > > > In your screenshots the bold colors are clearly wrong. > > I discovered this was caused by a GNOME Terminal setting called "Show bold >

Re: Patch 8.1.1146

2019-05-12 Fir de Conversatie Bram Moolenaar
Jason Franklin wrote: > I did a good bit of work to script up a demonstration of this problem. > > I believe something is now broken with how Vim interprets custom color > palettes in 256-color terminal windows. I can reproduce the problem without > using my own .vim directory. > > I wrote a

Re: Patch 8.1.1146

2019-05-07 Fir de Conversatie Jason Franklin
> Perhaps you need to adjust your setup? I'm perfectly fine with that, but I'm at a loss for what should be adjusted. I'll poke around. If you have any suggestions, let me know! Thanks, Jason -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below

Re: Patch 8.1.1146

2019-05-07 Fir de Conversatie Bram Moolenaar
Jason Franklin wrote: > Environment: GNOME Terminal on Ubuntu 18.04 > git bisect shows this commit as changing the colors of my terminal window. > See before and after images attached. > I can fix the problem with: > > diff --git a/src/terminal.c b/src/terminal.c > index c7dc23f90..8bea9481a 10

Patch 8.1.1146

2019-04-11 Fir de Conversatie Bram Moolenaar
Patch 8.1.1146 Problem:In MS-Windows console colors in a terminal window are wrong. Solution: Use the ansi index also for 16 colors. (Ken Takata) Files: src/terminal.c *** ../vim-8.1.1145/src/terminal.c 2019-04-06 22:01:20.756989404 +0200 --- src/terminal.c 2019-04-11 11