Coverity (was: Re: Patch 7.4.745)

2015-06-24 Fir de Conversatie Bram Moolenaar
Christian Brabandt wrote: > On Sa, 20 Jun 2015, Christian Brabandt wrote: > > > I just uploaded a new build 7.4.749 for analysis. There should be > > results available soon. > > FWIW, I have setup a cronjob to periodically build and upload a new Vim > build when a new patchlevel is available.

Coverity (was: Re: Patch 7.4.745)

2015-06-23 Fir de Conversatie Christian Brabandt
On Sa, 20 Jun 2015, Christian Brabandt wrote: > I just uploaded a new build 7.4.749 for analysis. There should be > results available soon. FWIW, I have setup a cronjob to periodically build and upload a new Vim build when a new patchlevel is available. However, that machine only has sporadic I

Re: Patch 7.4.745

2015-06-20 Fir de Conversatie kazunobu . kuriyama
Hi Christian - Original Message - >Date: Sat, 20 Jun 2015 22:15:59 +0200 >From: Christian Brabandt >To: vim_dev@googlegroups.com >Subject: Re: Patch 7.4.745 > > >Hi Kazunobu! > >On Sa, 20 Jun 2015, Kazunobu Kuriyama wrote: > >> This patch causes

Re: Patch 7.4.745

2015-06-20 Fir de Conversatie Christian Brabandt
On Fr, 19 Jun 2015, Benjamin Fritz wrote: > On Fri, Jun 19, 2015 at 3:59 PM, Bram Moolenaar wrote: > > > > > > Ben Fritz wrote: > > > > > On Friday, June 19, 2015 at 2:06:59 PM UTC-5, Bram Moolenaar wrote: > > > > > > > > > > This patch causes a segfault at eval.c::17177 due to a trivial reason.

Re: Patch 7.4.745

2015-06-20 Fir de Conversatie Christian Brabandt
Hi Kazunobu! On Sa, 20 Jun 2015, Kazunobu Kuriyama wrote: > This patch causes a segfault at eval.c::17177 due to a trivial reason. > > The attached patch fixes it. Sorry for causing that. I usually check with valgrind any changes I do, before I submit a patch. I'll have to use address sanitize

Re: Patch 7.4.745

2015-06-20 Fir de Conversatie Bram Moolenaar
Dominique Pellé wrote: > >> This patch causes a segfault at eval.c::17177 due to a trivial reason. > >> > >> The attached patch fixes it. > > > > Thanks! Unfortunately valgrind does not find this kind of error. > > The address sanitizer (asan) would find such bugs. It finds stack > and global

Re: Patch 7.4.745

2015-06-19 Fir de Conversatie Dominique Pellé
Bram Moolenaar wrote: > Kazunobu Kuriyama wrote: > >> On Jun 19, 2015, at 23:33, Bram Moolenaar wrote: >> >> > >> > Patch 7.4.745 >> > Problem:The entries added by matchaddpos() are returned by getmatches() >> >but can&

Re: Patch 7.4.745

2015-06-19 Fir de Conversatie Justin M. Keyes
On Fri, Jun 19, 2015 at 6:31 PM, Benjamin Fritz wrote: > > On Fri, Jun 19, 2015 at 5:24 PM, Benjamin Fritz > wrote: >> >> > Coverity should run automatically. I haven't checked the output >> > recently. There used to be quite a few false positives, maybe it's >> > better now. >> > >> > I'm not

Re: Patch 7.4.745

2015-06-19 Fir de Conversatie Benjamin Fritz
On Fri, Jun 19, 2015 at 5:24 PM, Benjamin Fritz wrote: > > > Coverity should run automatically. I haven't checked the output > > recently. There used to be quite a few false positives, maybe it's > > better now. > > > > I'm not sure the Vim results are available to others or can be made > > avai

Re: Patch 7.4.745

2015-06-19 Fir de Conversatie Benjamin Fritz
On Fri, Jun 19, 2015 at 3:59 PM, Bram Moolenaar wrote: > > > Ben Fritz wrote: > > > On Friday, June 19, 2015 at 2:06:59 PM UTC-5, Bram Moolenaar wrote: > > > > > > > > This patch causes a segfault at eval.c::17177 due to a trivial reason. > > > > > > > > The attached patch fixes it. > > > > > > Th

Re: Patch 7.4.745

2015-06-19 Fir de Conversatie Bram Moolenaar
Ben Fritz wrote: > On Friday, June 19, 2015 at 2:06:59 PM UTC-5, Bram Moolenaar wrote: > > > > > > This patch causes a segfault at eval.c::17177 due to a trivial reason. > > > > > > The attached patch fixes it. > > > > Thanks! Unfortunately valgrind does not find this kind of error. > > > >

Re: Patch 7.4.745

2015-06-19 Fir de Conversatie Ben Fritz
On Friday, June 19, 2015 at 2:06:59 PM UTC-5, Bram Moolenaar wrote: > > > > This patch causes a segfault at eval.c::17177 due to a trivial reason. > > > > The attached patch fixes it. > > Thanks! Unfortunately valgrind does not find this kind of error. > It was a buffer size error...Coverity

Re: Patch 7.4.745

2015-06-19 Fir de Conversatie Bram Moolenaar
Kazunobu Kuriyama wrote: > On Jun 19, 2015, at 23:33, Bram Moolenaar wrote: > > > > > Patch 7.4.745 > > Problem:The entries added by matchaddpos() are returned by getmatches() > >but can't be set with setmatches(). (Lcd) > > Solution

Re: Patch 7.4.745

2015-06-19 Fir de Conversatie Kazunobu Kuriyama
On Jun 19, 2015, at 23:33, Bram Moolenaar wrote: > > Patch 7.4.745 > Problem:The entries added by matchaddpos() are returned by getmatches() >but can't be set with setmatches(). (Lcd) > Solution: Fix setmatches(). (Christian Brabandt) > Files:

Patch 7.4.745

2015-06-19 Fir de Conversatie Bram Moolenaar
Patch 7.4.745 Problem:The entries added by matchaddpos() are returned by getmatches() but can't be set with setmatches(). (Lcd) Solution: Fix setmatches(). (Christian Brabandt) Files: src/eval.c, src/testdir/test63.in, src/testdir/test63.ok *** ../vim-7.4.744/src/e