Re: [PATCH] runtime: syntax: diff: fix for modern format

On Wed, Dec 30, 2020 at 3:05 PM Bram Moolenaar wrote: > > > Filipe Contreras wrote: It's Felipe. > > In 20 years of experience contributing to open source software, I have > > **never** heard of a single person saying "please don't record my real > > name". > > I have, many times. I don't know

Re: [PATCH] runtime: syntax: diff: fix for modern format

Filipe Contreras wrote: > In 20 years of experience contributing to open source software, I have > **never** heard of a single person saying "please don't record my real > name". I have, many times. And also quite a few names on changes are not the actual name of the person but an alias. I do

Re: [PATCH] runtime: syntax: diff: fix for modern format

> Am 30.12.2020 um 20:07 schrieb Felipe Contreras : > > On Wed, Dec 30, 2020 at 12:09 PM Christian Brabandt > wrote >> >> >> No, I just think being conservative with what data is being collected is >> actually a good thing. But that is just my opinion. Feel free to disagree. > > Precisel

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Wed, Dec 30, 2020 at 12:09 PM Christian Brabandt wrote: > > > Am 30.12.2020 um 18:49 schrieb Felipe Contreras > > : > > > > On Wed, Dec 30, 2020 at 11:38 AM Christian Brabandt > > wrote: > >>> Am 30.12.2020 um 18:05 schrieb Felipe Contreras > >>> :. > I find it scary that I can dig up

Re: [PATCH] runtime: syntax: diff: fix for modern format

> Am 30.12.2020 um 18:49 schrieb Felipe Contreras : > > On Wed, Dec 30, 2020 at 11:38 AM Christian Brabandt wrote: >>> Am 30.12.2020 um 18:05 schrieb Felipe Contreras >>> :. I find it scary that I can dig up what someone has done a dozen years ago in some repository. >>> >>> And what

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Wed, Dec 30, 2020 at 11:38 AM Christian Brabandt wrote: > > Am 30.12.2020 um 18:05 schrieb Felipe Contreras > > :. > >> I find it scary that I can dig up what someone has done a dozen years ago > >> in some repository. > > > > And what about the rest of us?. > > It's actually a good thing. So

Re: [PATCH] runtime: syntax: diff: fix for modern format

> Am 30.12.2020 um 18:05 schrieb Felipe Contreras :. >> I find it scary that I can dig up what someone has done a dozen years ago >> in some repository. > > And what about the rest of us?. It's actually a good thing. If data has not been collected, it can't be abused. That it better than wha

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Wed, Dec 30, 2020 at 10:48 AM Bram Moolenaar wrote: > > > Felipe Contreras wrote: > > > On Wed, Dec 30, 2020 at 8:11 AM Christian Brabandt > > wrote: > > > On Mi, 30 Dez 2020, Felipe Contreras wrote: > > > > Yes. I know there's no attribution. > > > > > > > > Either there's attribution or the

Re: [PATCH] runtime: syntax: diff: fix for modern format

Felipe Contreras wrote: > On Wed, Dec 30, 2020 at 8:11 AM Christian Brabandt wrote: > > On Mi, 30 Dez 2020, Felipe Contreras wrote: > > > Yes. I know there's no attribution. > > > > > > Either there's attribution or there isn't. > > > > There is attribution to the changes in the Core C files, w

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Wed, Dec 30, 2020 at 8:11 AM Christian Brabandt wrote: > On Mi, 30 Dez 2020, Felipe Contreras wrote: > > Yes. I know there's no attribution. > > > > Either there's attribution or there isn't. > > There is attribution to the changes in the Core C files, which make the > core of Vim. So not all

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Mi, 30 Dez 2020, Felipe Contreras wrote: > Yes. I know there's no attribution. > > Either there's attribution or there isn't. There is attribution to the changes in the Core C files, which make the core of Vim. Best, Christian -- Die Philosophen verdammen den Reichtum nur, weil wir ihn sc

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Wed, Dec 30, 2020 at 7:56 AM Christian Brabandt wrote: > On Mi, 30 Dez 2020, Felipe Contreras wrote: > > Didn't you just argued in issue #7574 that contributors are mentioned in > > the commit message? > > > > Where is my attribution? > > Are you trolling? No. > Runtime files are typically

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Mi, 30 Dez 2020, Felipe Contreras wrote: > On Wednesday, December 16, 2020 at 2:13:39 AM UTC-6 cbl...@256bit.org wrote: > I think it has been included as of > https://github.com/vim/vim/commit/1b884a0053982335f644eec6c71027706bf3c522 > Didn't you just argued in issue #7574 that contri

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Wednesday, December 16, 2020 at 2:13:39 AM UTC-6 cbl...@256bit.org wrote: > > I think it has been included as of > https://github.com/vim/vim/commit/1b884a0053982335f644eec6c71027706bf3c522 > Didn't you just argued in issue #7574 that contributors are mentioned in the commit message? Whe

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Di, 15 Dez 2020, Felipe Contreras wrote: > Hello? Hello again :) I think it has been included as of https://github.com/vim/vim/commit/1b884a0053982335f644eec6c71027706bf3c522 Best, Christian -- Man gewöhnt sich an alles, sogar an sich selbst. -- -- You received this message from the "

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Mon, Dec 7, 2020 at 12:16 PM Felipe Contreras wrote: > > On Mon, Dec 7, 2020 at 11:54 AM Bram Moolenaar wrote: > > Felipe Contreras wrote: > > > > But it doesn't work. I want to distinguish the file ("^diff\>.*" aka > > > diffFile) from the new file ("^+++ .*" aka diffNewFile). > > > > > > So

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Mon, Dec 7, 2020 at 11:54 AM Bram Moolenaar wrote: > Felipe Contreras wrote: > > But it doesn't work. I want to distinguish the file ("^diff\>.*" aka > > diffFile) from the new file ("^+++ .*" aka diffNewFile). > > > > So in my colorscheme I have diffNewFile: 'green', diffOldFile: 'red', > > d

Re: [PATCH] runtime: syntax: diff: fix for modern format

Felipe Contreras wrote: > > > Nowadays most people use the unified diff, which has this format: > > > > > > --- a/foo > > > +++ b/foo > > > > > > In that case the old file starts with '---', but currently that's > > > considered the new file, since the old context format is like: > > > > > >

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Sun, Dec 6, 2020 at 11:51 AM Bram Moolenaar wrote: > > > Felipe Contreras wrote: > > > Nowadays most people use the unified diff, which has this format: > > > > --- a/foo > > +++ b/foo > > > > In that case the old file starts with '---', but currently that's > > considered the new file, sin

Re: [PATCH] runtime: syntax: diff: fix for modern format

Felipe Contreras wrote: > Nowadays most people use the unified diff, which has this format: > > --- a/foo > +++ b/foo > > In that case the old file starts with '---', but currently that's > considered the new file, since the old context format is like: > > *** a/foo > --- b/foo > > L

[PATCH] runtime: syntax: diff: fix for modern format

Nowadays most people use the unified diff, which has this format: --- a/foo +++ b/foo In that case the old file starts with '---', but currently that's considered the new file, since the old context format is like: *** a/foo --- b/foo Let's use the modern format by default, and leave th