[PATCH] indent: add html tests

To make sure javascript blocks are properly indented. Signed-off-by: Felipe Contreras --- runtime/indent/testdir/html.in | 8 runtime/indent/testdir/html.ok | 8 2 files changed, 16 insertions(+) diff --git a/runtime/indent/testdir/html.in b/runtime/indent/testdir/html.in

[PATCH v2] indent: fix for html inside javascript again

ed to remove the monkey patch, and include the correct fix. I've agregated a few fixes from Chris Paul and this is the resulting patch. [1] https://github.com/pangloss/vim-javascript/commit/e110653 Cc: Chris Paul Signed-off-by: Felipe Contreras --- runtime/indent/html.vim | 2 +

Re: [PATCH] indent: fix for html inside javascript again

On Tue, Jul 26, 2022 at 3:27 PM Bram Moolenaar wrote: > > > Felipe Contreras wrote: > > > In issue #3205 a monkey patch was mentioned, but it wasn't the proper > > fix, the proper fix is in GetJavascriptIndent(), which was done in > > 2018 [1]. > > > &g

[PATCH] indent: fix for html inside javascript again

ation inside blocks, like: function test() { let v1; } test(); We need to remove the monkey patch, and include the correct fix. [1] https://github.com/pangloss/vim-javascript/commit/e110653 Cc: Chris Paul Signed-off-by: Felipe Contreras --- runtime/i

Re: [PATCH] unix: fix mch_call_shell_fork condition

On Tue, Jun 1, 2021 at 1:49 PM Bram Moolenaar wrote: > > > Felipe Contreras wrote: > > > > > Clearly the code meant to check for SHELL_SILENT in order to send to > > > > /dev/null, not SHELL_EXPAND. > > > > > > > > This works because all

Re: [PATCH] os_unix: remove unnecessary process group stuff

On Tue, Jun 1, 2021 at 8:42 AM Bram Moolenaar wrote: > > > Felipe Contreras wrote: > > > > > > > > > Processes are not being started correctly with TIOCSCTTY, which > > > > > > > > does > > > > > > > > suc

Re: [PATCH] unix: fix mch_call_shell_fork condition

On Tue, Jun 1, 2021 at 11:47 AM Bram Moolenaar wrote: > Felipe Contreras wrote: > > > Clearly the code meant to check for SHELL_SILENT in order to send to > > /dev/null, not SHELL_EXPAND. > > > > This works because all the callers of get_cmd_output that use > >

[PATCH] unix: fix mch_call_shell_fork condition

Clearly the code meant to check for SHELL_SILENT in order to send to /dev/null, not SHELL_EXPAND. This works because all the callers of get_cmd_output that use SHELL_SILENT also use SHELL_EXPAND. This has been there since Vim 5.0. Signed-off-by: Felipe Contreras --- src/os_unix.c | 2 +- 1

Re: [PATCH] os_unix: remove unnecessary process group stuff

ll possible platforms, but it may > > be enough to see whether the change already breaks something. > > It would be good, if that specific test (to run an interactive command > using :!) could be reproduced on the CI systems. Not sure how easy this > would be to do :/ D

Re: [PATCH] os_unix: remove unnecessary process group stuff

On Tue, Jun 1, 2021 at 3:12 AM Bram Moolenaar wrote: > Felipe Contreras wrote: > > > > > > > Processes are not being started correctly with TIOCSCTTY, which does > > > > > > succeed after setsid(). > > > > > > > > > >

Re: Vim 9 still under development; Kibaale Walk

On Mon, May 31, 2021 at 6:02 PM Bram Moolenaar wrote: > Felipe Contreras wrote: > > > On Monday, May 31, 2021 at 11:50:10 AM UTC-5 Bram Moolenaar wrote: > > > > > The work on Vim 9 is making progress. Most of the syntax has settled > > > down, but there are s

Re: [PATCH] os_unix: remove unnecessary process group stuff

On Mon, May 31, 2021 at 6:02 PM Bram Moolenaar wrote: > Felipe Contreras wrote: > > > > > Processes are not being started correctly with TIOCSCTTY, which does > > > > succeed after setsid(). > > > > > > > > None of that stuff is necessary, i

Re: Vim 9 still under development; Kibaale Walk

On Monday, May 31, 2021 at 11:50:10 AM UTC-5 Bram Moolenaar wrote: > The work on Vim 9 is making progress. Most of the syntax has settled > down, but there are still a few todo items and we need to make sure > everything works well before we can launch it. You can read more about > it in the

Re: [PATCH] os_unix: remove unnecessary process group stuff

On Mon, May 31, 2021 at 12:23 PM Bram Moolenaar wrote: > Felipe Contreras wrote: > > > Processes are not being started correctly with TIOCSCTTY, which does > > succeed after setsid(). > > > > None of that stuff is necessary, including the silencing of SIGHUP. >

Re: Is :! buggy?

Please CC me. I don't receive messages from the list. On Monday, May 31, 2021 at 12:36:47 AM UTC-5 cbl...@256bit.org wrote: > I have seen this behaviour before, but not sure what is causing this. It > works using `setsid xdg-open` as mentioned e.g. here: > https://vi.stackexchange.com/a/5034/71

Re: [PATCH] os_unix: remove unnecessary process group stuff

On Mon, May 31, 2021 at 2:22 AM Felipe Contreras wrote: > > Processes are not being started correctly with TIOCSCTTY, which does > succeed after setsid(). I'm using the following program that uses posix_spawn as a test. When using gvim, shelltemp on, and running it with :! n

[PATCH] os_unix: remove unnecessary process group stuff

Processes are not being started correctly with TIOCSCTTY, which does succeed after setsid(). None of that stuff is necessary, including the silencing of SIGHUP. It's not even executed when shellpipe is off. Signed-off-by: Felipe Contreras --- src/os_unix.c | 21 - 1

Is :! buggy?

bug with :! not present with system()? Cheers. -- Felipe Contreras -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this mes

Re: [PATCH] netrw: make gx work again

On Sun, May 30, 2021 at 3:11 PM Felipe Contreras wrote: > > vim v8.1.1714 introduced a huge regression that basically made gx > unusable (see issue #4738) thanks to 85850f3a5 (Update runtime files, > 2019-07-19). Please don't reply to the original mail, reply to this one.

[PATCH] netrw: make gx work again

to induce the new behavior, but otherwise the old behavior is kept. This was backported from Charles Campbell's site (after the server finally decided to serve me). Fixes #4738. [1] http://www.drchip.org/astronaut/vim/index.html#NETRW Original-code-by: Charles E Campbell Signed-off-by: F

Re: [vim/vim] So many issues and pull requests with only one contributor? (#4518)

On Sunday, April 18, 2021 at 8:06:39 PM UTC-5 Gary Johnson wrote: > On 2021-04-18, Felipe Contreras wrote: > > Thanks for understanding. > > > > No, I don't understand. > > > > Any software developer doing things exactly the same as 10 years ago is

[PATCH] runtime: indent: fix assignment match

In Makefiles assignments can also be ':='. Signed-off-by: Felipe Contreras --- runtime/indent/make.vim | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/runtime/indent/make.vim b/runtime/indent/make.vim index 66a8a4017..4483efdbd 100644 --- a/runtime/indent/make

Re: Contributors deserve credit (from issue #7574)

On Thu, Dec 31, 2020 at 12:26 PM Dominique Pellé wrote: > > Felipe Contreras wrote: > > > On Thu, Dec 31, 2020 at 2:44 AM Christian Brabandt > > wrote: > > > On Mi, 30 Dez 2020, Felipe Contreras wrote: > > > > > > > On Wed, Dec

Re: Contributors deserve credit (from issue #7574)

On Thu, Dec 31, 2020 at 2:44 AM Christian Brabandt wrote: > On Mi, 30 Dez 2020, Felipe Contreras wrote: > > > On Wed, Dec 30, 2020 at 6:30 PM Tony Mechelynck > > wrote: > > > > > > Like Yegappan said, many contributors are mentioned under ":help > >

Re: Contributors deserve credit (from issue #7574)

On Thu, Dec 31, 2020 at 2:39 AM Christian Brabandt wrote: > > > On Mi, 30 Dez 2020, Felipe Contreras wrote: > > > On Wed, Dec 30, 2020 at 3:05 PM Bram Moolenaar wrote: > > > Felipe Contreras wrote: > > > > > > > On Wed, Dec 30, 2020 at 1:22 PM Ch

Re: Contributors deserve credit (from issue #7574)

On Thu, Dec 31, 2020 at 2:34 AM Christian Brabandt wrote: > On Mi, 30 Dez 2020, Felipe Contreras wrote: > > On Wed, Dec 30, 2020 at 4:33 PM Yegappan Lakshmanan > > wrote: > > > On Wed, Dec 30, 2020 at 2:01 PM Felipe Contreras > > > wrote: > > > &g

Re: Contributors deserve credit (from issue #7574)

rd, ball and bat: anyone is welcome to > play but he makes the rules. That's the naturalistic fallacy again. Yes, Bram can do whatever he wants, but that doesn't mean what he wants is necessarily the best for the project. No one is infallible. Cheers. -- Felipe Contreras -- --

Re: Contributors deserve credit (from issue #7574)

Hello, On Wed, Dec 30, 2020 at 4:33 PM Yegappan Lakshmanan wrote: > On Wed, Dec 30, 2020 at 2:01 PM Felipe Contreras > wrote: >> There are some credits, for some of the contributions, of some of the >> contributors. Not all, not even most. > > I have contributed man

Re: [PATCH] runtime: syntax: diff: fix for modern format

not outweigh the needs of the many. It doesn't make sense to make 99,999 programmers suffer all the time because 1 might make a mistake once. -- Felipe Contreras -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you

Re: Contributors deserve credit (from issue #7574)

On Wed, Dec 30, 2020 at 3:05 PM Bram Moolenaar wrote: > Felipe Contreras wrote: > > > On Wed, Dec 30, 2020 at 1:22 PM Christian Brabandt wrote: > > > > Am 30.12.2020 um 20:07 schrieb Felipe Contreras > > > > : > > > > > > Precisely.

Contributors deserve credit (from issue #7574)

On Wed, Dec 30, 2020 at 1:22 PM Christian Brabandt wrote: > > Am 30.12.2020 um 20:07 schrieb Felipe Contreras > > : > > Precisely. So if you think being "conservative" with what data is > > being collected is a good thing, then you do that. (Others might

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Wed, Dec 30, 2020 at 12:09 PM Christian Brabandt wrote: > > > Am 30.12.2020 um 18:49 schrieb Felipe Contreras > > : > > > > On Wed, Dec 30, 2020 at 11:38 AM Christian Brabandt > > wrote: > >>> Am 30.12.2020 um 18:05 schrieb Felipe Contreras &

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Wed, Dec 30, 2020 at 11:38 AM Christian Brabandt wrote: > > Am 30.12.2020 um 18:05 schrieb Felipe Contreras > > :. > >> I find it scary that I can dig up what someone has done a dozen years ago > >> in some repository. > > > > And what about the r

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Wed, Dec 30, 2020 at 10:48 AM Bram Moolenaar wrote: > > > Felipe Contreras wrote: > > > On Wed, Dec 30, 2020 at 8:11 AM Christian Brabandt > > wrote: > > > On Mi, 30 Dez 2020, Felipe Contreras wrote: > > > > Yes. I know there's no attribut

[PATCH 2/2] runtime: syntax: diff: automatically detect format

This way the correct ordering is always detected. Signed-off-by: Felipe Contreras --- runtime/syntax/diff.vim | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/runtime/syntax/diff.vim b/runtime/syntax/diff.vim index 31ca835bf..5673284d5 100644 --- a/runtime

[PATCH 1/2] runtime: syntax: diff: fix order of files

If the order of files is going to be wrong, it should be wrong on the vastly less used style: the older context format, not the newer unified format. Signed-off-by: Felipe Contreras --- runtime/syntax/diff.vim | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/runtime

[PATCH 0/2] runtime: syntax: diff: further fixes

Patch 8.2.2128 fixed one issue with the diff syntax, but we can do better. Felipe Contreras (2): runtime: syntax: diff: fix order of files runtime: syntax: diff: automatically detect format runtime/syntax/diff.vim | 15 ++- 1 file changed, 10 insertions(+), 5 deletions

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Wed, Dec 30, 2020 at 8:11 AM Christian Brabandt wrote: > On Mi, 30 Dez 2020, Felipe Contreras wrote: > > Yes. I know there's no attribution. > > > > Either there's attribution or there isn't. > > There is attribution to the changes in the Core C files,

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Wed, Dec 30, 2020 at 7:56 AM Christian Brabandt wrote: > On Mi, 30 Dez 2020, Felipe Contreras wrote: > > Didn't you just argued in issue #7574 that contributors are mentioned in > > the commit message? > > > > Where is my attribution? > > Are you trollin

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Wednesday, December 16, 2020 at 2:13:39 AM UTC-6 cbl...@256bit.org wrote: > > I think it has been included as of > https://github.com/vim/vim/commit/1b884a0053982335f644eec6c71027706bf3c522 > Didn't you just argued in issue #7574 that contributors are mentioned in the commit message? Whe

Missing cinoption?

"To quell this message you have two main options:\n" Why can't I tell vim to use a single shiftwidth and a single shiftwidth only? Cheers. -- Felipe Contreras -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the tex

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Mon, Dec 7, 2020 at 12:16 PM Felipe Contreras wrote: > > On Mon, Dec 7, 2020 at 11:54 AM Bram Moolenaar wrote: > > Felipe Contreras wrote: > > > > But it doesn't work. I want to distinguish the file ("^diff\>.*" aka > > > diffFile) from the n

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Mon, Dec 7, 2020 at 11:54 AM Bram Moolenaar wrote: > Felipe Contreras wrote: > > But it doesn't work. I want to distinguish the file ("^diff\>.*" aka > > diffFile) from the new file ("^+++ .*" aka diffNewFile). > > > > So in my col

Re: [PATCH] runtime: syntax: diff: fix for modern format

On Sun, Dec 6, 2020 at 11:51 AM Bram Moolenaar wrote: > > > Felipe Contreras wrote: > > > Nowadays most people use the unified diff, which has this format: > > > > --- a/foo > > +++ b/foo > > > > In that case the old file starts with '-

[PATCH] runtime: syntax: diff: fix for modern format

y default, and leave the option for users to use the old format with `diff_context = 1`. Signed-off-by: Felipe Contreras --- runtime/syntax/diff.vim | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/runtime/syntax/diff.vim b/runtime/syntax/diff.vim index b656cd97a..b9

[PATCH] runtime: syntax: vim: fix for end with space

A backslash followed by a character can be part of the end of a set command. Currently this doesn't match: "set fillchars+=vert:\ " But it should. Removing the skip makes it work. Signed-off-by: Felipe Contreras --- runtime/syntax/vim.vim | 2 +- 1 file changed, 1 insertion

Re: [PATCH v3 0/9] syntax: sh: heredoc fixes

On Monday, October 19, 2020 at 10:11:09 AM UTC-5 Christian wrote: > > On Mo, 19 Okt 2020, Felipe Contreras wrote: > > > It has been *six* years since I originally sent the patches and many of > the > > issues still remain. > > Thanks for that. Have you contact

[PATCH v3 6/9] syntax: sh: remove extra heredoc match

shHereDoc14 is already catching the backslash which makes the match functionally different, as it should be: \EOF is different from EOF. Signed-off-by: Felipe Contreras --- runtime/syntax/sh.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runtime/syntax/sh.vim b/runtime

[PATCH v3 7/9] syntax: sh: add missing match

The unshifted version of shHereDoc11 was missing, so this fails: cat <<\ \EOF this is $single EOF Signed-off-by: Felipe Contreras --- runtime/syntax/sh.vim | 3 +++ 1 file changed, 3 insertions(+) diff --git a/runtime/syntax/sh.vim b/runtime/syntax/sh.vim

[PATCH v3 9/9] syntax: sh: cleanup matches

Also standardize them. Signed-off-by: Felipe Contreras --- runtime/syntax/sh.vim | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/runtime/syntax/sh.vim b/runtime/syntax/sh.vim index ca55e09b1..ba4dc91e0 100644 --- a/runtime/syntax/sh.vim +++ b/runtime/syntax/sh.vim

[PATCH v3 5/9] syntax: sh: fix heredoc match

The spaces where missing (' \EOF'), so this wasn't working correctly: # 14 cat << \EOF this is $single EOF Signed-off-by: Felipe Contreras --- runtime/syntax/sh.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ru

[PATCH v3 0/9] syntax: sh: heredoc fixes

Hi, There are a lot of issues with the sh syntax for heredoc, these patches attempt to solve them. I counted at least eight bugs fixed. It has been *six* years since I originally sent the patches and many of the issues still remain. You can open this file and see for yourself. double='D

[PATCH v3 4/9] syntax: sh: remove duplicate syntax

Signed-off-by: Felipe Contreras --- runtime/syntax/sh.vim | 2 -- 1 file changed, 2 deletions(-) diff --git a/runtime/syntax/sh.vim b/runtime/syntax/sh.vim index b2a1df877..634502051 100644 --- a/runtime/syntax/sh.vim +++ b/runtime/syntax/sh.vim @@ -411,7 +411,6 @@ ShFoldHereDoc syn region

[PATCH v3 2/9] syntax: sh: fix quote style in heredoc

This was using the wrong quote style (single instead of double): # 10 cat <<-\ EOF this is $double EOF Signed-off-by: Felipe Contreras --- runtime/syntax/sh.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runtime/syntax/sh

[PATCH v3 1/9] syntax: sh: fix doublequote regression in heredoc

t;-\ \EOF this is $single EOF # 14 cat <<\EOF this is $single EOF # 15(16) cat <<-\EOF this is $single EOF Signed-off-by: Felipe Contreras --- runtime/syntax/sh.vim | 11 +-- 1 file changed,

[PATCH v3 3/9] syntax: sh: fix unmatched syntax

This wasn't working correctly (the EOF part isn't highlighted): # 16 cat <<-\EOF this is $single EOF Signed-off-by: Felipe Contreras --- runtime/syntax/sh.vim | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/runtime/syntax/

[PATCH v3 8/9] syntax: sh: reorganize heredocs

So that it makes sense what we are trying to do. No functional changes; just moving and renaming. Signed-off-by: Felipe Contreras --- runtime/syntax/sh.vim | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/runtime/syntax/sh.vim b/runtime/syntax

Re: [PATCH 0/3] syntax: sh: heredoc fixes

On Fri, Jun 14, 2019, 16:25 Bram Moolenaar wrote: > > Every maintainer has the freedom to use his choice of process. Some > have a github project where you can file an issue or pull request, some > just use email. Enforcing a certain way of working will increase the > bureden on maintainers, wh

Re: [PATCH 0/3] syntax: sh: heredoc fixes

I didn't contact the maintainer, it should be responsibility of him/her to be responsive to patches. His address on the syntax file is wrong anyway. He eventually replied, years later, not looking at my patches, and he didn't reply to me so I never got that response. He said he didn't read ever

Re: [PATCH 7/8] syntax: sh: fix heredoc with space delimiters

On Fri, Jun 14, 2019, 05:27 Bram Moolenaar wrote: > > [fixed the email address of Charles, you had NOSPAM still in there] > > > This works correctly for the shifted version, but not the unshifted: > > > > cat <<\ > > 'E O F' > > this is $single > > E O F > > Normally I would say to talk d

Re: [PATCH 0/3] syntax: sh: heredoc fixes

On Sat, Jun 4, 2016 at 3:51 PM Felipe Contreras wrote: > > On Thu, Oct 15, 2015 at 8:02 AM, Nikolay Pavlov wrote: > > 2015-10-15 14:03 GMT+03:00 Felipe Contreras : > >> On Thu, Oct 15, 2015 at 5:49 AM, Nikolay Pavlov wrote: > >>> 2015-10-15 13:10 GMT+03:0

[PATCH 4/8] syntax: sh: remove extra heredoc match

shHereDoc14 is already catching the \ which makes the match functionally different (not double quotes). Signed-off-by: Felipe Contreras --- runtime/syntax/sh.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runtime/syntax/sh.vim b/runtime/syntax/sh.vim index 077024a36

[PATCH 8/8] syntax: sh: reorganize heredocs

So that it makes sense what we are trying to do. No functional changes; just moving and renaming. Signed-off-by: Felipe Contreras --- runtime/syntax/sh.vim | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/runtime/syntax/sh.vim b/runtime/syntax

[PATCH 3/8] syntax: sh: fix heredoc match

The spaces where missing, this wasn't working correctly: cat << \EOF this is $single EOF Signed-off-by: Felipe Contreras --- runtime/syntax/sh.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runtime/syntax/sh.vim b/runtime/syntax/sh.vim index 384971344

[PATCH 7/8] syntax: sh: fix heredoc with space delimiters

This works correctly for the shifted version, but not the unshifted: cat <<\ 'E O F' this is $single E O F Signed-off-by: Felipe Contreras --- runtime/syntax/sh.vim | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/runtime/syntax/sh.vim b/runti

[PATCH 5/8] syntax: sh: fix quote style in heredoc

This was using the wrong quote: cat <<-\ EOF this is $double EOF Signed-off-by: Felipe Contreras --- runtime/syntax/sh.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runtime/syntax/sh.vim b/runtime/syntax/sh.vim index 16a36d30c..67eb5f90b 100644

[PATCH 1/8] syntax: sh: fix unmatched syntax

This wasn't working correctly: cat <<-\EOF this is $single EOF Signed-off-by: Felipe Contreras --- runtime/syntax/sh.vim | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/runtime/syntax/sh.vim b/runtime/syntax/sh.vim index b9c71de4c..a4704d61b 100644 --

[PATCH 2/8] syntax: sh: remove duplicate syntax

Signed-off-by: Felipe Contreras --- runtime/syntax/sh.vim | 2 -- 1 file changed, 2 deletions(-) diff --git a/runtime/syntax/sh.vim b/runtime/syntax/sh.vim index a4704d61b..384971344 100644 --- a/runtime/syntax/sh.vim +++ b/runtime/syntax/sh.vim @@ -396,7 +396,6 @@ ShFoldHereDoc syn region

[PATCH 6/8] syntax: sh: add missing match

The unshifted version of shHereDoc11 is missing, so this fails: cat <<\ \EOF this is $single EOF Signed-off-by: Felipe Contreras --- runtime/syntax/sh.vim | 2 ++ 1 file changed, 2 insertions(+) diff --git a/runtime/syntax/sh.vim b/runtime/syntax/sh.vim index 67eb5f90b..11e

[PATCH 0/8] syntax: sh: heredoc fixes

Hi, There are a lot of issues with the sh syntax for heredoc, these patches attempt to solve them. I counted at least five bugs fixed. You can open this file and see for yourself. double='DDOUBLE' # 01 cat

Re: [PATCH 0/3] syntax: sh: heredoc fixes

On Thu, Oct 15, 2015 at 8:02 AM, Nikolay Pavlov wrote: > 2015-10-15 14:03 GMT+03:00 Felipe Contreras : >> On Thu, Oct 15, 2015 at 5:49 AM, Nikolay Pavlov wrote: >>> 2015-10-15 13:10 GMT+03:00 Felipe Contreras : >>>> Hello? >>>> >>>> W

Re: [PATCH 0/3] syntax: sh: heredoc fixes

On Thu, Oct 15, 2015 at 5:49 AM, Nikolay Pavlov wrote: > 2015-10-15 13:10 GMT+03:00 Felipe Contreras : >> Hello? >> >> Why hasn't this been fixed? > > You need to CC file maintainer, not just list. Also do not top post. Really? The maintainer is not subscribed? -

Re: [PATCH 0/3] syntax: sh: heredoc fixes

Hello? Why hasn't this been fixed? On Fri, May 23, 2014 at 1:05 AM, Felipe Contreras wrote: > I noticed a bunch of issues while representing perfectly valid here documents. > > cat <<-\EOF > $foobar > EOF > > cat <<\ > EOF > $foobar

[PATCH 1/3] syntax: sh: improve heredoc delimiter identifier regex

There has to be at least one character, so we should use + instead of *. This makes the following: cat <<-\ EOF $foobar EOF Be matched by shRedir26 properly, instead of shRedir32, which doesn't work. Signed-off-by: Felipe Contreras --- runtime/syntax/

[PATCH 3/3] syntax: sh: add missing quoted heredoc syntax

Otherwise code such as: cat <<-\EOF $foobar EOF Is not matched properly, as vim assumes the delimiter is '\EOF', when in fact it's 'EOF'. Signed-off-by: Felipe Contreras --- runtime/syntax/sh.vim | 8 1 file changed, 8 insertions(+) diff --git a/

[PATCH 2/3] syntax: sh: fix representation of unquoted heredoc

Otherwise code such as: cat <<\ EOF $foobar EOF Is assumed to be single quoted, when it's double quoted. Signed-off-by: Felipe Contreras --- runtime/syntax/sh.vim | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/runtime/syntax/sh.vim b/runtime/sy

[PATCH 0/3] syntax: sh: heredoc fixes

I noticed a bunch of issues while representing perfectly valid here documents. cat <<-\EOF $foobar EOF cat <<\ EOF $foobar EOF cat <<-\ \EOF $foobar EOF Felipe Contreras (3): syntax: sh: improve heredoc delimiter identifier regex syntax: sh: fix