Re: [vim/vim] Add support for processing language server protocol messages (PR #10025)

2022-04-17 Fir de Conversatie Yegappan Lakshmanan
Hi, On Sun, Apr 17, 2022 at 3:04 PM Prabir Shrestha wrote: > I have tried the PR and it correctly parses the LSP message. Thanks for > the quick fix! > Thanks for verifying the fix. > Found another bug. Doc says that channel callback will return decoded > json rpc message as vim dict. > https

Re: Compile warning on ucrt build of mingw

2022-04-17 Fir de Conversatie John Marriott
On 17-Apr-2022 19:58, Bram Moolenaar wrote: John Marriott wrote: I recently started using a ucrt enabled build of mingw64 (gcc 11.2.0) which gives me this compile warning: gcc -c -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -D__USE_MI

Re: syntax file plsql.vim maintainer not reachable. Have patch.

2022-04-17 Fir de Conversatie Lee Lindley
acknowledged. Thanks Bram. On Sunday, April 17, 2022 at 4:37:40 PM UTC-4 Bram Moolenaar wrote: > > Lee Lindley wrote: > > > The listed maintainer email address for syntax file plsql.vim returns > mail > > as undeliverable and his online presence has not been updated in many > years. > > The syn

Re: Patch 8.2.4776

2022-04-17 Fir de Conversatie Christ van Willegen
Hi, Op zo 17 apr. 2022 22:17 schreef Bram Moolenaar : > > Dominique wrote: > > > I see typos in the comments of this commit 8.2.4776: > > > > > ! // Resize requests are made for gui.mainwin, > > > ! // get it's dimensions for searching if this event > > > > it's -> its > > > > ! // Lo

Patch 8.2.4779

2022-04-17 Fir de Conversatie Bram Moolenaar
Patch 8.2.4779 Problem:lsan suppression is too version specific. Solution: Leave out the version number. (Christian Brabandt, closes #10214) Files: src/testdir/lsan-suppress.txt *** ../vim-8.2.4778/src/testdir/lsan-suppress.txt 2022-04-16 20:04:26.174152095 +0100 --- src/testd

Re: syntax file plsql.vim maintainer not reachable. Have patch.

2022-04-17 Fir de Conversatie Bram Moolenaar
Lee Lindley wrote: > The listed maintainer email address for syntax file plsql.vim returns mail > as undeliverable and his online presence has not been updated in many years. > The syntax file has not kept up with changes to Oracle (19c is now > mainstream while syntax file only supports through

Re: [vim/vim] Add support for processing language server protocol messages (PR #10025)

2022-04-17 Fir de Conversatie Yegappan Lakshmanan
Hi Prabir, On Sat, Apr 16, 2022 at 11:06 PM Prabir Shrestha wrote: > Glad that you have a repro. Do watch out for perf issues though this can > be fixed along the way in the near future while the parsing bug is fixed. > In vim-lsp we have a pretty bad perf due to parsing where we concat strings

Re: [vim/vim] LSP messages are not parsed properly if the http header and json payload are received separately (PR #10215)

2022-04-17 Fir de Conversatie Christian Brabandt
On So, 17 Apr 2022, Yegappan Lakshmanan wrote: > Hi Christian, > > On Sun, Apr 17, 2022 at 1:15 PM Christian Brabandt > wrote: > > > Hi Yegappan, could that also fix the issue from the vim-win32-installer > repository? > > > > Is it possible to do one vim-win32-installer test run wi

Re: [vim/vim] LSP messages are not parsed properly if the http header and json payload are received separately (PR #10215)

2022-04-17 Fir de Conversatie Yegappan Lakshmanan
Hi Christian, On Sun, Apr 17, 2022 at 1:15 PM Christian Brabandt < vim-dev-git...@256bit.org> wrote: > Hi Yegappan, could that also fix the issue from the vim-win32-installer > repository? > > > Is it possible to do one vim-win32-installer test run with the LSP test enabled again ? Thanks, Yegap

Patch 8.2.4778

2022-04-17 Fir de Conversatie Bram Moolenaar
Patch 8.2.4778 Problem:Pacman files use dosini filetype. Solution: Use conf instead. (Chaoren Lin, closes #10213) Files: runtime/filetype.vim, src/testdir/test_filetype.vim *** ../vim-8.2.4777/runtime/filetype.vim2022-04-16 21:33:50.515066896 +0100 --- runtime/filetype.vim

Re: Patch 8.2.4776

2022-04-17 Fir de Conversatie Bram Moolenaar
Dominique wrote: > I see typos in the comments of this commit 8.2.4776: > > > ! // Resize requests are made for gui.mainwin, > > ! // get it's dimensions for searching if this event > > it's -> its > > ! // Look through history of recent vim resize reqeusts. > > requests -> reque

Re: syntax file plsql.vim maintainer not reachable. Have patch.

2022-04-17 Fir de Conversatie Lee Lindley
Oh gosh. The embedded quote solution turns out to be embarrasingly easy once I read the vim documentation on "region." But this is why I may not be suitable as a maintainer. I really do not know the "vim" programming world very well. OTOH, I know what Oracle SQL and PL/SQL should look like when

syntax file plsql.vim maintainer not reachable. Have patch.

2022-04-17 Fir de Conversatie lee.lindley
The listed maintainer email address for syntax file plsql.vim returns mail as undeliverable and his online presence has not been updated in many years. The syntax file has not kept up with changes to Oracle (19c is now mainstream while syntax file only supports through 9i). I have an update ( http

Re: syntax file plsql.vim maintainer not reachable. Have patch.

2022-04-17 Fir de Conversatie Lee Lindley
Hi Chris, I am an Oracle subject matter expert and pretty good with regular expressions, but not so much on vim. I could take the maintainer role if I must (as in if that is the only way to get this done, then yes). I would prefer to be available as a subject matter expert and let someone else

Re: Patch 8.2.4776

2022-04-17 Fir de Conversatie Dominique Pellé
Hi. I see typos in the comments of this commit 8.2.4776: > ! // Resize requests are made for gui.mainwin, > ! // get it's dimensions for searching if this event it's -> its ! // Look through history of recent vim resize reqeusts. requests -> requests Regards Dominique -- -- You

Patch 8.2.4777

2022-04-17 Fir de Conversatie Bram Moolenaar
Patch 8.2.4777 (after 8.2.4775) Problem:Screendump tests fail because of a redraw. Solution: Do not output t_8u before receiving termresponse. Redraw only when t_8u is not reset and termresponse is received. Files: src/term.c *** ../vim-8.2.4776/src/term.c 2022-04-17 17

Patch 8.2.4776

2022-04-17 Fir de Conversatie Bram Moolenaar
Patch 8.2.4776 Problem:GTK: 'lines' and 'columns' may change during startup. Solution: Ignore stale GTK resize events. (Ernie Rael, closes #10179) Files: src/gui_gtk_x11.c *** ../vim-8.2.4775/src/gui_gtk_x11.c 2022-04-15 13:53:30.052708679 +0100 --- src/gui_gtk_x11.c 2022-04-17 1

Re: [vim/vim] Add support for evaluating Vim expressions in a heredoc (PR #10138)

2022-04-17 Fir de Conversatie Bram Moolenaar
> I've never use vimscript, or the `=` that I see around occasionally. > From my perspective, whatever is consistent with what I'll see in > vim9script is best; `:help script` explains vim9. Consistency with > vim9 seems paramount. IMO, if the `=` is required in vim9 in > situations, then OK; oth

Patch 8.2.4775

2022-04-17 Fir de Conversatie Bram Moolenaar
Patch 8.2.4775 Problem:SpellBad highlighting does not work in Konsole. Solution: Do not keep t_8u defined for Konsole. Redraw when t_8u is reset. (closes #10177) Files: src/term.c *** ../vim-8.2.4774/src/term.c 2022-04-17 14:18:07.364733158 +0100 --- src/term.c 2022-04

Re: syntax file plsql.vim maintainer not reachable. Have patch.

2022-04-17 Fir de Conversatie Christian Brabandt
On So, 17 Apr 2022, Lee Lindley wrote: > The listed maintainer email address for syntax file plsql.vim returns mail as > undeliverable and his online presence has not been updated in many years. The > syntax file has not kept up with changes to Oracle (19c is now mainstream > while > syntax f

Patch 8.2.4774

2022-04-17 Fir de Conversatie Bram Moolenaar
Patch 8.2.4774 Problem:Crash when using a number for lambda name. Solution: Check the type of the lambda reference. Files: src/eval.c, src/errors.h, src/testdir/test_lambda.vim *** ../vim-8.2.4773/src/eval.c 2022-04-15 22:57:05.523488055 +0100 --- src/eval.c 2022-04-17 15:02:15.862

Re: [vim/vim] Add support for evaluating Vim expressions in a heredoc (PR #10138)

2022-04-17 Fir de Conversatie Yegappan Lakshmanan
Hi Bram, On Sun, Apr 17, 2022 at 3:51 AM Bram Moolenaar wrote: > I have not seen comments objecting to using the "=expr" form, including > the equal sign. So I guess it should be OK that way. > > > If you think using a single backquote will be easier and less confusing than using "`=", then we c

Patch 8.2.4773

2022-04-17 Fir de Conversatie Bram Moolenaar
Patch 8.2.4773 Problem:Build failure without the +eval feature. Solution: Use other error message. Avoid warnings. Files: src/misc1.c, src/cindent.c, src/term.c *** ../vim-8.2.4772/src/misc1.c 2022-04-17 14:01:46.645461121 +0100 --- src/misc1.c 2022-04-17 14:11:20.404554740 +0100 **

Patch 8.2.4772

2022-04-17 Fir de Conversatie Bram Moolenaar
Patch 8.2.4772 Problem:Old Coverity warning for not checking ftell() return value. Solution: Check return value of fseek() and ftell(). Files: src/misc1.c *** ../vim-8.2.4771/src/misc1.c 2022-04-15 23:29:19.410841325 +0100 --- src/misc1.c 2022-04-17 13:34:56.048904274 +0100 *

Patch 8.2.4771

2022-04-17 Fir de Conversatie Bram Moolenaar
Patch 8.2.4771 Problem:Coverity warns for not checking return value. Solution: Check return value of rettv_dict_alloc(). Files: src/channel.c *** ../vim-8.2.4770/src/channel.c 2022-04-16 10:40:59.081370588 +0100 --- src/channel.c 2022-04-17 13:16:34.280821050 +0100 **

Patch 8.2.4770

2022-04-17 Fir de Conversatie Bram Moolenaar
Patch 8.2.4770 Problem:Cannot easily mix expression and heredoc. Solution: Support `=expr` in heredoc. (Yegappan Lakshmanan, closes #10138) Files: runtime/doc/eval.txt, src/evalvars.c, src/userfunc.c, src/testdir/test_let.vim, src/testdir/test_vim9_assign.vim *** ../vim-8

syntax file plsql.vim maintainer not reachable. Have patch.

2022-04-17 Fir de Conversatie Lee Lindley
The listed maintainer email address for syntax file plsql.vim returns mail as undeliverable and his online presence has not been updated in many years. The syntax file has not kept up with changes to Oracle (19c is now mainstream while syntax file only supports through 9i). I have an update

Re: Compile warning on ucrt build of mingw

2022-04-17 Fir de Conversatie Bram Moolenaar
John Marriott wrote: > I recently started using a ucrt enabled build of mingw64 (gcc 11.2.0) > which gives me this compile warning: > > gcc -c -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 > -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -D__USE_MINGW_ANSI_STDIO > -pipe -march=nati

Patch 8.2.4769

2022-04-17 Fir de Conversatie Bram Moolenaar
Patch 8.2.4769 Problem:Build warning with UCRT. Solution: Adjust #ifdef for _wenviron. (John Marriott) Files: src/evalfunc.c *** ../vim-8.2.4768/src/evalfunc.c 2022-04-16 10:40:59.081370588 +0100 --- src/evalfunc.c 2022-04-17 10:55:25.960562114 +0100 *** *** 367