Re: [vim/vim] indistinguishable colors in vimdiff mode (#4071)

2020-12-21 Fir de Conversatie Maxim Kim
We try to address that issue with reimplementation of built-in colorschemes (desert, for example https://github.com/vim/colorschemes/pull/50), but `default` one is out of the scope as there is no default colorscheme. I think it would be nice to add `guifg` and `ctermfg` to Diff(Text|Change|Add)

Patch 8.2.2184

2020-12-21 Fir de Conversatie Bram Moolenaar
Patch 8.2.2184 Problem:Vim9: no error when using "2" for a line number. Solution: Give an error message if the line number is invalid. (closes #7492) Files: src/typval.c, src/evalfunc.c, src/testdir/test_vim9_builtin.vim, src/testdir/test_cursor_func.vim *** ../vim-8.2.21

Re: [vim/vim] indistinguishable colors in vimdiff mode (#4071)

2020-12-21 Fir de Conversatie Gary Johnson
On 2020-12-21, lacygoill wrote: > Personally, I think it should be automatically set to off upon entering > diff mode. You end up with two different sets of highlighting competing > with each other, the highlighting for the file type and the highlighting > for diff mode itself. It's

Patch 8.2.2183

2020-12-21 Fir de Conversatie Bram Moolenaar
Patch 8.2.2183 Problem:Vim9: value of 'edcompatible' and 'gdefault' are used. Solution: Ignore these deprecated options in Vim9 script. (closes #7508) Files: src/ex_cmds.c, src/testdir/test_vim9_cmd.vim *** ../vim-8.2.2182/src/ex_cmds.c 2020-12-21 19:59:04.565197736 +0100 --- s

Patch 8.2.2182

2020-12-21 Fir de Conversatie Bram Moolenaar
Patch 8.2.2182 Problem:Vim9: value of 'magic' is still relevant. Solution: Always behave like 'magic' is on in Vim9 script (closes #7509) Files: src/option.c, src/proto/option.pro, src/arglist.c, src/buffer.c, src/cmdexpand.c, src/ex_cmds.c, src/ex_docmd.c, src/ex_getln.c,

Re: vim9: script local function name starting with a lower-case letter

2020-12-21 Fir de Conversatie Bram Moolenaar
Yegappan wrote: > In legacy Vim scripts, a script local function prefixed with "s:" can > start with a lower-case letter. A Vim9 function explicitly prefixed > using "s:"can also start with a lower-case letter. > > But a vim9 function name that doesn't have an explicit "s:" prefix > cannot star

Patch 8.2.2181

2020-12-21 Fir de Conversatie Bram Moolenaar
Patch 8.2.2181 Problem:Valgrind warnings for using uninitialized value. Solution: Do not use "start" or "end" unless there is a match. Files: src/regexp_nfa.c, src/regexp_bt.c *** ../vim-8.2.2180/src/regexp_nfa.c2020-12-21 14:54:28.844116987 +0100 --- src/regexp_nfa.c2020-12-

Patch 8.2.2180

2020-12-21 Fir de Conversatie Bram Moolenaar
Patch 8.2.2180 Problem:Vim9: test for error after error is flaky. Solution: Wait for job to finish instead of a fixed delay. Files: src/testdir/test_vim9_script.vim *** ../vim-8.2.2179/src/testdir/test_vim9_script.vim2020-12-20 21:10:13.902437880 +0100 --- src/testdir/test_vim9_

Patch 8.2.2179

2020-12-21 Fir de Conversatie Bram Moolenaar
Patch 8.2.2179 Problem:Vim9: crash when indexing a dict with a number. Solution: Add ISN_STOREINDEX. (closes #7513) Files: src/vim9compile.c, src/vim9execute.c, src/vim9.h, src/errors.h, src/testdir/test_vim9_assign.vim, src/testdir/test_vim9_disassemble.vim *

vim9: script local function name starting with a lower-case letter

2020-12-21 Fir de Conversatie Yegappan Lakshmanan
Hi, In legacy Vim scripts, a script local function prefixed with "s:" can start with a lower-case letter. A Vim9 function explicitly prefixed using "s:"can also start with a lower-case letter. But a vim9 function name that doesn't have an explicit "s:" prefix cannot start with a lower-case letter

Patch 8.2.2178

2020-12-21 Fir de Conversatie Bram Moolenaar
Patch 8.2.2178 Problem:Python 3: non-utf8 character cannot be handled. Solution: Change the string decode. (Björn Linse, closes #1053) Files: src/if_py_both.h, src/if_python.c, src/if_python3.c, src/testdir/test_python3.vim, src/testdir/test_python2.vim *** ../vim-8.2.217

Patch 8.2.2177

2020-12-21 Fir de Conversatie Bram Moolenaar
Patch 8.2.2177 Problem:Pattern "^" does not match if the first character in the line is combining. (Rene Kita) Solution: Do accept a match at the start of the line. (closes #6963) Files: src/regexp_nfa.c, src/testdir/test_regexp_utf8.vim *** ../vim-8.2.2176/src/regexp_nfa

Patch 8.2.2176

2020-12-21 Fir de Conversatie Bram Moolenaar
Patch 8.2.2176 Problem:Crash with a sequence of fold commands. Solution: Bail out when there are no folds at all. Add a test (Dominique Pellé) (closes #7515) Files: src/fold.c, src/testdir/test_fold.vim *** ../vim-8.2.2175/src/fold.c 2020-11-10 18:23:47.870506514 +0100

Patch 8.2.2175

2020-12-21 Fir de Conversatie Bram Moolenaar
Patch 8.2.2175 Problem:Github actions: clang-11 handling suboptimal. Solution: Separate step of installing clang-11. Get ubuntu release name dynamically. (Ozaki Kiichi, closes #7514) Files: .github/workflows/ci.yml *** ../vim-8.2.2174/.github/workflows/ci.yml2020-12-1

Patch 8.2.2174

2020-12-21 Fir de Conversatie Bram Moolenaar
Patch 8.2.2174 Problem:Mac version doesn't specify the CPU architecture. Solution: Add "arm64" or "x86_64". (Yee Cheng Chin, closes #7519) Files: src/version.c *** ../vim-8.2.2173/src/version.c 2020-12-20 21:43:31.704882194 +0100 --- src/version.c 2020-12-21 13:05:32.3115