Re: [vim/vim] feat: make it possible to restore default highlighting (#6956)

2020-09-16 Fir de Conversatie Maxim Kim
With the new patch user would not need to 'syntax on' to really apply a new colorscheme as the information about default links is kept and applied on highlight_clear(). PS, I believe previous patch (wrt treating cleared group as has no settings) is still good to have though. -- -- You rece

Re: [vim/vim] feat: make it possible to restore default highlighting (#6956)

2020-09-16 Fir de Conversatie Maxim Kim
среда, 16 сентября 2020 г. в 22:55:00 UTC+3, Maxim Kim: > It is in an old PR as a new commit, I can make it as a separate PR. > > > > ср, 16 сент. 2020 г., 22:50 Bram Moolenaar : > > > > E.g. syntax/html.vim links htmlTagName to Statement, but a fancy > > > colorscheme may choose to give htmlTag

Patch 8.2.1701

2020-09-16 Fir de Conversatie Bram Moolenaar
Patch 8.2.1701 Problem:Vim9: sort("i") does not work. Solution: Don't try getting a number for a string argument. (closes #6958) Files: src/list.c, src/testdir/test_vim9_func.vim *** ../vim-8.2.1700/src/list.c 2020-09-16 21:08:23.642361197 +0200 --- src/list.c 2020-09-16 23:22:06.8

Patch 8.2.1700

2020-09-16 Fir de Conversatie Bram Moolenaar
Patch 8.2.1700 Problem:Vim9: try/catch causes wrong value to be returned. Solution: Reset tcd_return. (closes #6964) Files: src/vim9execute.c, src/testdir/test_vim9_script.vim *** ../vim-8.2.1699/src/vim9execute.c 2020-09-16 17:22:54.923689811 +0200 --- src/vim9execute.c 2020-09-

Re: [vim/vim] Add the matchfuzzy() function (#6932)

2020-09-16 Fir de Conversatie Bram Moolenaar
Yegappan wrote: > On Wed, Sep 16, 2020 at 8:56 AM Bram Moolenaar wrote: > > > > > > On Wed, Sep 16, 2020 at 3:23 AM Maxim Kim wrote: > > > > > > > =D0=B2=D1=82=D0=BE=D1=80=D0=BD=D0=B8=D0=BA, 15 =D1=81=D0=B5=D0=BD=D1= > =82=D1=8F=D0=B1=D1=80=D1=8F 2020 =D0=B3. =D0=B2 22:34:33 UTC+3, bfrg: > >

Patch 8.2.1699

2020-09-16 Fir de Conversatie Bram Moolenaar
Patch 8.2.1699 Problem:Build failure due to missing error message. Solution: Add error message. Files: src/errors.h *** ../vim-8.2.1698/src/errors.h2020-09-16 17:55:36.537602345 +0200 --- src/errors.h2020-09-16 19:52:54.837541691 +0200 *** *** 266,269

Re: Patch 8.2.1698

2020-09-16 Fir de Conversatie John Marriott
On 17-Sep-2020 05:08, Bram Moolenaar wrote: Patch 8.2.1698 Problem:Cannot lock a variable in legacy Vim script like in Vim9. Solution: Make ":lockvar 0" work. Files: runtime/doc/eval.txt, src/evalvars.c, src/proto/evalvars.pro, src/dict.c, src/eval.c, src/list.c, src/ty

Patch 8.2.1698

2020-09-16 Fir de Conversatie Bram Moolenaar
Patch 8.2.1698 Problem:Cannot lock a variable in legacy Vim script like in Vim9. Solution: Make ":lockvar 0" work. Files: runtime/doc/eval.txt, src/evalvars.c, src/proto/evalvars.pro, src/dict.c, src/eval.c, src/list.c, src/typval.c, src/userfunc.c, src/testdir/

Re: tinytests can fail if .ok fileformat is wong (Make_ming.mak)

2020-09-16 Fir de Conversatie M. Soyka
On Wed, Sep 16, 2020 at 9:42 AM Bram Moolenaar wrote: > > Michael Soyka wrote: > > > Using Make_ming.mak, the "tinytests" collection of build tests will fail > if > > the associated .ok file has Windows line endings. This happens because > the > > test.out file is explicitly set to have unix/lin

Re: [vim/vim] Add the matchfuzzy() function (#6932)

2020-09-16 Fir de Conversatie Yegappan Lakshmanan
Hi Bram, On Wed, Sep 16, 2020 at 8:56 AM Bram Moolenaar wrote: > > > On Wed, Sep 16, 2020 at 3:23 AM Maxim Kim wrote: > > > > > вторник, 15 сентября 2020 г. в 22:34:33 UTC+3, bfrg: > > > > > >> But matchfuzzy() returns only a list of byte indexes (column > numbers). > > >> > > >> Does that mea

Patch 8.2.1697

2020-09-16 Fir de Conversatie Bram Moolenaar
Patch 8.2.1697 Problem:Inconsistent capitalization of error messages. Solution: Always start with a capital. Files: src/errors.h, src/testdir/test_vim9_expr.vim, src/testdir/test_vim9_func.vim, src/testdir/test_vim9_script.vim, src/testdir/test_assert.vim ***

Re: [vim/vim] Add the matchfuzzy() function (#6932)

2020-09-16 Fir de Conversatie Bram Moolenaar
> On Wed, Sep 16, 2020 at 3:23 AM Maxim Kim wrote: > > > вторник, 15 сентября 2020 г. в 22:34:33 UTC+3, bfrg: > > > >> But matchfuzzy() returns only a list of byte indexes (column numbers). > >> > >> Does that mean we wouldn't be able to match unicode (cyrillic for > > example)? > > Currently

Patch 8.2.1696

2020-09-16 Fir de Conversatie Bram Moolenaar
Patch 8.2.1696 Problem:Unused (duplicate) macros. Solution: Remove the macros. Files: src/spell.c *** ../vim-8.2.1695/src/spell.c 2020-06-11 12:30:09.281198615 +0200 --- src/spell.c 2020-09-16 16:49:44.688498620 +0200 *** *** 66,75 #define REGION_ALL 0xff

Patch 8.2.1695

2020-09-16 Fir de Conversatie Bram Moolenaar
Patch 8.2.1695 Problem:Vim9: crash when using varargs type "any". Solution: Check if uf_va_type is &t_any. (closes #6957) Files: src/vim9compile.c, src/vim9execute.c, src/testdir/test_vim9_func.vim *** ../vim-8.2.1694/src/vim9compile.c 2020-09-16 15:21:56.354720354 +020

Re: [vim/vim] Add the matchfuzzy() function (#6932)

2020-09-16 Fir de Conversatie Yegappan Lakshmanan
Hi, On Wed, Sep 16, 2020 at 3:23 AM Maxim Kim wrote: > > > вторник, 15 сентября 2020 г. в 22:34:33 UTC+3, bfrg: > >> But matchfuzzy() returns only a list of byte indexes (column numbers). >> >> Does that mean we wouldn't be able to match unicode (cyrillic for > example)? > > Currently the matc

Patch 8.2.1694

2020-09-16 Fir de Conversatie Bram Moolenaar
Patch 8.2.1694 Problem:Compiler warning for loss if data. Solution: Add typecast. Files: src/ops.c *** ../vim-8.2.1693/src/ops.c 2020-09-15 21:34:14.998383526 +0200 --- src/ops.c 2020-09-16 15:44:49.241373551 +0200 *** *** 2840,2846 // Delete the one

Patch 8.2.1693

2020-09-16 Fir de Conversatie Bram Moolenaar
Patch 8.2.1693 Problem:"hi def" does not work for cleared highlight. Solution: Check the "sg_cleared" flag. (Maxim Kim, closes #6956, closes #4405) Files: src/highlight.c, src/testdir/test_highlight.vim *** ../vim-8.2.1692/src/highlight.c 2020-06-28 13:17:07.547811047

Re: tinytests can fail if .ok fileformat is wong (Make_ming.mak)

2020-09-16 Fir de Conversatie Bram Moolenaar
Michael Soyka wrote: > Using Make_ming.mak, the "tinytests" collection of build tests will fail if > the associated .ok file has Windows line endings. This happens because the > test.out file is explicitly set to have unix/linux line endings but the .ok > file has not been converted and so "

Patch 8.2.1692

2020-09-16 Fir de Conversatie Bram Moolenaar
Patch 8.2.1692 Problem:Build fails because TTFLAG_STATIC is missing. Solution: Include missing change. Files: src/structs.h *** ../vim-8.2.1691/src/structs.h 2020-09-09 22:27:55.425537078 +0200 --- src/structs.h 2020-09-16 12:16:00.284855937 +0200 *** *** 1374

Re: Patch 8.2.1691

2020-09-16 Fir de Conversatie Cesar Romani
I'm building vim on Windows 7 using MinGW-W64, gcc 8.1.0. On building the latest pull, I get: [...] In file included from main.c:11: globals.h:394:50: error: 'TTFLAG_STATIC' undeclared here (not in a function); did you mean 'VAR_STATIC'? EXTERN type_T t_unknown INIT6(VAR_UNKNOWN, 0, 0, TTFLAG_S

Patch 8.2.1691

2020-09-16 Fir de Conversatie Bram Moolenaar
Patch 8.2.1691 Problem:Vim9: list is not accepted where list is expected. Solution: Add functions to allocate and free a type_T, use it in ISN_CHECKTYPE. (closes #6959) Files: src/vim9.h, src/globals.h, src/vim9compile.c, src/vim9execute.c, src/vim9type.c, src/p

Re: [vim/vim] feat: make it possible to restore default highlighting (#6956)

2020-09-16 Fir de Conversatie Maxim Kim
среда, 16 сентября 2020 г. в 15:05:55 UTC+3, Maxim Kim: > > > среда, 16 сентября 2020 г. в 14:29:04 UTC+3, Antony Scriven: > >> >> > I think that proper check for cleared in 'hl_has_settings' is simpler >> > though. >> >> Yeah I know. I'm only mentioning this alternative because it doesn't

Re: [vim/vim] feat: make it possible to restore default highlighting (#6956)

2020-09-16 Fir de Conversatie Maxim Kim
среда, 16 сентября 2020 г. в 14:29:04 UTC+3, Antony Scriven: > > > I think that proper check for cleared in 'hl_has_settings' is simpler > > though. > > Yeah I know. I'm only mentioning this alternative because it doesn't > require that syntax is reloaded. This seems to be welcome behaviour

Re: [vim/vim] feat: make it possible to restore default highlighting (#6956)

2020-09-16 Fir de Conversatie Antony Scriven
On Sep 16, Maxim Kim wrote: > среда, 16 сентября 2020 г. в 03:38:37 UTC+3, Antony Scriven: > > > In case I wasn't clear before, I'm wondering if could you save sg_link > > > in do_highlight() when doing ":hi def link", and then restore it in > > > highlight_clear(). Or would there be unintend

Re: [vim/vim] Add the matchfuzzy() function (#6932)

2020-09-16 Fir de Conversatie Maxim Kim
вторник, 15 сентября 2020 г. в 22:34:33 UTC+3, bfrg: > But matchfuzzy() returns only a list of byte indexes (column numbers). > > Does that mean we wouldn't be able to match unicode (cyrillic for example)? > — > You are receiving this because you commented. > Reply to this email directly, v

Re: [vim/vim] feat: make it possible to restore default highlighting (#6956)

2020-09-16 Fir de Conversatie Maxim Kim
среда, 16 сентября 2020 г. в 03:38:37 UTC+3, Antony Scriven: > In case I wasn't clear before, I'm wondering if could you save sg_link >> in do_highlight() when doing ":hi def link", and then restore it in >> highlight_clear(). Or would there be unintended consequences? >> >> I've not had any hi