Re: [vim/vim] Add the matchfuzzy() function (#6932)

2020-09-14 Fir de Conversatie Maxim Kim
On 14.09.2020 17:38, Bram Moolenaar wrote: Sergey Vlasov wrote: ... ``` [ ["clay", ["c", 0, 0], ["ay", 2, 3] ] ] ``` That makes it a lot more complex. What is the practical use for the match positions? Something like this is needed if one wants to highlight matc

Re: Remaining stuff from Building GUI Vim on MacOS

2020-09-14 Fir de Conversatie Yee Cheng Chin
Sorry for the late reply (had an overly aggressive email filter that has since been modified) and seems like you already removed it anyway, but I don't think it' used so it was fine to remove. On Sat, Aug 22, 2020 at 4:01 PM Yegappan Lakshmanan wrote: > Hi Bram, > > On Thu, Aug 20, 2020 at 7:17

Re: [vim/vim] Add the matchfuzzy() function (#6932)

2020-09-14 Fir de Conversatie Yegappan Lakshmanan
Hi, On Mon, Sep 14, 2020 at 12:52 PM Prabir Shrestha wrote: > matchfuzzypos sounds good to me. Thought I would prefer different type > for results. > > [ > \ ['string1', 'string2'], > \ [ [[0, 2, 4]], [[1,3,5]] ] > \ ] > > or > > { > \ 'items': ['string1', 'string2'], > \ 'highlights'

Patch 8.2.1687

2020-09-14 Fir de Conversatie Bram Moolenaar
Patch 8.2.1687 Problem:Vim9: out of bounds error. Solution: Check that cmdidx is not negative. Files: src/vim9compile.c *** ../vim-8.2.1686/src/vim9compile.c 2020-09-14 22:23:50.641827118 +0200 --- src/vim9compile.c 2020-09-14 22:37:39.269596581 +0200 *** *** 6903,690

Patch 8.2.1686

2020-09-14 Fir de Conversatie Bram Moolenaar
Patch 8.2.1686 Problem:Vim9: "const!" not sufficiently tested. Solution: Add a few more test cases. Fix type checking. Files: src/vim9compile.c, src/testdir/test_vim9_script.vim *** ../vim-8.2.1685/src/vim9compile.c 2020-09-14 21:38:47.756976285 +0200 --- src/vim9compile.c 2020-

Patch 8.2.1685

2020-09-14 Fir de Conversatie Bram Moolenaar
Patch 8.2.1685 Problem:Vim9: cannot declare a constant value. Solution: Introduce ":const!". Files: runtime/doc/vim9.txt, src/ex_cmds.h, src/vim9compile.c, src/vim9.h, src/vim9execute.c, src/evalvars.c, src/proto/evalvars.pro, src/errors.h, src/vim.h, src/eval.c

Re: [vim/vim] Add the matchfuzzy() function (#6932)

2020-09-14 Fir de Conversatie Yegappan Lakshmanan
Hi, On Mon, Sep 14, 2020 at 10:13 AM Bram Moolenaar wrote: > > > > Internally, the fuzzy_match() function does have this information in > > > an array (matches). But returning this for a large number of matched > > > items will increase the run time of this function. As Bram asked, > > > what is

Re: [vim/vim] Add the matchfuzzy() function (#6932)

2020-09-14 Fir de Conversatie Dominique Pellé
Maxim Kim wrote: > To be able to show the user what was matched, like fzf, leaderf, vim-clap or > ctrlp do: > > https://i.imgur.com/FogkBBH.png In your screenshot example I see that the search string is "pa li" (with a space) and the results don't contain spaces. They contain slashes as in "pac

Patch 8.2.1684

2020-09-14 Fir de Conversatie Bram Moolenaar
Patch 8.2.1684 Problem:"gF" does not use line number after file in Visual mode. Solution: Look for ":123" after the Visual area. (closes #6952) Files: src/findfile.c, src/testdir/test_gf.vim *** ../vim-8.2.1683/src/findfile.c 2020-06-24 20:33:59.565106319 +0200 --- src/findfile.

Patch 8.2.1683

2020-09-14 Fir de Conversatie Bram Moolenaar
Patch 8.2.1683 Problem:Vim9: assignment test fails. Solution: Include changes to find Ex command. Files: src/ex_docmd.c *** ../vim-8.2.1682/src/ex_docmd.c 2020-09-14 16:37:30.906845912 +0200 --- src/ex_docmd.c 2020-09-14 18:09:11.086579727 +0200 *** *** 3224,324

Patch 8.2.1682

2020-09-14 Fir de Conversatie Bram Moolenaar
Patch 8.2.1682 Problem:Vim9: const works in an unexpected way. Solution: ":const" only disallows changing the variable, not the value. Make "list[0] = 9" work at the script level. Files: src/vim9compile.c, src/evalvars.c, src/testdir/test_vim9_script.vim *** ../vim-8.2.16

Re: [vim/vim] Add the matchfuzzy() function (#6932)

2020-09-14 Fir de Conversatie Yegappan Lakshmanan
Hi, On Mon, Sep 14, 2020 at 2:18 AM Sergey Vlasov wrote: > With the proposed API there is no way to know what portions of the input > are matched. > > Example: > > :echo matchfuzzy(['clay', 'crow'], "cay") > < results in ['clay']. > > > It would be more useful to also return the

Patch 8.2.1681

2020-09-14 Fir de Conversatie Bram Moolenaar
Patch 8.2.1681 Problem:Vim9: unnessary :call commands in tests. Solution: Remove the commands. (issue #6936) Files: src/testdir/test_vim9_func.vim, src/testdir/test_vim9_script.vim *** ../vim-8.2.1680/src/testdir/test_vim9_func.vim 2020-09-12 18:32:30.683427305 +0200 --- src/te

Patch 8.2.1680

2020-09-14 Fir de Conversatie Bram Moolenaar
Patch 8.2.1680 Problem:Vim9: line number for compare error is wrong. Solution: Set SOURCING_LNUM. (closes #6936) Files: src/vim9execute.c, src/testdir/test_vim9_expr.vim *** ../vim-8.2.1679/src/vim9execute.c 2020-09-12 19:11:19.675415067 +0200 --- src/vim9execute.c 2020-09-14 16:

Re: [vim/vim] Add the matchfuzzy() function (#6932)

2020-09-14 Fir de Conversatie Bram Moolenaar
Sergey Vlasov wrote: > With the proposed API there is no way to know what portions of the > input are matched. > > ``` > Example: > > :echo matchfuzzy(['clay', 'crow'], "cay") > < results in ['clay']. > > ``` > > It would be more useful to also return the start position and the

Patch 8.2.1679

2020-09-14 Fir de Conversatie Bram Moolenaar
Patch 8.2.1679 Problem:Vim9: ":*" is not recognized as a range. Solution: Move recognizing "*" into skip_range(). (closes #6838) Files: src/ex_docmd.c, src/proto/ex_docmd.pro, src/cmdexpand.c, src/ex_getln.c, src/userfunc.c, src/vim9compile.c, src/testdir/test_v