Re: [vim/vim] Move all the find file related functions to a separate file (#3934)

2019-02-19 Fir de Conversatie Yegappan Lakshmanan
Hi, On Tue, Feb 19, 2019 at 1:20 PM Andy Massimino wrote: > > I noticed simplify_filename() is used by findfile.c and elsewhere, but > resides in tag.c. Probably should be put into findfile.c instead. > Currently all the functions related to FEAT_SEARCHPATH and FEAT_PATH_EXTRA feature macros are

Warning in Tiny and Small (only) at ex_cmds.c:557:43 after applying patches 953 to 956

2019-02-19 Fir de Conversatie Tony Mechelynck
After applying patches (8.1.) 953 to 956 I get the following warning in Tiny and Small builds (only): gcc -c -I. -Iproto -DHAVE_CONFIG_H -O2 -fno-strength-reduce -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1-o objects/ex_cmds.o ex_cmds.c ex_cmds.c: In function ‘ex_sort’: ex_cmds.c:557:43

Patch 8.1.0956

2019-02-19 Fir de Conversatie Bram Moolenaar
Patch 8.1.0956 Problem:Using context:0 in 'diffopt' does not work well. Solution: Make zero context do the same as one line context. (closes #4005) Files: src/diff.c, src/testdir/test_diffmode.vim, src/testdir/dumps/Test_diff_06.0.dump, src/testdir/dumps/Test_di

Patch 8.1.0955

2019-02-19 Fir de Conversatie Bram Moolenaar
Patch 8.1.0955 Problem:Matchit autoload directory not in installer. (Chris Morgan) Solution: Adjust the NSIS script. (Christian Brabandt, closes #4006) Files: nsis/gvim.nsi *** ../vim-8.1.0954/nsis/gvim.nsi 2018-12-21 17:59:30.100109769 +0100 --- nsis/gvim.nsi 2019-02-19

Patch 8.1.0954

2019-02-19 Fir de Conversatie Bram Moolenaar
Patch 8.1.0954 Problem:Arguments of semsg() and siemsg() are not checked. Solution: Add function prototype with __attribute__. Files: src/message.c, src/proto/message.pro, src/proto.h *** ../vim-8.1.0953/src/message.c 2019-02-17 17:44:36.215875493 +0100 --- src/message.c

Patch 8.1.0953

2019-02-19 Fir de Conversatie Bram Moolenaar
Patch 8.1.0953 Problem:A very long file is truncated at 2^31 lines. Solution: Use LONG_MAX for MAXLNUM. (Dominique Pelle, closes #4011) Files: src/vim.h *** ../vim-8.1.0952/src/vim.h 2019-02-18 21:41:34.477750367 +0100 --- src/vim.h 2019-02-19 21:24:24.887720755 +0100 ***

Re: Patch to add functions for manipulating the tag stack of a window

2019-02-19 Fir de Conversatie Yegappan Lakshmanan
Hi Christian, On Tue, Feb 19, 2019 at 9:16 AM Christian Brabandt wrote: > > Am 2019-02-19 14:37, schrieb Robert Webb: > > Language Server Protocol for Vim looks like what I really want, > > thanks! This would supersede my SmartTag patch (at the expense of > > being far more complicated). > > > >

Re: Patch to add functions for manipulating the tag stack of a window

2019-02-19 Fir de Conversatie Andy Massimino
On 2/19/19 12:16 PM, Christian Brabandt wrote: Does that mean we can drop the patch in favor of a an existing LSP integration with Vim? I think a tagfunc (or some other programmatic hook into tags) is still necessary to have proper LSP integration.  Current LSP plugins do not work natively

Re: Patch to add functions for manipulating the tag stack of a window

2019-02-19 Fir de Conversatie Christian Brabandt
Am 2019-02-19 14:37, schrieb Robert Webb: Language Server Protocol for Vim looks like what I really want, thanks! This would supersede my SmartTag patch (at the expense of being far more complicated). But I'm on Windows and there don't seem to be any servers ready compiled for use. Nor do they

Re: Patch to add functions for manipulating the tag stack of a window

2019-02-19 Fir de Conversatie Yegappan Lakshmanan
Hi, On Tue, Feb 19, 2019 at 8:18 AM Yegappan Lakshmanan wrote: > > On Tue, Feb 19, 2019 at 5:38 AM Robert Webb wrote: > > > > Language Server Protocol for Vim looks like what I really want, thanks! > > This > > would supersede my SmartTag patch (at the expense of being far more > > complicated

Re: Patch to add functions for manipulating the tag stack of a window

2019-02-19 Fir de Conversatie Yegappan Lakshmanan
Hi, On Tue, Feb 19, 2019 at 5:38 AM Robert Webb wrote: > > Language Server Protocol for Vim looks like what I really want, thanks! This > would supersede my SmartTag patch (at the expense of being far more > complicated). > > But I'm on Windows and there don't seem to be any servers ready compil

Re: [win32][patch] executable() may fail on very long filename

2019-02-19 Fir de Conversatie ktakata65536
Hi, 2018/10/8 Mon 10:50:46 UTC+9 Ken Takata wrote: > Hi, > > 2016/2/2 Tue 7:11:32 UTC+9 Bram Moolenaar wrote: > > Ken Takata wrote: > > > > > When 'enc' is utf-8, executable() may fail on very long filename which is > > > longer than _MAX_PATH bytes in UTF-8 and shorter than _MAX_PATH character

Re: Patch to add functions for manipulating the tag stack of a window

2019-02-19 Fir de Conversatie Robert Webb
Language Server Protocol for Vim looks like what I really want, thanks! This would supersede my SmartTag patch (at the expense of being far more complicated). But I'm on Windows and there don't seem to be any servers ready compiled for use. Nor do they look like they'll be straight forward to com

Re: Behavior of gn/gN is not consistent with n/N

2019-02-19 Fir de Conversatie Tony Mechelynck
On Tue, Feb 19, 2019 at 7:35 AM Christian Brabandt wrote: > > > On Mo, 18 Feb 2019, Jason Franklin wrote: > > > Greetings, > > > > Trying to figure out if this is intentional or not. It is definitelya > > backward search? > > surprising given how the documentation (":h gn") is written. > > > > T