Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-27 Thread Mark Thomas
On 26/07/2023 21:53, Christopher Schultz wrote: Mark, On 7/26/23 13:58, Mark Thomas wrote: I'm not a huge fan of this feature in general. I prefer supporting features backed by specifications rather than vendor specific hacks. I think the PROXY protocol is fairly standard, even if it's not ba

Re: Possible AbstractProtocol.waitingProcessors leak in Tomcat 9.0.75

2023-07-27 Thread Mark Thomas
I've taken a look at the code and can't see how this might be happening. I think a reproducible test case is going to be required to investigate this further. Mark On 12/07/2023 09:25, Mark Thomas wrote: Hi Mario, That does look like a possible bug. I'll try and do a code review before the

Re: Pinned threads for HTTP2 using Virtual Threads on Tomcat 10.1.7

2023-07-27 Thread Mark Thomas
I've refactored things to the point where the unit tests run without generating any warnings for pinning. I suspect further issues will be identified over time and we can address those as they are found. Mark On 25/07/2023 10:21, Mark Thomas wrote: Never mind. Pretty much as soon as I hit sen

Re: Possible AbstractProtocol.waitingProcessors leak in Tomcat 9.0.75

2023-07-27 Thread mario
I also spent quite some time already to create such a test case, but did not yet manage to find something. For now it works in Production to remove those dangling processes once per hour (via bad reflection stuff ;-) ) … will try to add some logging to probably get a grasp about what is going on

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-27 Thread Jonathan S. Fisher
On the topic of security, may we consider a trustedProxies setting? This would be an analog to the internalProxies setting on RemoteIpValve. It would need to be able to function with APR/NIO listening in a Unix Domain Socket. I'm not sure if this is super useful, but the goal would be an added lay

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-27 Thread Mark Thomas
On 27/07/2023 16:27, Jonathan S. Fisher wrote: On the topic of security, may we consider a trustedProxies setting? Seems reasonable. Mark This would be an analog to the internalProxies setting on RemoteIpValve. It would need to be able to function with APR/NIO listening in a Unix Domain Soc

Re: [External] Re: Supporting Proxy Protocol in Tomcat

2023-07-27 Thread Christopher Schultz
All, On 7/27/23 12:39, Mark Thomas wrote: On 27/07/2023 16:27, Jonathan S. Fisher wrote: On the topic of security, may we consider a trustedProxies setting? Seems reasonable. We should probably look at what httpd did for all of this. -chris  This would be an analog to the internalProxies