Chris,
Did you managed to check the PR?
Lazar
On Tue, Mar 10, 2020 at 5:41 PM Lazar Kirchev
wrote:
> Chris,
>
> Any update on this? Did you have a chance to have a look on the PR?
>
> Lazar
>
> On Wed, Mar 4, 2020 at 10:55 AM Lazar Kirchev
> wrote:
>
>> Chris, Martin,
>>
>> Here is the PR: ht
Chris,
Any update on this? Did you have a chance to have a look on the PR?
Lazar
On Wed, Mar 4, 2020 at 10:55 AM Lazar Kirchev
wrote:
> Chris, Martin,
>
> Here is the PR: https://github.com/apache/tomcat/pull/252
>
> Lazar
>
> On Sat, Feb 29, 2020 at 8:27 AM Martin Grigorov
> wrote:
>
>> On F
Chris, Martin,
Here is the PR: https://github.com/apache/tomcat/pull/252
Lazar
On Sat, Feb 29, 2020 at 8:27 AM Martin Grigorov
wrote:
> On Fri, Feb 28, 2020 at 7:31 PM Lazar Kirchev
> wrote:
>
> > Chris,
> >
> > I just thought that I have some concerns passing a map with the headers
> to
> >
On Fri, Feb 28, 2020 at 7:31 PM Lazar Kirchev
wrote:
> Chris,
>
> I just thought that I have some concerns passing a map with the headers to
> generateCookie() method. This means that for each call the caller will have
> to read all headers from the coyote.Response and put them in a map, even if
Chris,
I just thought that I have some concerns passing a map with the headers to
generateCookie() method. This means that for each call the caller will have
to read all headers from the coyote.Response and put them in a map, even if
the CookieProcessor will not need them, as is the case with the
Chris,
Actually in my preferred option the implementation in the
CookieProcessorBase should not be no-op, but it should call
CookieProcessor.generateCookie(Cookie). And the calls to
CookieProcessor.generateCookie(Cookie) in o.a.c.connector.Response and
o.a.c.core.ApplicationPushBuilder should be r
Chris,
Yes, I will prepare a PR in the next days. However, as Tomcat 8.5 should be
able to work both on Java 7 and Java 8, interface default methods can't be
used. So would you prefer to have a second CookieProcessor.generateCookie(Map<>
requestHeaders, Cookie) in addition to the existing
CookiePr
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Lazar,
On 2/24/20 02:05, Lazar Kirchev wrote:
> Chris,
>
> CookieProcessor.generateCookie(Map<> requestHeaders, Cookie) will
> work perfectly for me and I guess for anyone who needs to check the
> client version.
Want to prepare a PR?
- -chris
>
Chris,
CookieProcessor.generateCookie(Map<> requestHeaders, Cookie) will work
perfectly for me and I guess for anyone who needs to check the client
version.
Kind regards,
Lazar
On Fri, Feb 21, 2020 at 7:17 PM Christopher Schultz <
ch...@christopherschultz.net> wrote:
> -BEGIN PGP SIGNED MES
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Lazar,
On 2/21/20 10:29, Lazar Kirchev wrote:
> Yes, the SameSite attribute is still in a draft and this causes
> the mess, at least partly.> And yes, I was thinking about something
> like that - CookieProcessor.generateCookie(String userAgent,
> Co
Chris,
Yes, the SameSite attribute is still in a draft and this causes the mess,
at least partly.
And yes, I was thinking about something like that -
CookieProcessor.generateCookie(String userAgent, Cookie) or
CookieProcessor.generateCookie(Map<> requestHeaders, Cookie). I absolutely
agree that t
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Lazar,
On 2/14/20 05:36, Lazar Kirchev wrote:
> Chris,
>
> Just FYI or in case someone else hits this problem.
>
> Actually I had to use the response wrapper approach for Tomcat
> 8.5.50 as well. As described by Chrome in
> https://www.chromium.org/
Chris,
Just FYI or in case someone else hits this problem.
Actually I had to use the response wrapper approach for Tomcat 8.5.50 as
well. As described by Chrome in
https://www.chromium.org/updates/same-site/incompatible-clients, there are
older browser versions which do not support the SameSite a
Thanks a lot Chris! I wish I could just get away from Tomcat 7 and upgrade
to 8.5, but I can't. Yes, the response wrapping will do.
Lazar
On Mon, Feb 3, 2020 at 4:30 PM Christopher Schultz <
ch...@christopherschultz.net> wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> Lazar,
>
> O
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Lazar,
On 2/3/20 5:42 AM, Lazar Kirchev wrote:
> Chris,
>
> With "having control on the server but not on the application" I
> meant that I could make changes on the server, but I have no
> control to make modification on the application code. My c
Chris,
With "having control on the server but not on the application" I meant that
I could make changes on the server, but I have no control to make
modification on the application code.
My concern with the changed Chrome behavior regarding the same site cookie
attribute (https://www.chromestatus.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Lazar,
On 1/30/20 12:25 PM, Lazar Kirchev wrote:
> The problem is that I cannot make it from within the application. I
> have no control on the application, only on the server, so I have
> to be able to set the cookie either in a server configuratio
The problem is that I cannot make it from within the application. I have no
control on the application, only on the server, so I have to be able to set
the cookie either in a server configuration or in a component which will
reside in the server. I am concerned particularly with the SmaeSite
attrib
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
John,
On 1/27/20 9:37 AM, John Dale wrote:
> Over the years I found it more productive to manage my own headers
> for the most part.
>
> The key for us has been keeping the code clean and manageable.
+1
But there isn't any reason not to use Tomca
Over the years I found it more productive to manage my own headers for
the most part.
The key for us has been keeping the code clean and manageable.
John
On 1/27/20, Lazar Kirchev wrote:
> Hello,
>
> In Tomcat >= 8 there is the CookieProcessor in which cookie configurations
> could be made, in
Hello,
In Tomcat >= 8 there is the CookieProcessor in which cookie configurations
could be made, including for SameSite cookie.
Is there any way to configure this in Tomcat 7? Or the only way is to
configure it manually in code?
Kind regards,
Lazar
21 matches
Mail list logo
