Re: Expect: 100-continue with filters vs valves

2020-02-21 Thread Mark Thomas
On 19/02/2020 20:17, Michael Osipov wrote: > Am 2020-02-18 um 23:43 schrieb Mark Thomas: >> On 18/02/2020 19:47, Michael Osipov wrote: >>> If you say this is also a limitation in the Servlet API, it is worth to >>> raise that as a clarification point? >> >> Sure. It won't happen until at least S

Re: Expect: 100-continue with filters vs valves

2020-02-19 Thread Michael Osipov
collection). That means it happens after any Engine/Host/Context Valves you have configured but before any Filters. This enhancement request would help: https://bz.apache.org/bugzilla/show_bug.cgi?id=57661 but it would need to be made optional as it will add a delay to the request processing in so

Re: Expect: 100-continue with filters vs valves

2020-02-18 Thread Mark Thomas
has to provide the "100 Continue" response >> since there isn't a Servlet API for the app to do so. It does this as >> the final act in the Context's pipeline (valve collection). That means >> it happens after any Engine/Host/Context Valves you have configu

Re: Expect: 100-continue with filters vs valves

2020-02-18 Thread Michael Osipov
fficient. It ends up sending the body twice. The answer is that Tomcat has to provide the "100 Continue" response since there isn't a Servlet API for the app to do so. It does this as the final act in the Context's pipeline (valve collection). That means it happens after any Engine

Re: Expect: 100-continue with filters vs valves

2020-02-18 Thread Mark Thomas
as the Filter is less efficient. It ends up sending the body twice. The answer is that Tomcat has to provide the "100 Continue" response since there isn't a Servlet API for the app to do so. It does this as the final act in the Context's pipeline (valve collection). That

Re: Expect: 100-continue with filters vs valves

2020-02-18 Thread Michael Osipov
Am 2020-02-18 um 10:00 schrieb Mark Thomas: On 17/02/2020 20:17, Michael Osipov wrote: I have continued some tests on 8.5.51 with PUT requests and Expect: 100 continue header from HttpClient 5.0. I have noticed that the very same code code fragment What code fragment? My bad, here it is: F

Re: Expect: 100-continue with filters vs valves

2020-02-18 Thread Mark Thomas
On 17/02/2020 20:17, Michael Osipov wrote: > I have continued some tests on 8.5.51 with PUT requests and Expect: 100 > continue header from HttpClient 5.0. > > I have noticed that the very same code code fragment What code fragment? > kicks in in the > expect header evaluation when run as valve

Expect: 100-continue with filters vs valves

2020-02-17 Thread Michael Osipov
I have continued some tests on 8.5.51 with PUT requests and Expect: 100 continue header from HttpClient 5.0. I have noticed that the very same code code fragment kicks in in the expect header evaluation when run as valve, but completely ignored when run in a filter. Tomcat will simply signal t

Bug 45014 - Request and Response classes should have wrappers for use in Valves

2017-10-05 Thread Amit Pande
https://bz.apache.org/bugzilla/show_bug.cgi?id=45014 Any plans/thoughts on merging Chris' mod in Tomcat 9.x branch? It is really a nice to have built in support for Valves to have wrapper classes for Request and Response. We also had a requirement to read the request payload at a valve

RE: Valves

2011-09-13 Thread Caldarale, Charles R
> From: Ricardo Bayley [mailto:ricardo.bay...@gmail.com] > Subject: Valves > I read this articles but I don't understand where or which > xml file to edit. > Can anyone tell me where should I configure it ? You configure the at the desired scope. If you want it to affect

Re: Valves

2011-09-13 Thread David Bernard
Here the search result in tomcat 6.0 installation: F:\Tomcat 6.0\conf Searching for: valves context.xml(32): server.xml(19): define subcomponents such as "Valves" at this level. server.xml(50): so you may not define subcomponents such as "Valves" at this level. server.xml(1

Valves

2011-09-13 Thread Ricardo Bayley
Hi folks, I am new to tomcat. I use a webapp which runs in tomcat. I would like tomcat to filter requests according to remote host / address. I understand I need to set "Remote Address Filter" and the "Remote Host Filter" in the Valve component. I read this articles but I don't understand where o

Re: Valves being converted to Filters?

2009-10-22 Thread Elli Albek
that case it may be safer to just use that class in the method signatures. E - Original Message - From: Christopher Schultz To: Tomcat Users List Sent: Wed, 21 Oct 2009 08:11:17 -0700 (PDT) Subject: Re: Valves being converted to Filters? Will there be a way to grab information from

Re: Valves being converted to Filters?

2009-10-21 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mark, On 10/20/2009 9:47 PM, Mark Thomas wrote: >> Is there a specific reason for this? > > Portability, reduce internal code duplication (filters & valves have a lot in > common) Also, Tomcat has never provided standard r

Re: Valves being converted to Filters?

2009-10-21 Thread Mark Thomas
Eric B. wrote: > "Mark Thomas" wrote in message > news:200910202047470...@265006334... > >>> Although I love filters, I find that valves have a very specific need >>> within >>> the container as well; it allows you to configure the container >&g

RE: Valves being converted to Filters?

2009-10-20 Thread Elli Albek
So is there still going to be an API to plug into the tomcat internals and do things that the servlet API does not support? E -Original Message- From: Cyrille Le Clerc [mailto:clecl...@xebia.fr] Sent: Tuesday, October 20, 2009 4:06 PM To: Tomcat Users List Subject: Re: Valves being

Re: Valves being converted to Filters?

2009-10-20 Thread Eric B.
"Mark Thomas" wrote in message news:200910202047470...@265006334... >> Although I love filters, I find that valves have a very specific need >> within >> the container as well; it allows you to configure the container >> independently of the application.

Re: Valves being converted to Filters?

2009-10-20 Thread Mark Thomas
> From: "Eric B." > To: users@tomcat.apache.org > Sent: 20/10/09, 15:38:59 > Subject: Valves being converted to Filters? > Is this true? Is Tomcat moving away from valves and towards filters in the > next version(s)? Sort off. Ideally everywhere but I suspect som

Re: Valves being converted to Filters?

2009-10-20 Thread Cyrille Le Clerc
   Hello Henri,    I was referring to public information such as : - Google Summer Of Code 2009, project "Convert current Tomcat valves to Servlet Filters" : http://wiki.apache.org/tomcat/SummerOfCode2009 and the various associated emails on Tomcat dev mailing list. - Mark Thomas post

Valves being converted to Filters?

2009-10-20 Thread Eric B.
Hi, I was looking at Bug 47330 (https://issues.apache.org/bugzilla/show_bug.cgi?id=47330) which is a filter / valve implementation of a Httpd's mod_remoteip module. What concerned me is a comment by the submitter at the very bottom of the report: "... As Tomcat valves are curre

Tomcat 6 Valves Development

2008-03-04 Thread amit kumar
Hi, I am looking for some reference material or tutorial over net on how to begin with development of my own tomcat 6 valves. I have started looking at a book which is for tomcat 5 and it seems to import following from catalina.jar import org.apache.catalina.HttpResponse; import

question about valves reporting inet6 addresses

2007-03-30 Thread jpsla
ss() was: 0:0:0:0:0:0:0:1%0 Which looks suspiciously like an inet6 address. No wonder my valves were not working; when using the address valve, I was expecting a 4 octet address, and when using the hostname valve, no attempt was being made to resolve the remote hostname at all. BTW, dis

Configuration of Valves with nested elements

2006-11-14 Thread Hacim Bengali
Hi, is it only possible to configure valves using attributes in the server.xml or with nested elements, too, like with MyValve having an attribute of type FooBar. Best regards Achim - To start a new topic, e-mail

Re[2]: Fast response, using valves

2006-03-13 Thread Èëüÿ
Well, I don't think so. 1. The benchmark tool was taken from this site: http://www.caucho.com/articles/jsp_benchmark.xtp it's written in C and doesn't seem to understand caching. 2. Nothing changed after I added following lines to my servlet response.setHeader("Cache-Control","no-cache"); //

Re: Fast response, using valves

2006-03-13 Thread David Delbecq
Perhaps because, in the version without valve, you benchmarking tool use the expected behaviour of browsers when they have an active cache: request 'if-modified-since', to which tomcat will respond a 'not modified'. Rumata a écrit : >Hello. > >I'm trying to make Tomcat server response to some kin

Fast response, using valves

2006-03-13 Thread Rumata
Hello. I'm trying to make Tomcat server response to some kind of request as fast as possible. As far as I understood I can stop processing of request using a valve registered in the Engine pipeline. I wrote the following code: public class testValve extends org.apache.catalina.valves.ValveBase {