Re: Tomcat 9 build from scratch

2023-12-02 Thread Aditya Shastri
Thank you for the clarification! Thank you Chris, Mark, Adwait! On Fri, Dec 1, 2023 at 2:07 PM Christopher Schultz wrote: > > Aditya, > > On 12/1/23 12:48, Aditya Shastri wrote: > >> Yes. Equally importantly it also ensures that the code is compiled > >> against the Java 8 API. > > > > Makes se

Re: Tomcat 9 build from scratch

2023-12-01 Thread Christopher Schultz
Aditya, On 12/1/23 12:48, Aditya Shastri wrote: Yes. Equally importantly it also ensures that the code is compiled against the Java 8 API. > Makes sense! It is used for property replacement in the documentation for the minimum Java version required at runtime. We do it this way so the docume

Re: Tomcat 9 build from scratch

2023-12-01 Thread Aditya Shastri
> Yes. Equally importantly it also ensures that the code is compiled against the Java 8 API. Makes sense! > It is used for property replacement in the documentation for the minimum Java version required at runtime. We do it this way so the documentation source files can be the same for all Tomcat

Re: Tomcat 9 build from scratch

2023-12-01 Thread Mark Thomas
On 30/11/2023 23:38, Aditya Shastri wrote: Thanks for the response Adwait. My ant skills are lacking. Does the minimum bytecode definition come from this line? Yes. Equally importantly it also ensures that the code is compiled against the Java 8 API. What does this line do? It is us

Re: Tomcat 9 build from scratch

2023-11-30 Thread Aditya Shastri
Sounds good. Thanks! On Thu, Nov 30, 2023 at 3:40 PM Adwait Kumar Singh wrote: > > The former. > > > > On Thu, Nov 30, 2023 at 3:40 PM Aditya Shastri > wrote: > > > Thanks for the response Adwait. > > > > My ant skills are lacking. Does the minimum bytecode definition come > > from this line? >

Re: Tomcat 9 build from scratch

2023-11-30 Thread Adwait Kumar Singh
The former. On Thu, Nov 30, 2023 at 3:40 PM Aditya Shastri wrote: > Thanks for the response Adwait. > > My ant skills are lacking. Does the minimum bytecode definition come > from this line? > > > What does this line do? > > > On Thu, Nov 30, 2023 at 6:10 PM Adwait Kumar Singh > wrote: >

Re: Tomcat 9 build from scratch

2023-11-30 Thread Aditya Shastri
Thanks for the response Adwait. My ant skills are lacking. Does the minimum bytecode definition come from this line? What does this line do? On Thu, Nov 30, 2023 at 6:10 PM Adwait Kumar Singh wrote: > > Yes, JDK17 can produce JDK8 bytecode, in fact that's what Tomcat does. > > On Thu, Nov 3

Re: Tomcat 9 build from scratch

2023-11-30 Thread Adwait Kumar Singh
Yes, JDK17 can produce JDK8 bytecode, in fact that's what Tomcat does. On Thu, Nov 30, 2023 at 2:35 PM Aditya Shastri wrote: > Hello, > > We build our own Tomcat 9 binaries from scratch (grab the tag from > https://github.com/apache/tomcat) and call ant (with java8) to build > it. > > Starting w

Tomcat 9 build from scratch

2023-11-30 Thread Aditya Shastri
Hello, We build our own Tomcat 9 binaries from scratch (grab the tag from https://github.com/apache/tomcat) and call ant (with java8) to build it. Starting with 9.0.83, our pipelines are failing with the error build.xml:113: Java version 17 or newer is required (1.8.0_381 is installed) The apps