Re: vimdiff wrapper for diff-cmd not working with 1.8

2013-06-27 Thread Daniel Shahaf
Michael Schlottke wrote on Wed, Jun 26, 2013 at 17:34:15 +0200: > > On Jun 21, 2013, at 15:23 , Philip Martin wrote: > > Another user raised the issue > > > > http://subversion.tigris.org/issues/show_bug.cgi?id=4382 > > > > Using '--diff-cmd colordiff' to get coloured output no longer works. > >

Re: vimdiff wrapper for diff-cmd not working with 1.8

2013-06-26 Thread Michael Schlottke
On Jun 21, 2013, at 15:23 , Philip Martin wrote: > Another user raised the issue > > http://subversion.tigris.org/issues/show_bug.cgi?id=4382 > > Using '--diff-cmd colordiff' to get coloured output no longer works. > > Here's a solution that requires the user to mark the command as > requiring

Re: vimdiff wrapper for diff-cmd not working with 1.8

2013-06-21 Thread Philip Martin
Philip Martin writes: > It's also hard to fix 1.8, how do we pass the information into the > client library without changing the API? Perhaps we could recognise a > special part of the command name or a special external parameter, so > >--diff-cmd svn:interactive:myscript Another user raise

Re: vimdiff wrapper for diff-cmd not working with 1.8

2013-06-19 Thread Michael Schlottke
On Jun 19, 2013, at 12:08 , Philip Martin wrote: > Philip Martin writes: > >> Ben Reser writes: >> >>> I don't imagine it'd take very long at all to implement but the >>> problem of course is that we really should think carefully how we go >>> about doing this. If we can detect this at runtim

Re: vimdiff wrapper for diff-cmd not working with 1.8

2013-06-19 Thread Philip Martin
Philip Martin writes: > Ben Reser writes: > >> I don't imagine it'd take very long at all to implement but the >> problem of course is that we really should think carefully how we go >> about doing this. If we can detect this at runtime we probably >> should. > > I don't see how Subversion can

Re: vimdiff wrapper for diff-cmd not working with 1.8

2013-06-19 Thread Philip Martin
Michael Schlottke writes: > However, for now I'd prefer a quick-n-dirty solution rather than not > being able to upgrade at all. I know this is asking for quite > something, especially since I don't know how to do it myself :-/ Here's my really quick-n-dirty patch used during investigation. It'

Re: vimdiff wrapper for diff-cmd not working with 1.8

2013-06-19 Thread Michael Schlottke
On Jun 19, 2013, at 09:56 , Ben Reser wrote: > On Wed, Jun 19, 2013 at 9:11 AM, Michael Schlottke > wrote: >> Do you have an idea of how hard this is to achieve, or how long it would >> take to create a patch? I'd be happy to volunteer as a tester… >> Or do you know of an interim hack that I cou

Re: vimdiff wrapper for diff-cmd not working with 1.8

2013-06-19 Thread Philip Martin
Ben Reser writes: > I don't imagine it'd take very long at all to implement but the > problem of course is that we really should think carefully how we go > about doing this. If we can detect this at runtime we probably > should. I don't see how Subversion can determine that one script needs a

Re: vimdiff wrapper for diff-cmd not working with 1.8

2013-06-19 Thread Ben Reser
On Wed, Jun 19, 2013 at 9:11 AM, Michael Schlottke wrote: > Do you have an idea of how hard this is to achieve, or how long it would > take to create a patch? I'd be happy to volunteer as a tester… > Or do you know of an interim hack that I could use until it is properly > fixed? I don't imagine

Re: vimdiff wrapper for diff-cmd not working with 1.8

2013-06-19 Thread Michael Schlottke
On Jun 19, 2013, at 01:58 , Philip Martin wrote: > [cc to dev] > > Michael Schlottke writes: > >> I just installed svn 1.8 on our cluster. Before, we used svn 1.7.9 and >> a little vimdiff wrapper (taken, with a few changes, from >> http://svnbook.red-bean.com/nightly/en/svn.advanced.externald

Re: vimdiff wrapper for diff-cmd not working with 1.8

2013-06-18 Thread Philip Martin
[cc to dev] Michael Schlottke writes: > I just installed svn 1.8 on our cluster. Before, we used svn 1.7.9 and > a little vimdiff wrapper (taken, with a few changes, from > http://svnbook.red-bean.com/nightly/en/svn.advanced.externaldifftools.html#svn.advanced.externaldifftools.diff), > which wo

vimdiff wrapper for diff-cmd not working with 1.8

2013-06-18 Thread Michael Schlottke
Hi there, I just installed svn 1.8 on our cluster. Before, we used svn 1.7.9 and a little vimdiff wrapper (taken, with a few changes, from http://svnbook.red-bean.com/nightly/en/svn.advanced.externaldifftools.html#svn.advanced.externaldifftools.diff), which worked like a charm when called as "s