Proposed edit to fs.py: Change 'w+' to 'wb' when copying svn stream object
>> to temporary file. Update isn't needed, and the code just needs to dump
>> the
>> raw data into a file for the external diff to access, so no
>> encoding/decoding should occur. Hence we should open the file in binary
>> m
On Thu, Feb 1, 2018, 12:34 PM Kenneth Porter wrote:
> [moving discussion to dev list as I think this is now the correct fix.]
>
> --On Wednesday, January 31, 2018 7:40 PM -0800 Kenneth Porter
> wrote:
>
> > --On Wednesday, January 31, 2018 7:23 PM -0800 Kenneth Porter
> > wrote:
> >
> >> fp
[moving discussion to dev list as I think this is now the correct fix.]
--On Wednesday, January 31, 2018 7:40 PM -0800 Kenneth Porter
wrote:
--On Wednesday, January 31, 2018 7:23 PM -0800 Kenneth Porter
wrote:
fp = builtins.open(file, 'w+') # avoid namespace clash with
On Wed, Jan 31, 2018 at 10:40 PM, Kenneth Porter wrote:
> --On Wednesday, January 31, 2018 7:23 PM -0800 Kenneth Porter
> wrote:
>
>> fp = builtins.open(file, 'w+') # avoid namespace clash with
>># trimmed-down svn_fs_open()
>
>
> I'm now thinking the probl
--On Wednesday, January 31, 2018 7:23 PM -0800 Kenneth Porter
wrote:
fp = builtins.open(file, 'w+') # avoid namespace clash with
# trimmed-down svn_fs_open()
I'm now thinking the problem is in the open call, and that I'm somehow
getting a Python 3 open
--On Tuesday, January 23, 2018 7:14 AM -0800 Kenneth Porter
wrote:
File "/usr/lib64/python2.7/site-packages/svn/fs.py", line 87, in
_dump_contents
fp.write(chunk)
TypeError: must be unicode, not str
Here's the code where this is going wrong. I think svn_stream_read is
returning a by
