Re: empty pre-commit hook fails with svn+ssh with some accounts

2011-07-21 Thread Nico Kadel-Garcia
On Thu, Jul 21, 2011 at 7:24 PM, David Chapman wrote: > On 7/21/2011 4:00 PM, Daniel Neuberger wrote: >> >> On Thu, Jul 21, 2011 at 2:13 PM, Nico Kadel-Garcia >>  wrote: >>> >>> Don't give the shared "svn" user a valid shell If an administrator >>> needs to run operations as that user, to mani

Re: empty pre-commit hook fails with svn+ssh with some accounts

2011-07-21 Thread David Chapman
On 7/21/2011 4:00 PM, Daniel Neuberger wrote: On Thu, Jul 21, 2011 at 2:13 PM, Nico Kadel-Garcia wrote: Don't give the shared "svn" user a valid shell If an administrator needs to run operations as that user, to manipulate config files or create new repositories, they can do "sudo -s -H -u

Re: empty pre-commit hook fails with svn+ssh with some accounts

2011-07-21 Thread Daniel Neuberger
On Thu, Jul 21, 2011 at 2:13 PM, Nico Kadel-Garcia wrote: > Don't give the shared "svn" user a valid shell If an administrator > needs to run operations as that user, to manipulate config files or > create new repositories, they can do "sudo -s -H -u svn" to get a > valid shell as the administ

Re: empty pre-commit hook fails with svn+ssh with some accounts

2011-07-21 Thread Nico Kadel-Garcia
On Thu, Jul 21, 2011 at 11:05 AM, Daniel Neuberger wrote: > On Thu, Jul 21, 2011 at 10:51 AM, Nico Kadel-Garcia wrote: >> Stop *RIGHT* there. Go grab the Subverson 1.6.x from the RHEL updates. >> Do not pass go, do not collect $200 until you do this sitewide.  There >> are significant security an

Re: empty pre-commit hook fails with svn+ssh with some accounts

2011-07-21 Thread Daniel Neuberger
On Thu, Jul 21, 2011 at 11:16 AM, Konstantin Kolinko wrote: > The scripts have execute permissions for those other users? Yes. > Maybe svn cannot find bash to execute those scripts? Consider what > happens when you run with empty PATH.  One known example is the tasks > run by cron. The same scrip

Re: empty pre-commit hook fails with svn+ssh with some accounts

2011-07-21 Thread Konstantin Kolinko
2011/7/21 Daniel Neuberger : > In short, we have a repository owned by one user that is accessed by > tunneling over ssh to other user accounts. Can't comment on this. > The hooks work fine though if I ssh to the user account that owns the > repository rather than another user account (we can't o

Re: empty pre-commit hook fails with svn+ssh with some accounts

2011-07-21 Thread Daniel Neuberger
On Thu, Jul 21, 2011 at 11:01 AM, Daniel Shahaf wrote: > ls -ald $REPOS_DIR $REPOS_DIR/hooks/ $REPOS_DIR/hooks/pre-commit $ ls -ald repos/testrepo repos/testrepo/hooks/ repos/testrepo/hooks/pre-commit drwxrwxrwx 7 svnuser svnuser 4096 Jul 20 13:03 repos/testrepo drwxrwxrwx 2 svnuser svnuser 4096

Re: empty pre-commit hook fails with svn+ssh with some accounts

2011-07-21 Thread Daniel Neuberger
On Thu, Jul 21, 2011 at 10:51 AM, Nico Kadel-Garcia wrote: > Stop *RIGHT* there. Go grab the Subverson 1.6.x from the RHEL updates. > Do not pass go, do not collect $200 until you do this sitewide.  There > are significant security and performance improvements, well worth the > update pain. Okay,

Re: empty pre-commit hook fails with svn+ssh with some accounts

2011-07-21 Thread Daniel Shahaf
ls -ald $REPOS_DIR $REPOS_DIR/hooks/ $REPOS_DIR/hooks/pre-commit Daniel Neuberger wrote on Thu, Jul 21, 2011 at 09:36:22 -0400: > We have a rather unique setup to meet certain requirements and as a > result I can't get any hooks to work (even empty ones or ones that > just exit with a zero return

Re: empty pre-commit hook fails with svn+ssh with some accounts

2011-07-21 Thread Nico Kadel-Garcia
On Thu, Jul 21, 2011 at 9:36 AM, Daniel Neuberger wrote: > We have a rather unique setup to meet certain requirements and as a > result I can't get any hooks to work (even empty ones or ones that > just exit with a zero return code). > > In short, we have a repository owned by one user that is acc