Re: Extra blank line when using command line editor for commit message

2014-04-23 Thread Ryan Schmidt
On Apr 23, 2014, at 04:37, Ryan Schmidt wrote: > Just install a pre-commit-hook script allowing modification of those > properties er, make that a pre-revprop-change hook script.

Re: Extra blank line when using command line editor for commit message

2014-04-23 Thread Ryan Schmidt
On Apr 22, 2014, at 22:22, Justin Mrkva wrote: > I see, that’s good to know. I’ll definitely set it up, it does make sense to > strip whitespace. Not sure why that isn’t done by default. :) > > Now I just have to figure out if a dump/load will apply the hooks to to clean > up old log messages

Re: Extra blank line when using command line editor for commit message

2014-04-22 Thread Justin Mrkva
I see, that’s good to know. I’ll definitely set it up, it does make sense to strip whitespace. Not sure why that isn’t done by default. :) Now I just have to figure out if a dump/load will apply the hooks to to clean up old log messages that have trailing whitespace. Not a big deal in the scheme

Re: Extra blank line when using command line editor for commit message

2014-04-22 Thread Ryan Schmidt
On Apr 22, 2014, at 12:52, Justin Mrkva wrote: > On Apr 21, 2014, at 6:19 PM, Ryan Schmidt wrote: > >> Yes: install the log-police.py hook script in your repository. >> >> http://svn.apache.org/repos/asf/subversion/trunk/tools/hook-scripts/log-police.py > > That looks good at first, but this e

Re: Extra blank line when using command line editor for commit message

2014-04-22 Thread Justin Mrkva
That looks good at first, but this excerpt from the Subversion book explains why that’s a bad idea: While hook scripts can do almost anything, there is one dimension in which hook script authors should show restraint: do not modify a commit transaction using hook scripts. While it might be temp

Re: Extra blank line when using command line editor for commit message

2014-04-21 Thread Ryan Schmidt
On Apr 21, 2014, at 16:56, Justin Mrkva wrote: > I use nano as the editor for command line commits. If I commit with the > command line editor, Subversion adds an extra line to the commit. Observe: > > > > justins-macbook-pro:copy1 justinmrkva$ svn log | head -n 15 > -