Re: git patch comments

2011-06-13 Thread Todd Zullinger
Bruno Wolff III wrote: > On Mon, Jun 13, 2011 at 10:32:59 -0500, > Michael Cronenworth wrote: >> >> I double checked the patches and indeed they are formatted as: >> >> line 1 >> line 2 >> line 3 >> >> Testing the following formatting of: >> >> line 1 >> >> line 2 >> line 3 >> >> results in the

Re: git patch comments

2011-06-13 Thread Bruno Wolff III
On Mon, Jun 13, 2011 at 10:32:59 -0500, Michael Cronenworth wrote: > > I double checked the patches and indeed they are formatted as: > > line 1 > line 2 > line 3 > > Testing the following formatting of: > > line 1 > > line 2 > line 3 > > results in the expected formatting. Slightly annoyi

Re: git patch comments

2011-06-13 Thread Michael Cronenworth
Todd Zullinger wrote: > However, I'm still curious to see a git formatted patch that > is affected here. I use git am regularly and have never seen this. I would post one, but they are proprietary. I double checked the patches and indeed they are formatted as: line 1 line 2 line 3 Testing the

Re: git patch comments

2011-06-13 Thread Todd Zullinger
Michael Cronenworth wrote: > That's how the git patches are created. If it is supposed to work then > it is a bug because it is not working that way. I'll get this posted to > the git list/bugzilla when I can. Thanks. There isn't any git bugzilla, so just mailing the git list is the way to go. Ho

Re: git patch comments

2011-06-13 Thread Michael Cronenworth
Todd Zullinger wrote: > For git commits, you should use the format: > > $subject > > $body That's how the git patches are created. If it is supposed to work then it is a bug because it is not working that way. I'll get this posted to the git list/bugzilla when I can. Thanks. -- users mailing li

Re: git patch comments

2011-06-12 Thread Todd Zullinger
James McKenzie wrote: > On 6/8/11 2:52 PM, Michael Cronenworth wrote: >> Turns into: >> Git comment - bullet 1 - bullet 2 >> > This is how git formats the text when it sends the bug in. I've > done this myself and was surprised when formatting I applied > disappeared. If you want the latter, you'

Re: git patch comments

2011-06-11 Thread James McKenzie
On 6/8/11 2:52 PM, Michael Cronenworth wrote: > Turns into: > Git comment - bullet 1 - bullet 2 > This is how git formats the text when it sends the bug in. I've done this myself and was surprised when formatting I applied disappeared. If you want the latter, you'll have to inform the git folks

Re: git patch comments

2011-06-10 Thread Michael Cronenworth
Stephen Gallagher wrote: > I suspect that you are saving your patches with Windows line endings > instead of UNIX line endings, so when you import it on linux, they are > no longer available. Try running dos2unix on the file before importing > it. The systems that use git are all running Fedora. T

Re: git patch comments

2011-06-09 Thread Stephen Gallagher
On Wed, 2011-06-08 at 16:52 -0500, Michael Cronenworth wrote: > I just realized git patches I have been applying to a local repository > are not saving the comments correctly. > > The git patch has properly formatted, with newlines, comments. Some have > bullet points. When I run "git am ~/0001-

git patch comments

2011-06-08 Thread Michael Cronenworth
I just realized git patches I have been applying to a local repository are not saving the comments correctly. The git patch has properly formatted, with newlines, comments. Some have bullet points. When I run "git am ~/0001-fix.patch" the resulting git history shows the git comment as all one l