Re: Files not deleted after compaction and GCed

2011-01-26 Thread Ching-Cheng Chen
I think this might be what happening. Since you are using ScheduledThreadPoolExecutor.schedule(), the exception was swallowed by the FutureTask. You will have to perform a get() method on the ScheduledFuture, and you will get ExecutionException if there was any exception occured in run(). Regard

Re: Files not deleted after compaction and GCed

2011-01-26 Thread Jonathan Ellis
Patch submitted. One thing I still don't understand is why RetryingScheduledThreadPoolExecutor isn't firing the DefaultUncaughtExceptionHandler, which should have logged that exception. On Wed, Jan 26, 2011 at 9:41 AM, Jonathan Ellis wrote: > Thanks for tracking that down!  Created > https://iss

Re: Files not deleted after compaction and GCed

2011-01-26 Thread Jonathan Ellis
Thanks for tracking that down! Created https://issues.apache.org/jira/browse/CASSANDRA-2059 to fix. On Wed, Jan 26, 2011 at 8:17 AM, Ching-Cheng Chen wrote: > It's a bug. > In SSTableDeletingReference, it try this operation > components.remove(Component.DATA); > before > STable.delete(desc, comp

Re: Files not deleted after compaction and GCed

2011-01-26 Thread Ching-Cheng Chen
It's a bug. In SSTableDeletingReference, it try this operation components.remove(Component.DATA); before STable.delete(desc, components); However, the components was reference to the components object which was created inside SSTable by this.components = Collections.unmodifiableSet(dataCompon

Re: Files not deleted after compaction and GCed

2011-01-25 Thread Jonathan Ellis
the other component types are deleted by this line: SSTable.delete(desc, components); On Tue, Jan 25, 2011 at 3:11 PM, Ching-Cheng Chen wrote: > Nope, no exception at all. > But if the same class > (org.apache.cassandra.io.sstable.SSTableDeletingReference) is responsible > for delete

Re: Files not deleted after compaction and GCed

2011-01-25 Thread Ching-Cheng Chen
Nope, no exception at all. But if the same class (org.apache.cassandra.io.sstable.SSTableDeletingReference) is responsible for delete other files, then that's not right. I checked the source code for SSTableDeletingReference, doesn't looks like it will delete other files type. Regards, Chen On

Re: Files not deleted after compaction and GCed

2011-01-25 Thread Jonathan Ellis
No, that is not expected. All the sstable components are removed in the same method; did you check the log for exceptions? On Tue, Jan 25, 2011 at 2:58 PM, Ching-Cheng Chen wrote: > Using cassandra 0.7.0 > The class org.apache.cassandra.io.sstable.SSTableDeletingReference only > remove the -

Files not deleted after compaction and GCed

2011-01-25 Thread Ching-Cheng Chen
Using cassandra 0.7.0 The class org.apache.cassandra.io.sstable.SSTableDeletingReference only remove the -Data.db file, but leave the xxx-Compacted, xxx-Filter.db, xxx-Index.db and xxx-Statistics.db intact. And that's the behavior I saw.I ran manual compact then trigger a GC from jconsole