[Bug 1981807] Re: qt5-network openssl3 armhf does not support tls1.3

2022-07-18 Thread msaxl
i think I have a trace where the issue is: openssl3 openssl's options is a uint64_t, but in qsslsocket_openssl.cpp the method is defined as long QSslSocketBackendPrivate::setupOpenSslOptions(QSsl::SslProtocol protocol, QSsl::SslOptions sslOptions) long on 64bit platforms is 64 bit long, but on

[Bug 1981807] Re: qt5-network openssl3 armhf does not support tls1.3

2022-07-18 Thread msaxl
this should fix the issue this however requires openssl3.0, but that should be ok for ubuntu going forward ** Patch added: "openssl3_set_options.patch" https://bugs.launchpad.net/ubuntu/+source/qtbase-opensource-src/+bug/1981807/+attachment/5603721/+files/openssl3_set_options.patch -- You r

[Bug 1981807] Re: qt5-network openssl3 armhf does not support tls1.3

2022-07-18 Thread Ubuntu Foundations Team Bug Bot
The attachment "openssl3_set_options.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~b

[Bug 1981807] Re: qt5-network openssl3 armhf does not support tls1.3

2022-07-18 Thread msaxl
actually the first patch was missing something and did not compile ** Patch added: "openssl3_set_options.diff" https://bugs.launchpad.net/ubuntu/+source/qtbase-opensource-src/+bug/1981807/+attachment/5603782/+files/openssl3_set_options.diff ** Patch removed: "openssl3_set_options.patch" h

[Bug 1981807] Re: qt5-network openssl3 armhf does not support tls1.3

2022-07-18 Thread Dmitry Shachnev
Thank you for the patch! Qt 6 still uses unsigned long: https://code.qt.io/cgit/qt/qtbase.git/tree/src/plugins/tls/openssl/qsslsocket_openssl_symbols.cpp#n126 Can you please submit your patch to codereview.qt-project.org, or at least file a bug at bugreports.qt.io? We usually don't add patches t

[Bug 1981807] Re: qt5-network openssl3 armhf does not support tls1.3

2022-07-18 Thread msaxl
https://bugreports.qt.io/browse/QTBUG-105041 this however has priority low. additionally openssl1.1 and openssl3 are not compatible in this case if libssl is loaded in runtime for 32bit this is only solvable if compiletime forces openssl version to 3 OR 1.1, but then the corresponding version MU

[Bug 1981807] Re: qt5-network openssl3 armhf does not support tls1.3

2022-07-18 Thread msaxl
just a side node on the findings while hunting down this issue in gdb: on armhf I think the calling convention is that integers are passed on registers. uint64 is not a (32bit) integer and since the value passed to SSL_CTX_set_options was not related in any way to the value passed in q_SSL_CTX_set