Re: [Bug 476662] Re: Notifications use append instead of replace

2010-03-31 Thread Nicolò Chieffo
Can you do the report? I'm very busy in these days, sorry. -- Notifications use append instead of replace https://bugs.launchpad.net/bugs/476662 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lis

Re: [Bug 476662] Re: Notifications use append instead of replace

2010-03-31 Thread Nicolò Chieffo
No, my patch fixes only the bug description, so the notifications from users different from the first one are still missed. I'm sure that the problem can be fixed in empathy-status-icon.c but patch 35_check_actions_notifications.patch needs some additional work. I'm sorry but I can't do this, becau

Re: [Bug 476662] Re: Notifications use append instead of replace

2010-03-31 Thread Nicolò Chieffo
Should we open another bug for the missing notifications? -- Notifications use append instead of replace https://bugs.launchpad.net/bugs/476662 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@list

Re: [Bug 476662] Re: Notifications use append instead of replace

2010-03-30 Thread Nicolò Chieffo
I talked with upstream. They don't want to remove this behavior until they have a way to selectively open chat windows (ubuntu has this). The code logic is in empathy-status-icon.c -- Notifications use append instead of replace https://bugs.launchpad.net/bugs/476662 You received this bug notifica

Re: [Bug 476662] Re: Notifications use append instead of replace

2010-03-30 Thread Nicolò Chieffo
No, the problem is also downstream, since the notifications are eaten until you click on the status icon. This is completely a bug in my opinion: all the notifications should appear always. -- Notifications use append instead of replace https://bugs.launchpad.net/bugs/476662 You received this bug

Re: [Bug 476662] Re: Notifications use append instead of replace

2010-03-30 Thread Nicolò Chieffo
Sorry, I don't know how to fix this, eating the messages is not a problem introduced by my patch. Can someone file a bug upstream? -- Notifications use append instead of replace https://bugs.launchpad.net/bugs/476662 You received this bug notification because you are a member of Ubuntu Bugs, whic

Re: [Bug 476662] Re: Notifications use append instead of replace

2010-03-24 Thread Nicolò Chieffo
Are you sure it works as you expect, without the patch? I never close the notifications so I can't understand why they are eaten. It might be an already existing problem... -- Notifications use append instead of replace https://bugs.launchpad.net/bugs/476662 You received this bug notification bec

Re: [Bug 476662] Re: Notifications use append instead of replace

2010-03-24 Thread Nicolò Chieffo
I also have a question: do I need to g_object_unref a notification that has been shown, or is it automatic? I think I have to unref it, so the "closed" event is raised. I couldn't find this in the notify_notification doc. -- Notifications use append instead of replace https://bugs.launchpad.net/b

Re: [Bug 476662] Re: Notifications use append instead of replace

2010-03-24 Thread Nicolò Chieffo
Well the problem could be caused by calling g_object_unref too early... I'll also try to postpone the call -- Notifications use append instead of replace https://bugs.launchpad.net/bugs/476662 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubunt

Re: [Bug 476662] Re: Notifications use append instead of replace

2010-03-24 Thread Nicolò Chieffo
Hi, I'm glad you already reviewed the patch! > 1) We do need the same logic applied to empathy-status-icon.c, without it we don't get notifications when the chat window isn't open.  Can you apply the same logic there? I'll try to do this > 2) It works well for IMs from one person, but if you hav